FormUserProvider::refreshUser() - Code Metrics - Inspection of "Custom user authenticator and provider" - Kyberia/kyberia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 456f1c...054456 )

by Marek

created 2017-02-21 13:51 UTC

FormUserProvider::refreshUser() A

↳ Parent: FormUserProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	2
eloc	4
nc	2
nop	1

<?php
namespace AppBundle\Security;

use AppBundle\Entity\User;
use AppBundle\Service\UserService;
use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
use Symfony\Component\Security\Core\Exception\UsernameNotFoundException;
use Symfony\Component\Security\Core\User\UserInterface;
use Symfony\Component\Security\Core\User\UserProviderInterface;

class FormUserProvider implements UserProviderInterface
{
    /** @var UserService */
    private $userService;

    public function __construct(UserService $userService)
    {
        $this->userService = $userService;
    }

    /**
     * @inheritdoc
     *
     * @param string $username Compound username [type:username]
     *
     * @return null|User
     */
    public function loadUserByUsername($username)
    {
        list($type, $username) = explode(':', $username, 2);

        $user = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        switch ($type) {
            case UserCredentials::TYPE_ID:
                $user = $this->userService->getUserById($username);
                break;
            case UserCredentials::TYPE_NAME:
                $user = $this->userService->getUserByLogin($username);
                break;
            default:
                throw new \InvalidArgumentException('Invalid user credentials type');
        }

        if ($user === null) {
            throw new UsernameNotFoundException(sprintf('User "%s" not found.', $username));
        }

        return $user;
    }

    /**
     * @inheritdoc
     *
     * @param UserInterface $user
     *
     * @throws UnsupportedUserException if the account is not supported
     *
     * @return UserInterface
     */
    public function refreshUser(UserInterface $user)
    {
        if (!$this->supportsClass(get_class($user))) {
            throw new UnsupportedUserException(sprintf('Instances of "%s" are not supported.', get_class($user)));
        }

        return $user;
    }

    /**
     * Whether this provider supports the given user class.
     *
     * @param string $class
     *
     * @return bool
     */
    public function supportsClass($class)
    {
        return $class === User::class;
    }
}


1			<?php
2			namespace AppBundle\Security;
3
4			use AppBundle\Entity\User;
5			use AppBundle\Service\UserService;
6			use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
7			use Symfony\Component\Security\Core\Exception\UsernameNotFoundException;
8			use Symfony\Component\Security\Core\User\UserInterface;
9			use Symfony\Component\Security\Core\User\UserProviderInterface;
10
11			class FormUserProvider implements UserProviderInterface
12			{
13			/** @var UserService */
14			private $userService;
15
16			public function __construct(UserService $userService)
17			{
18			$this->userService = $userService;
19			}
20
21			/**
22			* @inheritdoc
23			*
24			* @param string $username Compound username [type:username]
25			*
26			* @return null\|User
27			*/
28			public function loadUserByUsername($username)
29			{
30			list($type, $username) = explode(':', $username, 2);
31
32			$user = null;
			0 ignored issues – show Unused Code introduced 2017-02-21 13:54 UTC by Report Bug Copy Issue Report `$user` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
33			switch ($type) {
34			case UserCredentials::TYPE_ID:
35			$user = $this->userService->getUserById($username);
36			break;
37			case UserCredentials::TYPE_NAME:
38			$user = $this->userService->getUserByLogin($username);
39			break;
40			default:
41			throw new \InvalidArgumentException('Invalid user credentials type');
42			}
43
44			if ($user === null) {
45			throw new UsernameNotFoundException(sprintf('User "%s" not found.', $username));
46			}
47
48			return $user;
49			}
50
51			/**
52			* @inheritdoc
53			*
54			* @param UserInterface $user
55			*
56			* @throws UnsupportedUserException if the account is not supported
57			*
58			* @return UserInterface
59			*/
60			public function refreshUser(UserInterface $user)
61			{
62			if (!$this->supportsClass(get_class($user))) {
63			throw new UnsupportedUserException(sprintf('Instances of "%s" are not supported.', get_class($user)));
64			}
65
66			return $user;
67			}
68
69			/**
70			* Whether this provider supports the given user class.
71			*
72			* @param string $class
73			*
74			* @return bool
75			*/
76			public function supportsClass($class)
77			{
78			return $class === User::class;
79			}
80			}
81

Kyberia / kyberia

Push — develop ( 456f1c...054456 )

FormUserProvider::refreshUser() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like