Kurozora\Cooldown\CooldownServiceProvider

Complexity

Total Complexity

7

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	boot()	0	4	1
A	register()	0	3	1
A	cleanUpExpiredCooldowns()	0	15	5

<?php

namespace Kurozora\Cooldown;

use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\ServiceProvider;
use Kurozora\Cooldown\Models\Cooldown;
use \Exception;

class CooldownServiceProvider extends ServiceProvider
{
    /**
     * Bootstrap the application services.
     */
    public function boot()
    {
        $this->loadMigrationsFrom(__DIR__ . '/Migrations');
        $this->cleanUpExpiredCooldowns();
    }

    /**
     * Register the application services.
     */
    public function register()
    {
        require 'helpers.php';
    }

    /**
     * Deletes all expired cooldowns. Only runs once per day.
     */
    public function cleanUpExpiredCooldowns()
    {
        // Get the datetime at which the cooldowns were last cleaned up
        /** @var Carbon $lastDeletedAt */
        $lastDeletedAt = Cache::get('kurozora_cooldown_last_cleaned_up_at', null);
        $hoursAgo = $lastDeletedAt == null ? null : $lastDeletedAt->diffInHours(now());

        // Delete the cooldowns if the last run was 24 hours ago or more
        if($hoursAgo >= 24 || $hoursAgo == null) {

It seems like you are loosely comparing $hoursAgo of type integer|null against null; this is ambiguous if the integer can be zero. Consider using a strict comparison === instead.

            try {
                Cooldown::expired()->delete();
            }
            catch(Exception $e) { }

Consider adding a comment why this CATCH block is empty.

            Cache::forever('kurozora_cooldown_last_cleaned_up_at', now());
        }
    }
}