| Conditions | 1 |
| Paths | 1 |
| Total Lines | 94 |
| Code Lines | 75 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 27 | public function create(\ArrayObject $project) |
||
| 28 | { |
||
| 29 | { |
||
| 30 | $permissionDefinition = new PermissionDefinition(); |
||
| 31 | $permissionDefinition->setPath("/"); |
||
| 32 | $permissionDefinition->setOwnership("@config.superuser@[email protected]@"); |
||
| 33 | $permissionDefinition->addAcl("-R -m user::rwX"); |
||
| 34 | $permissionDefinition->addAcl("-R -m group::r-X"); |
||
| 35 | $permissionDefinition->addAcl("-R -m other::---"); |
||
| 36 | $permissionDefinition->addAcl("-R -m u:@config.wwwuser@:r-X"); |
||
| 37 | $permissionDefinition->addAcl("-R -m u:@project.user@:rwX"); |
||
| 38 | $permissionDefinition->addAcl("-R -m u:@config.postgresuser@:r-X"); |
||
| 39 | $permissionDefinition->addAcl("-R -m group:admin:rwX"); |
||
| 40 | $project["permissions"]["/"] = $permissionDefinition; |
||
| 41 | } |
||
| 42 | $this->fileSystemProvider->createDirectory($project, '.ssh'); |
||
| 43 | { |
||
| 44 | $permissionDefinition = new PermissionDefinition(); |
||
| 45 | $permissionDefinition->setPath("/.ssh"); |
||
| 46 | $permissionDefinition->setOwnership("-R @project.user@[email protected]@"); |
||
| 47 | $permissionDefinition->addAcl("-R -m user::rwX"); |
||
| 48 | $permissionDefinition->addAcl("-R -m group::---"); |
||
| 49 | $permissionDefinition->addAcl("-R -m other::---"); |
||
| 50 | $permissionDefinition->addAcl("-R -m m::---"); |
||
| 51 | $project["permissions"]["/.ssh"] = $permissionDefinition; |
||
| 52 | } |
||
| 53 | $this->fileSystemProvider->createDirectory($project, 'stats'); |
||
| 54 | { |
||
| 55 | $permissionDefinition = new PermissionDefinition(); |
||
| 56 | $permissionDefinition->setPath("/stats"); |
||
| 57 | $permissionDefinition->setOwnership("-R @project.user@[email protected]@"); |
||
| 58 | $permissionDefinition->addAcl("-R -m user::rwX"); |
||
| 59 | $permissionDefinition->addAcl("-R -m group::r-X"); |
||
| 60 | $permissionDefinition->addAcl("-R -m u:@config.wwwuser@:r-X"); |
||
| 61 | $permissionDefinition->addAcl("-R -m group:admin:r-X"); |
||
| 62 | $project["permissions"]["/stats"] = $permissionDefinition; |
||
| 63 | } |
||
| 64 | $this->fileSystemProvider->createDirectory($project, 'apachelogs'); |
||
| 65 | { |
||
| 66 | $permissionDefinition = new PermissionDefinition(); |
||
| 67 | $permissionDefinition->setPath("/apachelogs"); |
||
| 68 | $permissionDefinition->setOwnership("-R @project.user@[email protected]@"); |
||
| 69 | $permissionDefinition->addAcl("-R -m user::rwX"); |
||
| 70 | $permissionDefinition->addAcl("-R -m group::r-X"); |
||
| 71 | $permissionDefinition->addAcl("-R -m other::---"); |
||
| 72 | $permissionDefinition->addAcl("-R -m u:@config.wwwuser@:rwX"); |
||
| 73 | $project["permissions"]["/apachelogs"] = $permissionDefinition; |
||
| 74 | } |
||
| 75 | $this->fileSystemProvider->createDirectory($project, 'site'); |
||
| 76 | { |
||
| 77 | $permissionDefinition = new PermissionDefinition(); |
||
| 78 | $permissionDefinition->setPath("/site"); |
||
| 79 | $permissionDefinition->setOwnership("-R @project.user@[email protected]@"); |
||
| 80 | $permissionDefinition->addAcl("-R -m user::rwX"); |
||
| 81 | $permissionDefinition->addAcl("-R -m group::r-X"); |
||
| 82 | $permissionDefinition->addAcl("-R -m other::---"); |
||
| 83 | $permissionDefinition->addAcl("-R -m u:@config.wwwuser@:r-X"); |
||
| 84 | $project["permissions"]["/site"] = $permissionDefinition; |
||
| 85 | } |
||
| 86 | $this->fileSystemProvider->createDirectory($project, 'backup'); |
||
| 87 | { |
||
| 88 | $permissionDefinition = new PermissionDefinition(); |
||
| 89 | $permissionDefinition->setPath("/backup"); |
||
| 90 | $permissionDefinition->setOwnership("-R @project.user@[email protected]@"); |
||
| 91 | $permissionDefinition->addAcl("-R -m user::rwX"); |
||
| 92 | $permissionDefinition->addAcl("-R -m group::r-X"); |
||
| 93 | $permissionDefinition->addAcl("-R -m other::---"); |
||
| 94 | $permissionDefinition->addAcl("-R -m u:@config.postgresuser@:rwX"); |
||
| 95 | $project["permissions"]["/backup"] = $permissionDefinition; |
||
| 96 | } |
||
| 97 | $this->fileSystemProvider->createDirectory($project, 'data'); |
||
| 98 | { |
||
| 99 | $permissionDefinition = new PermissionDefinition(); |
||
| 100 | $permissionDefinition->setPath("/data"); |
||
| 101 | $permissionDefinition->setOwnership("-R @project.user@[email protected]@"); |
||
| 102 | $permissionDefinition->addAcl("-R -m user::rwX"); |
||
| 103 | $permissionDefinition->addAcl("-R -m group::r-X"); |
||
| 104 | $permissionDefinition->addAcl("-R -m other::---"); |
||
| 105 | $project["permissions"]["/data"] = $permissionDefinition; |
||
| 106 | } |
||
| 107 | $this->fileSystemProvider->createDirectory($project, 'conf'); |
||
| 108 | { |
||
| 109 | $permissionDefinition = new PermissionDefinition(); |
||
| 110 | $permissionDefinition->setPath("/conf"); |
||
| 111 | $permissionDefinition->setOwnership("-R @config.superuser@[email protected]@"); |
||
| 112 | $permissionDefinition->addAcl("-R -m user::rwX"); |
||
| 113 | $permissionDefinition->addAcl("-R -m group::r-X"); |
||
| 114 | $permissionDefinition->addAcl("-R -m other::---"); |
||
| 115 | $project["permissions"]["/conf"] = $permissionDefinition; |
||
| 116 | } |
||
| 117 | |||
| 118 | $project["backupexcludes"]["error.log"] = "error.log"; |
||
| 119 | $project["backupexcludes"]["access.log*"] = "access.log*"; |
||
| 120 | } |
||
| 121 | |||
| 222 |