RemoteProvider::closeFile() - Code Metrics - Kunstmaan/skylab - Measure and Improve Code Quality continuously with Scrutinizer

RemoteProvider::closeFile() A
last analyzed 2016-07-01 08:46 UTC

↳ Parent: RemoteProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	3
nc	2
nop	1

<?php

namespace Kunstmaan\Skylab\Provider;

use Cilex\Application;
use Kunstmaan\Skylab\Exceptions\AccessDeniedException;

class RemoteProvider extends AbstractProvider
{

    /**
     * Registers services on the given app.
     *
     * @param Application $app An Application instance
     */
    public function register(Application $app)
    {
        $app['remote'] = $this;
        $this->app = $app;
    }

    /**
     * @param $url
     * @param  string $contentType

     * @param  string $filename

     * @return string
     */
    public function curl($url, $contentType = null, $filename = null, $cacheTimeInSeconds = 0, $username = null, $password = null)

    {
        $ch = curl_init();
        curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
        curl_setopt($ch, CURLOPT_HEADER, false);
        curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
        curl_setopt($ch, CURLOPT_URL, $url);
        curl_setopt($ch, CURLOPT_REFERER, $url);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
        if($username && $password){
            curl_setopt($ch, CURLOPT_USERPWD, $username . ":" . $password);
        }
        if ($contentType) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            curl_setopt($ch, CURLOPT_HTTPHEADER, array("Accept: " . $contentType));
        }
        $tmpfile = $this->setDownloadHeaders($filename, $ch);
        curl_setopt($ch, CURLOPT_USERAGENT, "Skylab " . Application::VERSION . " (https://github.com/Kunstmaan/skylab)");
        $result = curl_exec($ch);
        $http_status = curl_getinfo($ch, CURLINFO_HTTP_CODE);
	if($http_status == 403) {
          throw new AccessDeniedException();
        }
        curl_close($ch);
        if ($filename) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->closeFile($tmpfile);
        } else {
            return $result;
        }

        return false;
    }

    /**
     * @param string|null $filename
     * @param resource $ch
     */
    private function setDownloadHeaders($filename, $ch)
    {
        if ($filename) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $tempFP = fopen($filename, 'w+');
            curl_setopt($ch, CURLOPT_FILE, $tempFP);
            curl_setopt($ch, CURLOPT_BINARYTRANSFER, 1);

            return $tempFP;
        }

        return false;
    }

    private function closeFile($tempFP)
    {
        if (!$tempFP) {
            fclose($tempFP);
        }
    }

}


1			<?php
2
3			namespace Kunstmaan\Skylab\Provider;
4
5			use Cilex\Application;
6			use Kunstmaan\Skylab\Exceptions\AccessDeniedException;
7
8			class RemoteProvider extends AbstractProvider
9			{
10
11			/**
12			* Registers services on the given app.
13			*
14			* @param Application $app An Application instance
15			*/
16			public function register(Application $app)
17			{
18			$app['remote'] = $this;
19			$this->app = $app;
20			}
21
22			/**
23			* @param $url
24			* @param string $contentType
			0 ignored issues – show Documentation introduced 2015-11-23 11:12 UTC by Report Bug Copy Issue Report Should the type for parameter `$contentType` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
25			* @param string $filename
			0 ignored issues – show Documentation introduced 2015-11-23 11:12 UTC by Report Bug Copy Issue Report Should the type for parameter `$filename` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
26			* @return string
27			*/
28			public function curl($url, $contentType = null, $filename = null, $cacheTimeInSeconds = 0, $username = null, $password = null)
			0 ignored issues – show Unused Code introduced 2015-11-23 11:12 UTC by Report Bug Copy Issue Report The parameter `$cacheTimeInSeconds` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
29			{
30			$ch = curl_init();
31			curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
32			curl_setopt($ch, CURLOPT_HEADER, false);
33			curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
34			curl_setopt($ch, CURLOPT_URL, $url);
35			curl_setopt($ch, CURLOPT_REFERER, $url);
36			curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
37			if($username && $password){
38			curl_setopt($ch, CURLOPT_USERPWD, $username . ":" . $password);
39			}
40			if ($contentType) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-23 11:12 UTC by Report Bug Copy Issue Report The expression `$contentType` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
41			curl_setopt($ch, CURLOPT_HTTPHEADER, array("Accept: " . $contentType));
42			}
43			$tmpfile = $this->setDownloadHeaders($filename, $ch);
44			curl_setopt($ch, CURLOPT_USERAGENT, "Skylab " . Application::VERSION . " (https://github.com/Kunstmaan/skylab)");
45			$result = curl_exec($ch);
46			$http_status = curl_getinfo($ch, CURLINFO_HTTP_CODE);
47			if($http_status == 403) {
48			throw new AccessDeniedException();
49			}
50			curl_close($ch);
51			if ($filename) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-23 11:12 UTC by Report Bug Copy Issue Report The expression `$filename` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
52			$this->closeFile($tmpfile);
53			} else {
54			return $result;
55			}
56
57			return false;
58			}
59
60			/**
61			* @param string\|null $filename
62			* @param resource $ch
63			*/
64			private function setDownloadHeaders($filename, $ch)
65			{
66			if ($filename) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-23 11:12 UTC by Report Bug Copy Issue Report The expression `$filename` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
67			$tempFP = fopen($filename, 'w+');
68			curl_setopt($ch, CURLOPT_FILE, $tempFP);
69			curl_setopt($ch, CURLOPT_BINARYTRANSFER, 1);
70
71			return $tempFP;
72			}
73
74			return false;
75			}
76
77			private function closeFile($tempFP)
78			{
79			if (!$tempFP) {
80			fclose($tempFP);
81			}
82			}
83
84			}
85

Kunstmaan / skylab

GitHub Access Token became invalid

RemoteProvider::closeFile() A last analyzed 2016-07-01 08:46 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RemoteProvider::closeFile() A
last analyzed 2016-07-01 08:46 UTC