Kunstmaan\Skylab\Skeleton\MonitoringSkeleton

Complexity

Total Complexity

31

Size/Duplication

Total Lines	196
Duplicated Lines	11.22 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	4
Bugs	0	Features	2

17 Methods

Rating	Name	Duplication	Size	Complexity
A	getName()	0	4	1
A	create()	0	3	1
A	preMaintenance()	0	3	1
A	postMaintenance()	0	3	1
A	maintenance()	13	13	4
A	getCheckName()	0	3	1
A	getTestId()	0	9	2
A	createTest()	0	5	1
A	updateTest()	0	5	1
A	deleteTest()	0	5	1
C	getTestArray()	0	34	8
A	performAPICall()	0	18	2
A	preBackup()	0	3	1
A	postBackup()	0	3	1
A	preRemove()	0	3	1
A	postRemove()	9	9	3
A	dependsOn()	0	4	1

<?php
namespace Kunstmaan\Skylab\Skeleton;
use UptimeRobot\API;

/**
 * MonitoringSkeleton
 */
class MonitoringSkeleton extends AbstractSkeleton
{

    const NAME = "monitoring";

    /**
     * @return string
     */
    public function getName()
    {
        return self::NAME;
    }

    /**
     * @param \ArrayObject $project
     *
     * @return mixed
     */
    public function create(\ArrayObject $project)
    {
    }

    /**
     * @return mixed
     */
    public function preMaintenance()
    {
    }

    /**
     * @return mixed
     */
    public function postMaintenance()
    {
    }

    /**
     * @param \ArrayObject $project
     *
     * @return mixed
     */
    public function maintenance(\ArrayObject $project)

This method seems to be duplicated in your project.

    {
        if (isset($this->app["config"]["monitoring"]["enabled"]) && $this->app["config"]["monitoring"]["enabled"]){
            $id = $this->getTestId($project);
            if ($id) {
                $this->updateTest($id, $project);
            } else {
                $this->createTest($project);
            }
        } else {
            $this->dialogProvider->logConfig("Monitoring is disabled");
        }
    }

    private function getCheckName(\ArrayObject $project){
        return $project["name"] . " @ " . str_replace(".kunstmaan.com", "", $this->app["config"]["webserver"]["hostmachine"]);
    }

    private function getTestId(\ArrayObject $project)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $tests = $this->performAPICall("/getMonitors", array("search" => $this->getCheckName($project)));
        if ($tests["stat"] == "fail"){
            return false;
        } else {
            return $tests["monitors"]["monitor"][0]["id"];
        }
    }

    private function createTest(\ArrayObject $project)
    {
        $data = $this->getTestArray($project);
        $this->performAPICall("/newMonitor", $data);
    }

    private function updateTest($id, \ArrayObject $project)
    {
        $data = $this->getTestArray($project, $id);
        $this->performAPICall("/editMonitor", $data);
    }

    private function deleteTest($id)
    {
        $data = $this->getTestArray(null, $id);
        $this->performAPICall("/deleteMonitor", $data);
    }

    /**
     * @param \ArrayObject $project

Should the type for parameter $project not be null|\ArrayObject?

     * @return array
     */
    private function getTestArray(\ArrayObject $project = null, $id = false)
    {
        $data = array();
        if (!is_null($project)) {

            $monitorPath = '';
            if (isset($project['monuri'])) { //for backwards compatibility only
                $monitorPath = $project['monuri'];
            }

            if (isset($project['monitoring_path'])) {
                $monitorPath = $project['monitoring_path'];
            }

            $monitorUrl = ($this->skeletonProvider->hasSkeleton($project, $this->skeletonProvider->findSkeleton("ssl"))?"https://":"http://") . $project["url"] . $monitorPath;
            if (filter_var($monitorUrl, FILTER_VALIDATE_URL, array('flags' => array(FILTER_FLAG_SCHEME_REQUIRED, FILTER_FLAG_HOST_REQUIRED))) === false) {
                //fallback to basic url
                $this->dialogProvider->logWarning("The ".$project["name"]." monitoring url is not valid: " . $monitorUrl);
                $monitorUrl = ($this->skeletonProvider->hasSkeleton($project, $this->skeletonProvider->findSkeleton("ssl"))?"https://":"http://") . $project["url"];
            }

            $data = array(
                "monitorFriendlyName" => $this->getCheckName($project),
                "monitorURL" => $monitorUrl,
                "monitorType" => 1,
                "monitorAlertContacts" => "2351398_5_60-0254691_5_60-2356728_5_60-2356781_5_60",
                "monitorInterval" => 1
            );
        }
        if ($id) {
            $data["monitorID"] = $id;
        }
        return $data;
    }

    private function performAPICall($url, $data = array())
    {

        //Set configuration settings
        $config = [
            'apiKey' => $this->app["config"]["monitoring"]["apikey"],
            'url' => 'http://api.uptimerobot.com'
        ];

        try {
            $api = new API($config);
            $results = $api->request($url, $data);
            $this->dialogProvider->logConfig("Sent a call to " . $url . " and got a response: " . print_r($results, true));
            return $results;
        } catch (\Exception $e) {
            $this->dialogProvider->logConfig("Sent a call to " . $url . " and got an error: " . $e->getMessage());
        }
    }

    /**
     * @param \ArrayObject $project
     *
     * @return mixed
     */
    public function preBackup(\ArrayObject $project)
    {
    }

    /**
     * @param \ArrayObject $project
     *
     * @return mixed
     */
    public function postBackup(\ArrayObject $project)
    {
    }

    /**
     * @param \ArrayObject $project
     *
     * @return mixed
     */
    public function preRemove(\ArrayObject $project)
    {
    }

    /**
     * @param \ArrayObject $project
     *
     * @return mixed
     */
    public function postRemove(\ArrayObject $project)

This method seems to be duplicated in your project.

    {
        if (isset($this->app["config"]["monitoring"]["enabled"]) && $this->app["config"]["monitoring"]["enabled"]){
            $id = $this->getTestId($project);
            $this->deleteTest($id);
        } else {
            $this->dialogProvider->logConfig("Monitoring is disabled");
        }
    }

    /**
     * @return string[]
     */
    public function dependsOn()
    {
        return array("base", "apache");
    }

}