Issues in ActionsMenuBuilderTest.php (master) - Issues in master - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3099)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Tests/unit/Helper/Menu/ActionsMenuBuilderTest.php (3 issues)

Labels

Severity

Informational 3

Daan Poron 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\NodeBundle\Tests\Helper\Menu;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Knp\Menu\Integration\Symfony\RoutingExtension;
use Knp\Menu\MenuFactory;
use Kunstmaan\NodeBundle\Entity\Node;
use Kunstmaan\NodeBundle\Entity\NodeTranslation;
use Kunstmaan\NodeBundle\Entity\NodeVersion;
use Kunstmaan\NodeBundle\Helper\Menu\ActionsMenuBuilder;
use Kunstmaan\NodeBundle\Helper\PagesConfiguration;
use PHPUnit\Framework\TestCase;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Routing\RouterInterface;

class ActionsMenuBuilderTest extends TestCase
{
    /**
     * @var ActionsMenuBuilder
     */
    protected $builder;

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp(): void
    {
        /* @var UrlGeneratorInterface $urlGenerator */
        $urlGenerator = $this->createMock('Symfony\Component\Routing\Generator\UrlGeneratorInterface');
        $routingExtension = new RoutingExtension($urlGenerator);
        $factory = new MenuFactory();
        $factory->addExtension($routingExtension);
        $em = $this->getMockedEntityManager();
        /* @var EventDispatcherInterface $dispatcher */
        $dispatcher = $this->createMock('Symfony\Component\EventDispatcher\EventDispatcherInterface');
        /* @var RouterInterface $router */
        $router = $this->createMock('Symfony\Component\Routing\RouterInterface');
        $authorizationChecker = $this->createMock('Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface');
        $authorizationChecker->expects($this->any())
            ->method('isGranted')
            ->willReturn(true);

        $this->builder = new ActionsMenuBuilder($factory, $em, $router, $dispatcher, $authorizationChecker, new PagesConfiguration([]));
    }

    /**
     * @throws \Exception
     *
     * @return \Doctrine\ORM\EntityManager

     */
    protected function getMockedEntityManager()
    {
        $repository = $this->createMock(EntityRepository::class);
        $repository->method('find')->willReturn(null);
        $repository->method('findBy')->willReturn(null);
        $repository->method('findOneBy')->willReturn(null);

        $emMock = $this->createMock(EntityManager::class);
        $emMock->method('getRepository')->willReturn($repository);
        $emMock->method('getClassMetaData')->willReturn((object) ['name' => 'aClass']);
        $emMock->method('persist')->willReturn(null);
        $emMock->method('flush')->willReturn(null);

        return $emMock;
    }

    public function testCreateSubActionsMenu()

    {
        $nodeTranslation = new NodeTranslation();
        $nodeTranslation->setNode(new Node());

        $nodeVersion = new NodeVersion();
        $nodeVersion->setNodeTranslation($nodeTranslation);

        $this->builder->setActiveNodeVersion($nodeVersion);

        $menu = $this->builder->createSubActionsMenu();
        $this->assertNotNull($menu->getChild('subaction.versions'));

        $this->assertEquals('page-sub-actions', $menu->getChildrenAttribute('class'));
    }

    public function testCreateActionsMenuDraft()
    {
        $nodeTranslation = new NodeTranslation();
        $nodeTranslation->setNode(new Node());

        $nodeVersion = new NodeVersion();
        $nodeVersion->setType('draft');
        $nodeVersion->setNodeTranslation($nodeTranslation);

        $this->builder->setActiveNodeVersion($nodeVersion);

        $menu = $this->builder->createActionsMenu();
        $this->assertNotNull($menu->getChild('action.saveasdraft'));
        $this->assertNull($menu->getChild('action.recopyfromlanguage'));
        $this->assertNotNull($menu->getChild('action.publish'));
        $this->assertNotNull($menu->getChild('action.preview'));
        $this->assertNull($menu->getChild('action.save'));

        if (null !== $nodeTranslation->getNode()->getParent() || $nodeTranslation->getNode()->getChildren()->isEmpty()) {
            $this->assertNotNull($menu->getChild('action.delete'));
        } else {
            $this->assertNull($menu->getChild('action.delete'));
        }

        $this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
    }

    public function testCreateActionsMenuPublic()
    {
        $nodeTranslation = new NodeTranslation();
        $nodeTranslation->setNode(new Node());

        $nodeVersion = new NodeVersion();
        $nodeVersion->setType('public');
        $nodeVersion->setNodeTranslation($nodeTranslation);

        $this->builder->setActiveNodeVersion($nodeVersion);

        $menu = $this->builder->createActionsMenu();
        $this->assertNotNull($menu->getChild('action.save'));
        $this->assertNotNull($menu->getChild('action.saveasdraft'));
        $this->assertNull($menu->getChild('action.recopyfromlanguage'));
        $this->assertNotNull($menu->getChild('action.preview'));
        $this->assertNotNull($menu->getChild('action.publish'));
        $this->assertNull($menu->getChild('action.unpublish'));
        if (null !== $nodeTranslation->getNode()->getParent() || $nodeTranslation->getNode()->getChildren()->isEmpty()) {
            $this->assertNotNull($menu->getChild('action.delete'));
        } else {
            $this->assertNull($menu->getChild('action.delete'));
        }

        $nodeTranslation->setOnline(true);
        $menu = $this->builder->createActionsMenu();
        $this->assertNotNull($menu->getChild('action.save'));
        $this->assertNotNull($menu->getChild('action.saveasdraft'));
        $this->assertNull($menu->getChild('action.recopyfromlanguage'));
        $this->assertNotNull($menu->getChild('action.preview'));
        $this->assertNull($menu->getChild('action.publish'));
        $this->assertNotNull($menu->getChild('action.unpublish'));
        if (null !== $nodeTranslation->getNode()->getParent() || $nodeTranslation->getNode()->getChildren()->isEmpty()) {
            $this->assertNotNull($menu->getChild('action.delete'));
        } else {
            $this->assertNull($menu->getChild('action.delete'));
        }

        $this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
    }

    public function testCreateActionsMenuNonEditable()
    {
        $nodeTranslation = new NodeTranslation();
        $nodeTranslation->setNode(new Node());

        $nodeVersion = new NodeVersion();
        $nodeVersion->setType('public');
        $nodeVersion->setNodeTranslation($nodeTranslation);
        $this->builder->setEditableNode(false);

        $this->builder->setActiveNodeVersion($nodeVersion);
        $nodeTranslation->setOnline(false);

        $menu = $this->builder->createActionsMenu();
        $this->assertNotNull($menu->getChild('action.save')); // We want to save.
        $this->assertNull($menu->getChild('action.saveasdraft'));
        $this->assertNull($menu->getChild('action.recopyfromlanguage'));
        $this->assertNull($menu->getChild('action.preview'));
        $this->assertNull($menu->getChild('action.publish'));
        $this->assertNull($menu->getChild('action.unpublish'));

        $this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
    }

    public function testCreateTopActionsMenu()

    {
        $nodeTranslation = new NodeTranslation();
        $nodeTranslation->setNode(new Node());

        $nodeVersion = new NodeVersion();
        $nodeVersion->setNodeTranslation($nodeTranslation);

        $this->builder->setActiveNodeVersion($nodeVersion);

        $menu = $this->builder->createTopActionsMenu();
        $this->assertEquals('page-main-actions page-main-actions--top', $menu->getChildrenAttribute('class'));
        $this->assertEquals('page-main-actions-top', $menu->getChildrenAttribute('id'));
    }

    public function testSetGetActiveNodeVersion()
    {
        $nodeVersion = new NodeVersion();
        $this->builder->setActiveNodeVersion($nodeVersion);
        $this->assertEquals($this->builder->getActiveNodeVersion(), $nodeVersion);
    }

    public function testShouldShowDeleteButtonWhenTheNodeHasAParent()
    {
        $nodeTranslation = new NodeTranslation();
        $node = new Node();
        $node->setParent(new Node());
        $nodeTranslation->setNode($node);

        $nodeVersion = new NodeVersion();
        $nodeVersion->setType('public');
        $nodeVersion->setNodeTranslation($nodeTranslation);

        $this->builder->setActiveNodeVersion($nodeVersion);

        $menu = $this->builder->createActionsMenu();
        $this->assertNotNull($menu->getChild('action.delete'));

        $this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
    }

    public function testShouldShowRecopyButtonWhenTheNodeHasTranslations()
    {
        $node = new Node();
        $nodeTranslation = new NodeTranslation();
        $nodeTranslation->setLang('en');

        $node->addNodeTranslation($nodeTranslation);

        $nodeVersion = new NodeVersion();
        $nodeVersion->setType('public');
        $nodeVersion->setNodeTranslation($nodeTranslation);

        $this->builder->setActiveNodeVersion($nodeVersion);

        $nodeTranslation = new NodeTranslation();
        $nodeTranslation->setLang('nl');

        $node->addNodeTranslation($nodeTranslation);

        $nodeVersion = new NodeVersion();
        $nodeVersion->setType('public');
        $nodeVersion->setNodeTranslation($nodeTranslation);

        $this->builder->setActiveNodeVersion($nodeVersion);

        $menu = $this->builder->createActionsMenu();
        $this->assertNotNull($menu->getChild('action.recopyfromlanguage'));

        $this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
    }
}


1		<?php
2
3		namespace Kunstmaan\NodeBundle\Tests\Helper\Menu;
4
5		use Doctrine\ORM\EntityManager;
6		use Doctrine\ORM\EntityRepository;
7		use Knp\Menu\Integration\Symfony\RoutingExtension;
8		use Knp\Menu\MenuFactory;
9		use Kunstmaan\NodeBundle\Entity\Node;
10		use Kunstmaan\NodeBundle\Entity\NodeTranslation;
11		use Kunstmaan\NodeBundle\Entity\NodeVersion;
12		use Kunstmaan\NodeBundle\Helper\Menu\ActionsMenuBuilder;
13		use Kunstmaan\NodeBundle\Helper\PagesConfiguration;
14		use PHPUnit\Framework\TestCase;
15		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
16		use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
17		use Symfony\Component\Routing\RouterInterface;
18
19		class ActionsMenuBuilderTest extends TestCase
20		{
21		/**
22		* @var ActionsMenuBuilder
23		*/
24		protected $builder;
25
26		/**
27		* Sets up the fixture, for example, opens a network connection.
28		* This method is called before a test is executed.
29		*/
30		protected function setUp(): void
31		{
32		/* @var UrlGeneratorInterface $urlGenerator */
33		$urlGenerator = $this->createMock('Symfony\Component\Routing\Generator\UrlGeneratorInterface');
34		$routingExtension = new RoutingExtension($urlGenerator);
35		$factory = new MenuFactory();
36		$factory->addExtension($routingExtension);
37		$em = $this->getMockedEntityManager();
38		/* @var EventDispatcherInterface $dispatcher */
39		$dispatcher = $this->createMock('Symfony\Component\EventDispatcher\EventDispatcherInterface');
40		/* @var RouterInterface $router */
41		$router = $this->createMock('Symfony\Component\Routing\RouterInterface');
42		$authorizationChecker = $this->createMock('Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface');
43		$authorizationChecker->expects($this->any())
44		->method('isGranted')
45		->willReturn(true);
46
47		$this->builder = new ActionsMenuBuilder($factory, $em, $router, $dispatcher, $authorizationChecker, new PagesConfiguration([]));
48		}
49
50		/**
51		* @throws \Exception
52		*
53		* @return \Doctrine\ORM\EntityManager
		0 ignored issues – show Documentation introduced 2019-03-03 18:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\PHPUnit\Framework\MockObject\MockObject`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
54		*/
55		protected function getMockedEntityManager()
56		{
57		$repository = $this->createMock(EntityRepository::class);
58		$repository->method('find')->willReturn(null);
59		$repository->method('findBy')->willReturn(null);
60		$repository->method('findOneBy')->willReturn(null);
61
62		$emMock = $this->createMock(EntityManager::class);
63		$emMock->method('getRepository')->willReturn($repository);
64		$emMock->method('getClassMetaData')->willReturn((object) ['name' => 'aClass']);
65		$emMock->method('persist')->willReturn(null);
66		$emMock->method('flush')->willReturn(null);
67
68		return $emMock;
69		}
70
71	View Code Duplication	public function testCreateSubActionsMenu()
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		{
73		$nodeTranslation = new NodeTranslation();
74		$nodeTranslation->setNode(new Node());
75
76		$nodeVersion = new NodeVersion();
77		$nodeVersion->setNodeTranslation($nodeTranslation);
78
79		$this->builder->setActiveNodeVersion($nodeVersion);
80
81		$menu = $this->builder->createSubActionsMenu();
82		$this->assertNotNull($menu->getChild('subaction.versions'));
83
84		$this->assertEquals('page-sub-actions', $menu->getChildrenAttribute('class'));
85		}
86
87		public function testCreateActionsMenuDraft()
88		{
89		$nodeTranslation = new NodeTranslation();
90		$nodeTranslation->setNode(new Node());
91
92		$nodeVersion = new NodeVersion();
93		$nodeVersion->setType('draft');
94		$nodeVersion->setNodeTranslation($nodeTranslation);
95
96		$this->builder->setActiveNodeVersion($nodeVersion);
97
98		$menu = $this->builder->createActionsMenu();
99		$this->assertNotNull($menu->getChild('action.saveasdraft'));
100		$this->assertNull($menu->getChild('action.recopyfromlanguage'));
101		$this->assertNotNull($menu->getChild('action.publish'));
102		$this->assertNotNull($menu->getChild('action.preview'));
103		$this->assertNull($menu->getChild('action.save'));
104
105	View Code Duplication	if (null !== $nodeTranslation->getNode()->getParent() \|\| $nodeTranslation->getNode()->getChildren()->isEmpty()) {
106		$this->assertNotNull($menu->getChild('action.delete'));
107		} else {
108		$this->assertNull($menu->getChild('action.delete'));
109		}
110
111		$this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
112		}
113
114		public function testCreateActionsMenuPublic()
115		{
116		$nodeTranslation = new NodeTranslation();
117		$nodeTranslation->setNode(new Node());
118
119		$nodeVersion = new NodeVersion();
120		$nodeVersion->setType('public');
121		$nodeVersion->setNodeTranslation($nodeTranslation);
122
123		$this->builder->setActiveNodeVersion($nodeVersion);
124
125		$menu = $this->builder->createActionsMenu();
126		$this->assertNotNull($menu->getChild('action.save'));
127		$this->assertNotNull($menu->getChild('action.saveasdraft'));
128		$this->assertNull($menu->getChild('action.recopyfromlanguage'));
129		$this->assertNotNull($menu->getChild('action.preview'));
130		$this->assertNotNull($menu->getChild('action.publish'));
131		$this->assertNull($menu->getChild('action.unpublish'));
132	View Code Duplication	if (null !== $nodeTranslation->getNode()->getParent() \|\| $nodeTranslation->getNode()->getChildren()->isEmpty()) {
133		$this->assertNotNull($menu->getChild('action.delete'));
134		} else {
135		$this->assertNull($menu->getChild('action.delete'));
136		}
137
138		$nodeTranslation->setOnline(true);
139		$menu = $this->builder->createActionsMenu();
140		$this->assertNotNull($menu->getChild('action.save'));
141		$this->assertNotNull($menu->getChild('action.saveasdraft'));
142		$this->assertNull($menu->getChild('action.recopyfromlanguage'));
143		$this->assertNotNull($menu->getChild('action.preview'));
144		$this->assertNull($menu->getChild('action.publish'));
145		$this->assertNotNull($menu->getChild('action.unpublish'));
146	View Code Duplication	if (null !== $nodeTranslation->getNode()->getParent() \|\| $nodeTranslation->getNode()->getChildren()->isEmpty()) {
147		$this->assertNotNull($menu->getChild('action.delete'));
148		} else {
149		$this->assertNull($menu->getChild('action.delete'));
150		}
151
152		$this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
153		}
154
155		public function testCreateActionsMenuNonEditable()
156		{
157		$nodeTranslation = new NodeTranslation();
158		$nodeTranslation->setNode(new Node());
159
160		$nodeVersion = new NodeVersion();
161		$nodeVersion->setType('public');
162		$nodeVersion->setNodeTranslation($nodeTranslation);
163		$this->builder->setEditableNode(false);
164
165		$this->builder->setActiveNodeVersion($nodeVersion);
166		$nodeTranslation->setOnline(false);
167
168		$menu = $this->builder->createActionsMenu();
169		$this->assertNotNull($menu->getChild('action.save')); // We want to save.
170		$this->assertNull($menu->getChild('action.saveasdraft'));
171		$this->assertNull($menu->getChild('action.recopyfromlanguage'));
172		$this->assertNull($menu->getChild('action.preview'));
173		$this->assertNull($menu->getChild('action.publish'));
174		$this->assertNull($menu->getChild('action.unpublish'));
175
176		$this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
177		}
178
179	View Code Duplication	public function testCreateTopActionsMenu()
		0 ignored issues – show Duplication introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
180		{
181		$nodeTranslation = new NodeTranslation();
182		$nodeTranslation->setNode(new Node());
183
184		$nodeVersion = new NodeVersion();
185		$nodeVersion->setNodeTranslation($nodeTranslation);
186
187		$this->builder->setActiveNodeVersion($nodeVersion);
188
189		$menu = $this->builder->createTopActionsMenu();
190		$this->assertEquals('page-main-actions page-main-actions--top', $menu->getChildrenAttribute('class'));
191		$this->assertEquals('page-main-actions-top', $menu->getChildrenAttribute('id'));
192		}
193
194		public function testSetGetActiveNodeVersion()
195		{
196		$nodeVersion = new NodeVersion();
197		$this->builder->setActiveNodeVersion($nodeVersion);
198		$this->assertEquals($this->builder->getActiveNodeVersion(), $nodeVersion);
199		}
200
201		public function testShouldShowDeleteButtonWhenTheNodeHasAParent()
202		{
203		$nodeTranslation = new NodeTranslation();
204		$node = new Node();
205		$node->setParent(new Node());
206		$nodeTranslation->setNode($node);
207
208		$nodeVersion = new NodeVersion();
209		$nodeVersion->setType('public');
210		$nodeVersion->setNodeTranslation($nodeTranslation);
211
212		$this->builder->setActiveNodeVersion($nodeVersion);
213
214		$menu = $this->builder->createActionsMenu();
215		$this->assertNotNull($menu->getChild('action.delete'));
216
217		$this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
218		}
219
220		public function testShouldShowRecopyButtonWhenTheNodeHasTranslations()
221		{
222		$node = new Node();
223		$nodeTranslation = new NodeTranslation();
224		$nodeTranslation->setLang('en');
225
226		$node->addNodeTranslation($nodeTranslation);
227
228		$nodeVersion = new NodeVersion();
229		$nodeVersion->setType('public');
230		$nodeVersion->setNodeTranslation($nodeTranslation);
231
232		$this->builder->setActiveNodeVersion($nodeVersion);
233
234		$nodeTranslation = new NodeTranslation();
235		$nodeTranslation->setLang('nl');
236
237		$node->addNodeTranslation($nodeTranslation);
238
239		$nodeVersion = new NodeVersion();
240		$nodeVersion->setType('public');
241		$nodeVersion->setNodeTranslation($nodeTranslation);
242
243		$this->builder->setActiveNodeVersion($nodeVersion);
244
245		$menu = $this->builder->createActionsMenu();
246		$this->assertNotNull($menu->getChild('action.recopyfromlanguage'));
247
248		$this->assertEquals('page-main-actions js-auto-collapse-buttons', $menu->getChildrenAttribute('class'));
249		}
250		}
251

Kunstmaan / KunstmaanBundlesCMS

Issues (3099)

Security Analysis not enabled

Tests/unit/Helper/Menu/ActionsMenuBuilderTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like