Issues in NodeVersionRepository.php (master) - Issues in master - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3099)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

NodeBundle/Repository/NodeVersionRepository.php (1 issue)

Labels

Bug 1

Severity

Major 1

Daan Poron 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\NodeBundle\Repository;

use DateTime;
use Doctrine\ORM\EntityRepository;
use Kunstmaan\AdminBundle\Entity\BaseUser;
use Kunstmaan\NodeBundle\Entity\HasNodeInterface;
use Kunstmaan\NodeBundle\Entity\NodeTranslation;
use Kunstmaan\NodeBundle\Entity\NodeVersion;
use Kunstmaan\UtilitiesBundle\Helper\ClassLookup;

/**
 * NodeRepository
 */
class NodeVersionRepository extends EntityRepository
{
    /**
     * @param HasNodeInterface $hasNode
     *
     * @return NodeVersion
     */
    public function getNodeVersionFor(HasNodeInterface $hasNode)
    {
        return $this->findOneBy(
            array(
                'refId' => $hasNode->getId(),
                'refEntityName' => ClassLookup::getClass($hasNode),
            )
        );
    }

    /**
     * @param HasNodeInterface $hasNode         The object
     * @param NodeTranslation  $nodeTranslation The node translation
     * @param BaseUser         $owner           The user
     * @param NodeVersion      $origin          The nodeVersion this nodeVersion originated from
     * @param string           $type            (public|draft)
     * @param DateTime         $created         The date this node version is created
     *
     * @return NodeVersion
     */
    public function createNodeVersionFor(
        HasNodeInterface $hasNode,
        NodeTranslation $nodeTranslation,
        BaseUser $owner,
        NodeVersion $origin = null,
        $type = 'public',
        $created = null
    ) {
        $em = $this->getEntityManager();

        $nodeVersion = new NodeVersion();
        $nodeVersion->setNodeTranslation($nodeTranslation);
        $nodeVersion->setType($type);
        $nodeVersion->setOwner($owner);
        $nodeVersion->setRef($hasNode);
        $nodeVersion->setOrigin($origin);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}

        if (!\is_null($created)) {
            $nodeVersion->setCreated($created);
        }

        $em->persist($nodeVersion);
        $em->flush();
        $em->refresh($nodeVersion);

        return $nodeVersion;
    }
}


1			<?php
2
3			namespace Kunstmaan\NodeBundle\Repository;
4
5			use DateTime;
6			use Doctrine\ORM\EntityRepository;
7			use Kunstmaan\AdminBundle\Entity\BaseUser;
8			use Kunstmaan\NodeBundle\Entity\HasNodeInterface;
9			use Kunstmaan\NodeBundle\Entity\NodeTranslation;
10			use Kunstmaan\NodeBundle\Entity\NodeVersion;
11			use Kunstmaan\UtilitiesBundle\Helper\ClassLookup;
12
13			/**
14			* NodeRepository
15			*/
16			class NodeVersionRepository extends EntityRepository
17			{
18			/**
19			* @param HasNodeInterface $hasNode
20			*
21			* @return NodeVersion
22			*/
23			public function getNodeVersionFor(HasNodeInterface $hasNode)
24			{
25			return $this->findOneBy(
26			array(
27			'refId' => $hasNode->getId(),
28			'refEntityName' => ClassLookup::getClass($hasNode),
29			)
30			);
31			}
32
33			/**
34			* @param HasNodeInterface $hasNode The object
35			* @param NodeTranslation $nodeTranslation The node translation
36			* @param BaseUser $owner The user
37			* @param NodeVersion $origin The nodeVersion this nodeVersion originated from
38			* @param string $type (public\|draft)
39			* @param DateTime $created The date this node version is created
40			*
41			* @return NodeVersion
42			*/
43			public function createNodeVersionFor(
44			HasNodeInterface $hasNode,
45			NodeTranslation $nodeTranslation,
46			BaseUser $owner,
47			NodeVersion $origin = null,
48			$type = 'public',
49			$created = null
50			) {
51			$em = $this->getEntityManager();
52
53			$nodeVersion = new NodeVersion();
54			$nodeVersion->setNodeTranslation($nodeTranslation);
55			$nodeVersion->setType($type);
56			$nodeVersion->setOwner($owner);
57			$nodeVersion->setRef($hasNode);
58			$nodeVersion->setOrigin($origin);
			0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$origin` defined by parameter `$origin` on line `47` can be `null`; however, `Kunstmaan\NodeBundle\Ent...odeVersion::setOrigin()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
59
60			if (!\is_null($created)) {
61			$nodeVersion->setCreated($created);
62			}
63
64			$em->persist($nodeVersion);
65			$em->flush();
66			$em->refresh($nodeVersion);
67
68			return $nodeVersion;
69			}
70			}
71

Kunstmaan / KunstmaanBundlesCMS

Issues (3099)

Security Analysis not enabled

NodeBundle/Repository/NodeVersionRepository.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like