Issues in PageCloningHelper.php (master) - Issues in master - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3099)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Kunstmaan/NodeBundle/Helper/PageCloningHelper.php (3 issues)

Labels

Severity

Minor 3

Kevin Jossart 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\NodeBundle\Helper;

use Doctrine\ORM\EntityManagerInterface;
use Kunstmaan\AdminBundle\Entity\BaseUser;
use Kunstmaan\AdminBundle\Helper\CloneHelper;
use Kunstmaan\AdminBundle\Helper\Security\Acl\Permission\PermissionMap;
use Kunstmaan\NodeBundle\Entity\DuplicateSubPageInterface;
use Kunstmaan\NodeBundle\Entity\HasNodeInterface;
use Kunstmaan\NodeBundle\Entity\Node;
use Kunstmaan\NodeBundle\Entity\PageInterface;
use Kunstmaan\NodeBundle\Event\Events;
use Kunstmaan\NodeBundle\Event\PreNodeDuplicateEvent;
use Kunstmaan\NodeBundle\Event\PostNodeDuplicateEvent;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\EventDispatcher\LegacyEventDispatcherProxy;
use Symfony\Component\Security\Acl\Domain\RoleSecurityIdentity;
use Symfony\Component\Security\Acl\Model\AclProviderInterface;
use Symfony\Component\Security\Acl\Model\EntryInterface;
use Symfony\Component\Security\Acl\Model\ObjectIdentityRetrievalStrategyInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

class PageCloningHelper
{
    /** @var EntityManagerInterface */
    private $em;

    /** @var CloneHelper */
    private $cloneHelper;

    /** @var AclProviderInterface */
    private $aclProvider;

    /** @var ObjectIdentityRetrievalStrategyInterface */
    private $identityRetrievalStrategy;

    /** @var AuthorizationCheckerInterface */
    private $authorizationCheckerInterface;

    /** @var EventDispatcherInterface */
    private $eventDispatcherInterface;

    public function __construct(EntityManagerInterface $em, CloneHelper $cloneHelper, AclProviderInterface $aclProvider, ObjectIdentityRetrievalStrategyInterface $identityRetrivalStrategy, AuthorizationCheckerInterface $authorizationChecker, EventDispatcherInterface $eventDispatcher)
    {
        $this->em = $em;
        $this->cloneHelper = $cloneHelper;
        $this->aclProvider = $aclProvider;
        $this->identityRetrievalStrategy = $identityRetrivalStrategy;
        $this->authorizationCheckerInterface = $authorizationChecker;
        $this->eventDispatcherInterface = $eventDispatcher;
    }

    /**
     * @throws AccessDeniedException
     */
    public function duplicateWithChildren($id, string $locale, BaseUser $user, string $title = null): Node
    {
        /* @var Node $parentNode */
        $originalNode = $this->em->getRepository('KunstmaanNodeBundle:Node')->find($id);

        $this->denyAccessUnlessGranted(PermissionMap::PERMISSION_EDIT, $originalNode);

        $this->dispatch(new PreNodeDuplicateEvent($originalNode), Events::PRE_DUPLICATE_WITH_CHILDREN);

        $newPage = $this->clonePage($originalNode, $locale, $title);
        $nodeNewPage = $this->createNodeStructureForNewPage($originalNode, $newPage, $user, $locale);

        $this->dispatch(new PostNodeDuplicateEvent($originalNode, $nodeNewPage, $newPage), Events::POST_DUPLICATE_WITH_CHILDREN);

        $this->cloneChildren($originalNode, $newPage, $user, $locale);

        return $nodeNewPage;
    }

    private function denyAccessUnlessGranted($attributes, $subject = null, $message = 'Access Denied.')
    {
        if (!$this->authorizationCheckerInterface->isGranted($attributes, $subject)) {
            $exception = new AccessDeniedException();
            $exception->setAttributes($attributes);
            $exception->setSubject($subject);

            throw $exception;
        }
    }

    public function clonePage(Node $originalNode, $locale, $title = null)
    {
        $originalNodeTranslations = $originalNode->getNodeTranslation($locale, true);
        $originalRef = $originalNodeTranslations->getPublicNodeVersion()->getRef($this->em);

        $newPage = $this->cloneHelper->deepCloneAndSave($originalRef);

        if ($title !== null) {
            $newPage->setTitle($title);
        }

        //set the parent
        $parentNodeTranslation = $originalNode->getParent()->getNodeTranslation($locale, true);
        $parent = $parentNodeTranslation->getPublicNodeVersion()->getRef($this->em);
        $newPage->setParent($parent);

        $this->em->persist($newPage);
        $this->em->flush();

        return $newPage;
    }

    private function createNodeStructureForNewPage(Node $originalNode, HasNodeInterface $newPage, BaseUser $user, string $locale): Node
    {
        /* @var Node $nodeNewPage */
        $nodeNewPage = $this->em->getRepository('KunstmaanNodeBundle:Node')->createNodeFor($newPage, $locale, $user);

        if ($newPage->isStructureNode()) {
            $nodeTranslation = $nodeNewPage->getNodeTranslation($locale, true);
            $nodeTranslation->setSlug('');
            $this->em->persist($nodeTranslation);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        }
        $this->em->flush();

        $this->updateAcl($originalNode, $nodeNewPage);

        return $nodeNewPage;
    }

    private function updateAcl($originalNode, $nodeNewPage): void
    {
        $originalIdentity = $this->identityRetrievalStrategy->getObjectIdentity($originalNode);
        $originalAcl = $this->aclProvider->findAcl($originalIdentity);

        $newIdentity = $this->identityRetrievalStrategy->getObjectIdentity($nodeNewPage);
        $newAcl = $this->aclProvider->createAcl($newIdentity);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $aces = $originalAcl->getObjectAces();
        /* @var EntryInterface $ace */
        foreach ($aces as $ace) {
            $securityIdentity = $ace->getSecurityIdentity();
            if ($securityIdentity instanceof RoleSecurityIdentity) {
                $newAcl->insertObjectAce($securityIdentity, $ace->getMask());
            }
        }
        $this->aclProvider->updateAcl($newAcl);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    private function cloneChildren(Node $originalNode, PageInterface $newPage, BaseUser $user, string $locale): void
    {
        $nodeChildren = $originalNode->getChildren();
        foreach ($nodeChildren as $originalNodeChild) {
            $originalNodeTranslations = $originalNodeChild->getNodeTranslation($locale, true);
            $originalRef = $originalNodeTranslations->getPublicNodeVersion()->getRef($this->em);

            if (!$originalRef instanceof DuplicateSubPageInterface || !$originalRef->skipClone()) {
                $this->dispatch(new PreNodeDuplicateEvent($originalNodeChild), Events::PRE_DUPLICATE_WITH_CHILDREN);
                $newChildPage = $this->clonePage($originalNodeChild, $locale);
                $newChildPage->setParent($newPage);

                $newChildNode = $this->createNodeStructureForNewPage($originalNodeChild, $newChildPage, $user, $locale);
                $this->dispatch(new PostNodeDuplicateEvent($originalNodeChild, $newChildNode, $newChildPage), Events::POST_DUPLICATE_WITH_CHILDREN);
                $this->cloneChildren($originalNodeChild, $newChildPage, $user, $locale);
            }
        }
    }

    /**
     * @param object $event
     * @param string $eventName
     *
     * @return object
     */
    private function dispatch($event, string $eventName)
    {
        if (class_exists(LegacyEventDispatcherProxy::class)) {
            $eventDispatcher = LegacyEventDispatcherProxy::decorate($this->eventDispatcherInterface);

            return $eventDispatcher->dispatch($event, $eventName);
        }

        return $this->eventDispatcherInterface->dispatch($eventName, $event);
    }
}


1		<?php
2
3		namespace Kunstmaan\NodeBundle\Helper;
4
5		use Doctrine\ORM\EntityManagerInterface;
6		use Kunstmaan\AdminBundle\Entity\BaseUser;
7		use Kunstmaan\AdminBundle\Helper\CloneHelper;
8		use Kunstmaan\AdminBundle\Helper\Security\Acl\Permission\PermissionMap;
9		use Kunstmaan\NodeBundle\Entity\DuplicateSubPageInterface;
10		use Kunstmaan\NodeBundle\Entity\HasNodeInterface;
11		use Kunstmaan\NodeBundle\Entity\Node;
12		use Kunstmaan\NodeBundle\Entity\PageInterface;
13		use Kunstmaan\NodeBundle\Event\Events;
14		use Kunstmaan\NodeBundle\Event\PreNodeDuplicateEvent;
15		use Kunstmaan\NodeBundle\Event\PostNodeDuplicateEvent;
16		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
17		use Symfony\Component\EventDispatcher\LegacyEventDispatcherProxy;
18		use Symfony\Component\Security\Acl\Domain\RoleSecurityIdentity;
19		use Symfony\Component\Security\Acl\Model\AclProviderInterface;
20		use Symfony\Component\Security\Acl\Model\EntryInterface;
21		use Symfony\Component\Security\Acl\Model\ObjectIdentityRetrievalStrategyInterface;
22		use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
23		use Symfony\Component\Security\Core\Exception\AccessDeniedException;
24
25		class PageCloningHelper
26		{
27		/** @var EntityManagerInterface */
28		private $em;
29
30		/** @var CloneHelper */
31		private $cloneHelper;
32
33		/** @var AclProviderInterface */
34		private $aclProvider;
35
36		/** @var ObjectIdentityRetrievalStrategyInterface */
37		private $identityRetrievalStrategy;
38
39		/** @var AuthorizationCheckerInterface */
40		private $authorizationCheckerInterface;
41
42		/** @var EventDispatcherInterface */
43		private $eventDispatcherInterface;
44
45		public function __construct(EntityManagerInterface $em, CloneHelper $cloneHelper, AclProviderInterface $aclProvider, ObjectIdentityRetrievalStrategyInterface $identityRetrivalStrategy, AuthorizationCheckerInterface $authorizationChecker, EventDispatcherInterface $eventDispatcher)
46		{
47		$this->em = $em;
48		$this->cloneHelper = $cloneHelper;
49		$this->aclProvider = $aclProvider;
50		$this->identityRetrievalStrategy = $identityRetrivalStrategy;
51		$this->authorizationCheckerInterface = $authorizationChecker;
52		$this->eventDispatcherInterface = $eventDispatcher;
53		}
54
55		/**
56		* @throws AccessDeniedException
57		*/
58		public function duplicateWithChildren($id, string $locale, BaseUser $user, string $title = null): Node
59		{
60		/* @var Node $parentNode */
61		$originalNode = $this->em->getRepository('KunstmaanNodeBundle:Node')->find($id);
62
63		$this->denyAccessUnlessGranted(PermissionMap::PERMISSION_EDIT, $originalNode);
64
65		$this->dispatch(new PreNodeDuplicateEvent($originalNode), Events::PRE_DUPLICATE_WITH_CHILDREN);
66
67		$newPage = $this->clonePage($originalNode, $locale, $title);
68		$nodeNewPage = $this->createNodeStructureForNewPage($originalNode, $newPage, $user, $locale);
69
70		$this->dispatch(new PostNodeDuplicateEvent($originalNode, $nodeNewPage, $newPage), Events::POST_DUPLICATE_WITH_CHILDREN);
71
72		$this->cloneChildren($originalNode, $newPage, $user, $locale);
73
74		return $nodeNewPage;
75		}
76
77		private function denyAccessUnlessGranted($attributes, $subject = null, $message = 'Access Denied.')
78		{
79		if (!$this->authorizationCheckerInterface->isGranted($attributes, $subject)) {
80		$exception = new AccessDeniedException();
81		$exception->setAttributes($attributes);
82		$exception->setSubject($subject);
83
84		throw $exception;
85		}
86		}
87
88		public function clonePage(Node $originalNode, $locale, $title = null)
89		{
90		$originalNodeTranslations = $originalNode->getNodeTranslation($locale, true);
91		$originalRef = $originalNodeTranslations->getPublicNodeVersion()->getRef($this->em);
92
93		$newPage = $this->cloneHelper->deepCloneAndSave($originalRef);
94
95		if ($title !== null) {
96		$newPage->setTitle($title);
97		}
98
99		//set the parent
100		$parentNodeTranslation = $originalNode->getParent()->getNodeTranslation($locale, true);
101		$parent = $parentNodeTranslation->getPublicNodeVersion()->getRef($this->em);
102		$newPage->setParent($parent);
103
104		$this->em->persist($newPage);
105		$this->em->flush();
106
107		return $newPage;
108		}
109
110		private function createNodeStructureForNewPage(Node $originalNode, HasNodeInterface $newPage, BaseUser $user, string $locale): Node
111		{
112		/* @var Node $nodeNewPage */
113		$nodeNewPage = $this->em->getRepository('KunstmaanNodeBundle:Node')->createNodeFor($newPage, $locale, $user);
114
115		if ($newPage->isStructureNode()) {
116		$nodeTranslation = $nodeNewPage->getNodeTranslation($locale, true);
117		$nodeTranslation->setSlug('');
118		$this->em->persist($nodeTranslation);
		0 ignored issues – show Bug introduced 2020-06-09 18:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$nodeTranslation` defined by `$nodeNewPage->getNodeTranslation($locale, true)` on line `116` can be `null`; however, `Doctrine\Persistence\ObjectManager::persist()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
119		}
120		$this->em->flush();
121
122		$this->updateAcl($originalNode, $nodeNewPage);
123
124		return $nodeNewPage;
125		}
126
127	View Code Duplication	private function updateAcl($originalNode, $nodeNewPage): void
128		{
129		$originalIdentity = $this->identityRetrievalStrategy->getObjectIdentity($originalNode);
130		$originalAcl = $this->aclProvider->findAcl($originalIdentity);
131
132		$newIdentity = $this->identityRetrievalStrategy->getObjectIdentity($nodeNewPage);
133		$newAcl = $this->aclProvider->createAcl($newIdentity);
		0 ignored issues – show Bug introduced 2020-06-09 18:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Symfony\Component\Securi...el\AclProviderInterface` as the method `createAcl()` does only exist in the following implementations of said interface: `Symfony\Component\Securi...Dbal\MutableAclProvider`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
134
135		$aces = $originalAcl->getObjectAces();
136		/* @var EntryInterface $ace */
137		foreach ($aces as $ace) {
138		$securityIdentity = $ace->getSecurityIdentity();
139		if ($securityIdentity instanceof RoleSecurityIdentity) {
140		$newAcl->insertObjectAce($securityIdentity, $ace->getMask());
141		}
142		}
143		$this->aclProvider->updateAcl($newAcl);
		0 ignored issues – show Bug introduced 2020-06-09 18:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Symfony\Component\Securi...el\AclProviderInterface` as the method `updateAcl()` does only exist in the following implementations of said interface: `Symfony\Component\Securi...Dbal\MutableAclProvider`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
144		}
145
146		private function cloneChildren(Node $originalNode, PageInterface $newPage, BaseUser $user, string $locale): void
147		{
148		$nodeChildren = $originalNode->getChildren();
149		foreach ($nodeChildren as $originalNodeChild) {
150		$originalNodeTranslations = $originalNodeChild->getNodeTranslation($locale, true);
151		$originalRef = $originalNodeTranslations->getPublicNodeVersion()->getRef($this->em);
152
153		if (!$originalRef instanceof DuplicateSubPageInterface \|\| !$originalRef->skipClone()) {
154		$this->dispatch(new PreNodeDuplicateEvent($originalNodeChild), Events::PRE_DUPLICATE_WITH_CHILDREN);
155		$newChildPage = $this->clonePage($originalNodeChild, $locale);
156		$newChildPage->setParent($newPage);
157
158		$newChildNode = $this->createNodeStructureForNewPage($originalNodeChild, $newChildPage, $user, $locale);
159		$this->dispatch(new PostNodeDuplicateEvent($originalNodeChild, $newChildNode, $newChildPage), Events::POST_DUPLICATE_WITH_CHILDREN);
160		$this->cloneChildren($originalNodeChild, $newChildPage, $user, $locale);
161		}
162		}
163		}
164
165		/**
166		* @param object $event
167		* @param string $eventName
168		*
169		* @return object
170		*/
171	View Code Duplication	private function dispatch($event, string $eventName)
172		{
173		if (class_exists(LegacyEventDispatcherProxy::class)) {
174		$eventDispatcher = LegacyEventDispatcherProxy::decorate($this->eventDispatcherInterface);
175
176		return $eventDispatcher->dispatch($event, $eventName);
177		}
178
179		return $this->eventDispatcherInterface->dispatch($eventName, $event);
180		}
181		}
182

Kunstmaan / KunstmaanBundlesCMS

Issues (3099)

Security Analysis not enabled

Kunstmaan/NodeBundle/Helper/PageCloningHelper.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like