Kunstmaan / KunstmaanBundlesCMS

src/Kunstmaan/MediaBundle/Tests/unit/Validator/Constraints/MediaValidatorTest.php

<?php

namespace Kunstmaan\MediaBundle\Tests\Validator\Constraints;

use Kunstmaan\MediaBundle\Entity\Media as MediaObject;
use Kunstmaan\MediaBundle\Validator\Constraints\Media;
use Kunstmaan\MediaBundle\Validator\Constraints\MediaValidator;
use Symfony\Component\Validator\Test\ConstraintValidatorTestCase;
use Symfony\Component\Validator\Validation;

class MediaValidatorTest extends ConstraintValidatorTestCase
{
    protected function createValidator()
    {
        return new MediaValidator();
    }

    public function testMimeTypeIsIgnoredWhenNotSpecified()
    {
        $constraint = new Media();
        $media = new MediaObject();

        $this->validator->validate($media, $constraint);

        $this->assertNoViolation();
    }

    /**
     * @param $contentType
     * @param $allowed
     * @param $message
     * @param $parameters
     * @param $code
     *
     * @dataProvider dataMimeTypes
     */
    public function testMimeTypeMatches($contentType, $allowed, $message = null, array $parameters = [], $code = null)
    {
        $constraint = new Media(['mimeTypes' => $allowed]);
        $media = (new MediaObject())->setContentType($contentType);

        $this->validator->validate($media, $constraint);

        if ($message && $code) {
            $this->buildViolation($message)
                ->setCode($code)
                ->setParameters($parameters)
                ->assertRaised();
        } else {
            $this->assertNoViolation();
        }
    }

    public function testSvgIsNotTestedForDimensions()
    {
        $constraint = new Media(['minHeight' => 100]);
        $media = (new MediaObject())->setContentType('image/svg+xml');

        $this->validator->validate($media, $constraint);

        $this->assertNoViolation();
    }

    /**
     * @param string $dimension
     * @param int    $value
     * @param string $message
     * @param array  $parameters
     * @param int    $code
     *
     * @dataProvider dataDimensions
     */
    public function testDimensionsAreChecked($dimension, $value, $message = null, array $parameters = [], $code = null)
    {
        $constraint = new Media([$dimension => $value]);
        $media = (new MediaObject())
            ->setMetadataValue('original_width', 100)
            ->setMetadataValue('original_height', 100)
            ->setContentType('image/png');

        $this->validator->validate($media, $constraint);

        if ($message && $code) {

The expression $message of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

The expression $code of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $this->buildViolation($message)
                ->setCode($code)
                ->setParameters($parameters)
                ->assertRaised();
        } else {
            $this->assertNoViolation();
        }
    }

    public function dataMimeTypes()
    {
        return [
            ['image/png', ['image/png']],
            ['image/png', ['image/jpg', 'image/png']],
            ['image/png', ['image/*']],
            ['image/PNG', ['image/png']],
            ['image/png', ['image/PNG']],
            ['image/png', ['image/jpg'], 'The type of the file is invalid ({{ type }}). Allowed types are {{ types }}.', ['{{ type }}' => '"image/png"', '{{ types }}' => '"image/jpg"'], Media::INVALID_MIME_TYPE_ERROR],
            ['image/png', ['application/*'], 'The type of the file is invalid ({{ type }}). Allowed types are {{ types }}.', ['{{ type }}' => '"image/png"', '{{ types }}' => '"application/*"'], Media::INVALID_MIME_TYPE_ERROR],
        ];
    }

    public function dataDimensions()
    {
        // image size is 100x100
        return [
            ['minHeight', 100],
            ['maxHeight', 100],
            ['minWidth', 100],
            ['maxWidth', 100],
            ['minWidth', 200, 'The image width is too small ({{ width }}px). Minimum width expected is {{ min_width }}px.', ['{{ width }}' => 100, '{{ min_width }}' => 200], Media::TOO_NARROW_ERROR],
            ['maxWidth', 50, 'The image width is too big ({{ width }}px). Allowed maximum width is {{ max_width }}px.', ['{{ width }}' => 100, '{{ max_width }}' => 50], Media::TOO_WIDE_ERROR],
            ['minHeight', 200, 'The image height is too small ({{ height }}px). Minimum height expected is {{ min_height }}px.', ['{{ height }}' => 100, '{{ min_height }}' => 200], Media::TOO_LOW_ERROR],
            ['maxHeight', 50, 'The image height is too big ({{ height }}px). Allowed maximum height is {{ max_height }}px.', ['{{ height }}' => 100, '{{ max_height }}' => 50], Media::TOO_HIGH_ERROR],
        ];
    }

    protected function getApiVersion()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return Validation::API_VERSION_2_5;
    }
}