Issues in GoogleAnalyticsAJAXController.php (master) - Issues in master - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3099)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/GoogleAnalyticsAJAXController.php (9 issues)

Labels

Severity

Wim Vandersmissen 9

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\DashboardBundle\Controller;

use Kunstmaan\AdminBundle\FlashMessages\FlashTypes;
use Kunstmaan\DashboardBundle\Command\GoogleAnalyticsDataCollectCommand;
use Kunstmaan\DashboardBundle\Entity\AnalyticsConfig;
use Kunstmaan\DashboardBundle\Entity\AnalyticsGoal;
use Kunstmaan\DashboardBundle\Entity\AnalyticsOverview;
use Kunstmaan\DashboardBundle\Entity\AnalyticsSegment;
use Kunstmaan\DashboardBundle\Repository\AnalyticsOverviewRepository;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\NullOutput;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;

class GoogleAnalyticsAJAXController extends Controller
{
    /**
     * @Route("/updateData", name="KunstmaanDashboardBundle_analytics_update")
     */
    public function runUpdateAction(Request $request)
    {
        $configId = $request->query->get('configId');
        $segmentId = $request->query->get('segmentId');

        $command = new GoogleAnalyticsDataCollectCommand();
        $command->setContainer($this->container);
        $input = new ArrayInput(array('--config' => $configId, '--segment' => $segmentId));
        $output = new NullOutput();
        $command->run($input, $output);

        return new JsonResponse(array(), 200, array('Content-Type' => 'application/json'));
    }

    /**
     * Return an ajax response with all data for an overview
     *
     * @Route("/getOverview/{id}", requirements={"id" = "\d+"}, name="KunstmaanDashboardBundle_analytics_overview_ajax")
     */
    public function getOverviewAction($id)
    {
        $em = $this->getDoctrine()->getManager();
        /** @var AnalyticsOverviewRepository $analyticsOverviewRepository */
        $analyticsOverviewRepository = $em->getRepository(AnalyticsOverview::class);
        $overview = $analyticsOverviewRepository->find($id);

        // goals data
        $goals = array();
        foreach ($overview->getActiveGoals() as $key => $goal) {
            /* @var AnalyticsGoal $goal */
            $goals[$key]['name'] = $goal->getName();
            $goals[$key]['visits'] = $goal->getVisits();
            $goals[$key]['id'] = $goal->getId();
            $goals[$key]['chartData'] = json_decode($goal->getChartData());
        }

        // overview data
        $overviewData = array(
            'id' => $overview->getId(),
            'chartData' => json_decode($overview->getChartData(), true),
            'chartDataMaxValue' => $overview->getChartDataMaxValue(),
            'title' => $overview->getTitle(),
            'timespan' => $overview->getTimespan(),
            'startOffset' => $overview->getStartOffset(),
            'sessions' => number_format($overview->getSessions()),
            'users' => number_format($overview->getUsers()),
            'pagesPerSession' => round($overview->getPagesPerSession(), 2),
            'avgSessionDuration' => $overview->getAvgSessionDuration(),
            'returningUsers' => number_format($overview->getReturningUsers()),
            'newUsers' => round($overview->getNewUsers(), 2),
            'pageViews' => number_format($overview->getPageViews()),
            'returningUsersPercentage' => $overview->getReturningUsersPercentage(),
            'newUsersPercentage' => $overview->getNewUsersPercentage(),
        );

        // put all data in the return array
        $return = array(
            'responseCode' => 200,
            'overview' => $overviewData,
            'goals' => $goals,
        );

        // return json response
        return new JsonResponse($return, 200, array('Content-Type' => 'application/json'));
    }

    /* =============================== ACCOUNT =============================== */

    /**
     * @Route("/accounts/", name="kunstmaan_dashboard_ajax_accounts")
     */
    public function getAccountsAction(Request $request)
    {
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configId = $request->query->get('configId');
        if ($configId) {
            $configHelper->init($configId);
        }

        $accounts = $configHelper->getAccounts();

        return new JsonResponse($accounts, 200, array('Content-Type' => 'application/json'));
    }

    /**
     * @Route("/account/save", name="kunstmaan_dashboard_ajax_account_save")
     */
    public function saveAccountAction(Request $request)

    {
        $accountId = $request->query->get('id');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->saveAccountId($accountId);

        return new JsonResponse();
    }

    /* =============================== PROPERTY =============================== */

    /**
     * @Route("/properties/", name="kunstmaan_dashboard_ajax_properties")
     */
    public function getPropertiesAction(Request $request)
    {
        $accountId = $request->query->get('accountId');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configId = $request->query->get('configId');
        if ($configId) {
            $configHelper->init($configId);
        }

        $properties = $configHelper->getProperties($accountId);

        return new JsonResponse($properties, 200, array('Content-Type' => 'application/json'));
    }

    /**
     * @Route("/property/save", name="kunstmaan_dashboard_ajax_property_save")
     */
    public function savePropertyAction(Request $request)

    {
        $propertyId = $request->query->get('id');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->savePropertyId($propertyId);

        return new JsonResponse();
    }

    /* =============================== PROFILE =============================== */

    /**
     * @Route("/profiles/", name="kunstmaan_dashboard_ajax_profiles")
     */
    public function getProfilesAction(Request $request)
    {
        $accountId = $request->query->get('accountId');
        $propertyId = $request->query->get('propertyId');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configId = $request->query->get('configId');
        if ($configId) {
            $configHelper->init($configId);
        }

        $profiles = $configHelper->getProfiles($accountId, $propertyId);

        return new JsonResponse($profiles, 200, array('Content-Type' => 'application/json'));
    }

    /**
     * @Route("/profile/save", name="kunstmaan_dashboard_ajax_profile_save")
     */
    public function saveProfileAction(Request $request)

    {
        $propertyId = $request->query->get('id');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->saveProfileId($propertyId);

        return new JsonResponse();
    }

    /* =============================== CONFIG =============================== */

    /**
     * @Route("/config/save", name="kunstmaan_dashboard_ajax_config_save")
     */
    public function saveConfigAction(Request $request)
    {
        // get params
        $configId = $request->query->get('configId');
        $accountId = $request->query->get('accountId');
        $propertyId = $request->query->get('propertyId');
        $profileId = $request->query->get('profileId');
        $disableGoals = $request->query->get('disableGoals');

        // edit the config
        $em = $this->getDoctrine()->getManager();
        $config = $em->getRepository(AnalyticsConfig::class)->find($configId);
        if ($accountId && $propertyId && $profileId) {
            $config->setAccountId($accountId);
            $config->setPropertyId($propertyId);
            $config->setProfileId($profileId);
        }

        $em->persist($config);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $em->flush();

        // set the config name
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->init($configId);
        $profile = $configHelper->getActiveProfile();
        $config->setName($profile['profileName']);
        $config->setDisableGoals($disableGoals);

        $em->persist($config);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $em->flush();

        $this->addFlash(
            FlashTypes::SUCCESS,
            $this->get('translator')->trans('kuma_admin.ga_ajax_controller.flash.success')
        );

        return new JsonResponse();
    }

    /**
     * @Route("/config/remove", name="kunstmaan_dashboard_ajax_config_remove")
     */
    public function removeConfigAction(Request $request)
    {
        // get params
        $configId = $request->query->get('configId');

        // edit the config
        $em = $this->getDoctrine()->getManager();
        $config = $em->getRepository(AnalyticsConfig::class)->find($configId);
        $em->remove($config);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $em->flush();

        return new JsonResponse();
    }

    /**
     * @Route("/config/get", name="kunstmaan_dashboard_ajax_config_get")
     */
    public function getConfigAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $config = $em->getRepository(AnalyticsConfig::class)->findFirst();
        $accountId = $config->getAccountId();

        if (!$accountId) {
            return new JsonResponse();
        }

        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->getAccounts();
        $configHelper->getProperties();
        $configHelper->getProfiles();
    }

    /* =============================== SEGMENT =============================== */

    /**
     * @Route("/segment/add/", name="kunstmaan_dashboard_ajax_segment_add")
     */
    public function addSegmentAction(Request $request)
    {
        $configId = $request->query->get('configId');
        $em = $this->getDoctrine()->getManager();

        // create a new segment
        $segment = new AnalyticsSegment();
        $query = $request->query->get('query');
        $name = $request->query->get('name');
        $segment->setQuery($query);
        $segment->setName($name);

        // add the segment to the config
        $config = $em->getRepository(AnalyticsConfig::class)->find($configId);
        $segment->setConfig($config);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $segments = $config->getSegments();
        $segments[] = $segment;
        $config->setSegments($segments);

        $em->persist($config);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $em->flush();

        return new JsonResponse();
    }

    /**
     * @Route("/segment/delete", name="kunstmaan_dashboard_ajax_segment_delete")
     */
    public function deleteSegmentAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        $id = $request->query->get('id');
        $em->getRepository(AnalyticsSegment::class)->deleteSegment($id);

        return new JsonResponse();
    }

    /**
     * @Route("/segment/edit", name="kunstmaan_dashboard_ajax_segment_edit")
     */
    public function editSegmentAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        $id = $request->query->get('id');
        $query = $request->query->get('query');
        $name = $request->query->get('name');
        $segment = $em->getRepository(AnalyticsSegment::class)->find($id);
        $segment->setName($name);
        $segment->setQuery($query);
        $em->persist($segment);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $em->flush();

        return new JsonResponse();
    }
}


1		<?php
2
3		namespace Kunstmaan\DashboardBundle\Controller;
4
5		use Kunstmaan\AdminBundle\FlashMessages\FlashTypes;
6		use Kunstmaan\DashboardBundle\Command\GoogleAnalyticsDataCollectCommand;
7		use Kunstmaan\DashboardBundle\Entity\AnalyticsConfig;
8		use Kunstmaan\DashboardBundle\Entity\AnalyticsGoal;
9		use Kunstmaan\DashboardBundle\Entity\AnalyticsOverview;
10		use Kunstmaan\DashboardBundle\Entity\AnalyticsSegment;
11		use Kunstmaan\DashboardBundle\Repository\AnalyticsOverviewRepository;
12		use Symfony\Component\Routing\Annotation\Route;
13		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
14		use Symfony\Component\Console\Input\ArrayInput;
15		use Symfony\Component\Console\Output\NullOutput;
16		use Symfony\Component\HttpFoundation\JsonResponse;
17		use Symfony\Component\HttpFoundation\Request;
18
19		class GoogleAnalyticsAJAXController extends Controller
20		{
21		/**
22		* @Route("/updateData", name="KunstmaanDashboardBundle_analytics_update")
23		*/
24		public function runUpdateAction(Request $request)
25		{
26		$configId = $request->query->get('configId');
27		$segmentId = $request->query->get('segmentId');
28
29		$command = new GoogleAnalyticsDataCollectCommand();
30		$command->setContainer($this->container);
31		$input = new ArrayInput(array('--config' => $configId, '--segment' => $segmentId));
32		$output = new NullOutput();
33		$command->run($input, $output);
34
35		return new JsonResponse(array(), 200, array('Content-Type' => 'application/json'));
36		}
37
38		/**
39		* Return an ajax response with all data for an overview
40		*
41		* @Route("/getOverview/{id}", requirements={"id" = "\d+"}, name="KunstmaanDashboardBundle_analytics_overview_ajax")
42		*/
43		public function getOverviewAction($id)
44		{
45		$em = $this->getDoctrine()->getManager();
46		/** @var AnalyticsOverviewRepository $analyticsOverviewRepository */
47		$analyticsOverviewRepository = $em->getRepository(AnalyticsOverview::class);
48		$overview = $analyticsOverviewRepository->find($id);
49
50		// goals data
51		$goals = array();
52		foreach ($overview->getActiveGoals() as $key => $goal) {
53		/* @var AnalyticsGoal $goal */
54		$goals[$key]['name'] = $goal->getName();
55		$goals[$key]['visits'] = $goal->getVisits();
56		$goals[$key]['id'] = $goal->getId();
57		$goals[$key]['chartData'] = json_decode($goal->getChartData());
58		}
59
60		// overview data
61		$overviewData = array(
62		'id' => $overview->getId(),
63		'chartData' => json_decode($overview->getChartData(), true),
64		'chartDataMaxValue' => $overview->getChartDataMaxValue(),
65		'title' => $overview->getTitle(),
66		'timespan' => $overview->getTimespan(),
67		'startOffset' => $overview->getStartOffset(),
68		'sessions' => number_format($overview->getSessions()),
69		'users' => number_format($overview->getUsers()),
70		'pagesPerSession' => round($overview->getPagesPerSession(), 2),
71		'avgSessionDuration' => $overview->getAvgSessionDuration(),
72		'returningUsers' => number_format($overview->getReturningUsers()),
73		'newUsers' => round($overview->getNewUsers(), 2),
74		'pageViews' => number_format($overview->getPageViews()),
75		'returningUsersPercentage' => $overview->getReturningUsersPercentage(),
76		'newUsersPercentage' => $overview->getNewUsersPercentage(),
77		);
78
79		// put all data in the return array
80		$return = array(
81		'responseCode' => 200,
82		'overview' => $overviewData,
83		'goals' => $goals,
84		);
85
86		// return json response
87		return new JsonResponse($return, 200, array('Content-Type' => 'application/json'));
88		}
89
90		/* =============================== ACCOUNT =============================== */
91
92		/**
93		* @Route("/accounts/", name="kunstmaan_dashboard_ajax_accounts")
94		*/
95		public function getAccountsAction(Request $request)
96		{
97		$configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
98		$configId = $request->query->get('configId');
99		if ($configId) {
100		$configHelper->init($configId);
101		}
102
103		$accounts = $configHelper->getAccounts();
104
105		return new JsonResponse($accounts, 200, array('Content-Type' => 'application/json'));
106		}
107
108		/**
109		* @Route("/account/save", name="kunstmaan_dashboard_ajax_account_save")
110		*/
111	View Code Duplication	public function saveAccountAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112		{
113		$accountId = $request->query->get('id');
114		$configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
115		$configHelper->saveAccountId($accountId);
116
117		return new JsonResponse();
118		}
119
120		/* =============================== PROPERTY =============================== */
121
122		/**
123		* @Route("/properties/", name="kunstmaan_dashboard_ajax_properties")
124		*/
125		public function getPropertiesAction(Request $request)
126		{
127		$accountId = $request->query->get('accountId');
128		$configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
129		$configId = $request->query->get('configId');
130		if ($configId) {
131		$configHelper->init($configId);
132		}
133
134		$properties = $configHelper->getProperties($accountId);
135
136		return new JsonResponse($properties, 200, array('Content-Type' => 'application/json'));
137		}
138
139		/**
140		* @Route("/property/save", name="kunstmaan_dashboard_ajax_property_save")
141		*/
142	View Code Duplication	public function savePropertyAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
143		{
144		$propertyId = $request->query->get('id');
145		$configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
146		$configHelper->savePropertyId($propertyId);
147
148		return new JsonResponse();
149		}
150
151		/* =============================== PROFILE =============================== */
152
153		/**
154		* @Route("/profiles/", name="kunstmaan_dashboard_ajax_profiles")
155		*/
156		public function getProfilesAction(Request $request)
157		{
158		$accountId = $request->query->get('accountId');
159		$propertyId = $request->query->get('propertyId');
160		$configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
161		$configId = $request->query->get('configId');
162		if ($configId) {
163		$configHelper->init($configId);
164		}
165
166		$profiles = $configHelper->getProfiles($accountId, $propertyId);
167
168		return new JsonResponse($profiles, 200, array('Content-Type' => 'application/json'));
169		}
170
171		/**
172		* @Route("/profile/save", name="kunstmaan_dashboard_ajax_profile_save")
173		*/
174	View Code Duplication	public function saveProfileAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
175		{
176		$propertyId = $request->query->get('id');
177		$configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
178		$configHelper->saveProfileId($propertyId);
179
180		return new JsonResponse();
181		}
182
183		/* =============================== CONFIG =============================== */
184
185		/**
186		* @Route("/config/save", name="kunstmaan_dashboard_ajax_config_save")
187		*/
188		public function saveConfigAction(Request $request)
189		{
190		// get params
191		$configId = $request->query->get('configId');
192		$accountId = $request->query->get('accountId');
193		$propertyId = $request->query->get('propertyId');
194		$profileId = $request->query->get('profileId');
195		$disableGoals = $request->query->get('disableGoals');
196
197		// edit the config
198		$em = $this->getDoctrine()->getManager();
199		$config = $em->getRepository(AnalyticsConfig::class)->find($configId);
200		if ($accountId && $propertyId && $profileId) {
201		$config->setAccountId($accountId);
202		$config->setPropertyId($propertyId);
203		$config->setProfileId($profileId);
204		}
205
206		$em->persist($config);
		0 ignored issues – show Bug introduced 2020-04-13 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$config` defined by `$em->getRepository(\Kuns...class)->find($configId)` on line `199` can also be of type `null`; however, `Doctrine\Persistence\ObjectManager::persist()` does only seem to accept `object`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
207		$em->flush();
208
209		// set the config name
210		$configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
211		$configHelper->init($configId);
212		$profile = $configHelper->getActiveProfile();
213		$config->setName($profile['profileName']);
214		$config->setDisableGoals($disableGoals);
215
216		$em->persist($config);
		0 ignored issues – show Bug introduced 2020-04-13 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$config` defined by `$em->getRepository(\Kuns...class)->find($configId)` on line `199` can also be of type `null`; however, `Doctrine\Persistence\ObjectManager::persist()` does only seem to accept `object`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
217		$em->flush();
218
219		$this->addFlash(
220		FlashTypes::SUCCESS,
221		$this->get('translator')->trans('kuma_admin.ga_ajax_controller.flash.success')
222		);
223
224		return new JsonResponse();
225		}
226
227		/**
228		* @Route("/config/remove", name="kunstmaan_dashboard_ajax_config_remove")
229		*/
230		public function removeConfigAction(Request $request)
231		{
232		// get params
233		$configId = $request->query->get('configId');
234
235		// edit the config
236		$em = $this->getDoctrine()->getManager();
237		$config = $em->getRepository(AnalyticsConfig::class)->find($configId);
238		$em->remove($config);
		0 ignored issues – show Bug introduced 2020-04-13 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$config` defined by `$em->getRepository(\Kuns...class)->find($configId)` on line `237` can also be of type `null`; however, `Doctrine\Persistence\ObjectManager::remove()` does only seem to accept `object`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
239		$em->flush();
240
241		return new JsonResponse();
242		}
243
244		/**
245		* @Route("/config/get", name="kunstmaan_dashboard_ajax_config_get")
246		*/
247		public function getConfigAction(Request $request)
248		{
249		$em = $this->getDoctrine()->getManager();
250		$config = $em->getRepository(AnalyticsConfig::class)->findFirst();
251		$accountId = $config->getAccountId();
252
253		if (!$accountId) {
254		return new JsonResponse();
255		}
256
257		$configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
258		$configHelper->getAccounts();
259		$configHelper->getProperties();
260		$configHelper->getProfiles();
261		}
262
263		/* =============================== SEGMENT =============================== */
264
265		/**
266		* @Route("/segment/add/", name="kunstmaan_dashboard_ajax_segment_add")
267		*/
268		public function addSegmentAction(Request $request)
269		{
270		$configId = $request->query->get('configId');
271		$em = $this->getDoctrine()->getManager();
272
273		// create a new segment
274		$segment = new AnalyticsSegment();
275		$query = $request->query->get('query');
276		$name = $request->query->get('name');
277		$segment->setQuery($query);
278		$segment->setName($name);
279
280		// add the segment to the config
281		$config = $em->getRepository(AnalyticsConfig::class)->find($configId);
282		$segment->setConfig($config);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$config` is of type `object\|null`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
283		$segments = $config->getSegments();
284		$segments[] = $segment;
285		$config->setSegments($segments);
286
287		$em->persist($config);
		0 ignored issues – show Bug introduced 2020-04-13 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$config` defined by `$em->getRepository(\Kuns...class)->find($configId)` on line `281` can also be of type `null`; however, `Doctrine\Persistence\ObjectManager::persist()` does only seem to accept `object`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
288		$em->flush();
289
290		return new JsonResponse();
291		}
292
293		/**
294		* @Route("/segment/delete", name="kunstmaan_dashboard_ajax_segment_delete")
295		*/
296		public function deleteSegmentAction(Request $request)
297		{
298		$em = $this->getDoctrine()->getManager();
299
300		$id = $request->query->get('id');
301		$em->getRepository(AnalyticsSegment::class)->deleteSegment($id);
302
303		return new JsonResponse();
304		}
305
306		/**
307		* @Route("/segment/edit", name="kunstmaan_dashboard_ajax_segment_edit")
308		*/
309		public function editSegmentAction(Request $request)
310		{
311		$em = $this->getDoctrine()->getManager();
312
313		$id = $request->query->get('id');
314		$query = $request->query->get('query');
315		$name = $request->query->get('name');
316		$segment = $em->getRepository(AnalyticsSegment::class)->find($id);
317		$segment->setName($name);
318		$segment->setQuery($query);
319		$em->persist($segment);
		0 ignored issues – show Bug introduced 2020-04-13 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$segment` defined by `$em->getRepository(\Kuns...ment::class)->find($id)` on line `316` can also be of type `null`; however, `Doctrine\Persistence\ObjectManager::persist()` does only seem to accept `object`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
320		$em->flush();
321
322		return new JsonResponse();
323		}
324		}
325

Kunstmaan / KunstmaanBundlesCMS

Issues (3099)

Security Analysis not enabled

Controller/GoogleAnalyticsAJAXController.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like