Issues in VersionCheckTest.php (master) - Issues in master - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3099)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

unit/Helper/VersionCheck/VersionCheckTest.php (13 issues)

Labels

Severity

Peter Zentjens 13

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Tests\Helper;

use Doctrine\Common\Cache\ArrayCache;
use GuzzleHttp\Client;
use GuzzleHttp\Handler\MockHandler;
use GuzzleHttp\HandlerStack;
use GuzzleHttp\Psr7\Response;
use Kunstmaan\AdminBundle\Helper\VersionCheck\Exception\ParseException;
use Kunstmaan\AdminBundle\Helper\VersionCheck\VersionChecker;
use PHPUnit\Framework\TestCase;
use Psr\Cache\CacheItemInterface;
use Symfony\Component\Cache\Adapter\AdapterInterface;
use Symfony\Component\Cache\Adapter\ArrayAdapter;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\Translation\Translator;
use Symfony\Component\Translation\TranslatorInterface as LegacyTranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class VersionCheckTest extends TestCase
{
    /** @var \PHPUnit\Framework\MockObject\MockObject|LegacyTranslatorInterface|TranslatorInterface */
    private $translator;
    /** @var ContainerInterface (mock) */
    private $container;

    /** @var ArrayAdapter */
    private $cache;

    public function setUp(): void
    {
        /* @var ContainerInterface $container */
        $this->container = $this->createMock(ContainerInterface::class);

        $this->cache = $this->createMock(AdapterInterface::class);

        if (\interface_exists(TranslatorInterface::class)) {
            $this->translator = $this->createMock(TranslatorInterface::class);
        } else {
            $this->translator = $this->createMock(LegacyTranslatorInterface::class);
        }
    }

    /**
     * @group legacy
     * @expectedDeprecation Passing an instance of "Doctrine\Common\Cache\CacheProvider" as the second argument in "Kunstmaan\AdminBundle\Helper\VersionCheck\VersionChecker::__construct" is deprecated since KunstmaanAdminBundle 5.7 and an instance of "Symfony\Component\Cache\Adapter\AdapterInterface" will be required in KunstmaanAdminBundle 6.0.
     */
    public function testDeprecatedCacheConstructorParameter()
    {
        new VersionChecker($this->createMock(ContainerInterface::class), new ArrayCache(), $this->translator);
    }

    /**
     * @group legacy
     */
    public function testCacheConstructorParameterType()
    {
        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('The "$cache" parameter should extend from "Doctrine\Common\Cache\CacheProvider" or implement "Symfony\Component\Cache\Adapter\AdapterInterface"');

        new VersionChecker($this->createMock(ContainerInterface::class), new \stdClass(), $this->translator);
    }

    /**
     * @group legacy
     */
    public function testTranslatorConstructorParameterType()
    {
        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('The "$translator" parameter should be instance of "Symfony\Contracts\Translation\TranslatorInterface" or "Symfony\Component\Translation\TranslatorInterface"');

        new VersionChecker($this->createMock(ContainerInterface::class), new ArrayCache(), new \stdClass());
    }

    /**
     * @param array|null $methods
     *
     * @return \PHPUnit\Framework\MockObject\MockObject|VersionChecker
     */
    public function setUpVersionCheckerMock(?array $methods)
    {
        $versionCheckerMock = $this->getMockBuilder(VersionChecker::class)

            ->setConstructorArgs([$this->container, $this->cache, $this->translator])
            ->setMethods($methods)
            ->getMock()
        ;

        return $versionCheckerMock;
    }

    public function testIsEnabled()
    {
        $this->container

            ->expects($this->exactly(3))
            ->method('getParameter')
            ->will($this->onConsecutiveCalls('url', 300, true))
        ;

        $versionChecker = $this->getVersionChecker($this->container, new ArrayAdapter(), $this->translator);

        $this->assertTrue($versionChecker->isEnabled());
    }

    public function testPeriodicallyCheck()
    {
        $this->container

            ->expects($this->exactly(3))
            ->method('getParameter')
            ->will($this->onConsecutiveCalls('url', 300, true))
        ;

        $cacheItem = $this->createMock(CacheItemInterface::class);
        $cacheItem->method('isHit')->willReturn(true);
        $cacheItem->method('get')->willReturn([]);

        $this->cache

            ->expects($this->once())
            ->method('getItem')
            ->willReturn($cacheItem)
        ;
        $versionCheckerMock = $this->setUpVersionCheckerMock(null);
        $versionCheckerMock->periodicallyCheck();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function testCheckWithInvalidResponse()
    {
        $this->container

            ->expects($this->exactly(4))
            ->method('getParameter')
            ->will($this->onConsecutiveCalls('url', 300, true, 'title'))
        ;

        $requestMock = $this->createMock(Request::class);

        $stackMock = $this->createMock(RequestStack::class);
        $stackMock
            ->expects($this->once())
            ->method('getCurrentRequest')
            ->willReturn($requestMock)
        ;
        $kernelMock = $this->createMock(Kernel::class);

        $this->container

            ->expects($this->exactly(2))
            ->method('get')
            ->will($this->onConsecutiveCalls($stackMock, $kernelMock))
        ;

        $versionCheckerMock = $this->setUpVersionCheckerMock(['parseComposer']);
        $versionCheckerMock
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('parseComposer')
            ->willReturn(['name' => 'box/spout'])
        ;
        $this->assertFalse($versionCheckerMock->check());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @dataProvider provider
     */
    public function testCheck(string $lockPath, string $expectedType, string $expected)
    {
        if ('exception' === $expectedType) {
            $this->expectException(ParseException::class);
            $this->expectExceptionMessage($expected);
        }

        $this->container

            ->expects($this->any())
            ->method('getParameter')
            ->will($this->onConsecutiveCalls('url', 300, true, 'title'))
        ;

        $requestStack = new RequestStack();
        $requestStack->push(new Request());

        $translatorMock = $this->createMock(Translator::class);
        $translatorMock
            ->expects($this->any())
            ->method('trans')
            ->willReturn('translated')
        ;

        $kernelMock = $this->createMock(Kernel::class);

        if ('instanceOf' === $expectedType) {
            $cacheItem = $this->createMock(CacheItemInterface::class);
            $cacheItem->method('isHit')->willReturn(false);
            $cacheItem->expects($this->once())->method('expiresAfter')->with(300);
            $cacheItem->expects($this->once())->method('set')->with($this->isInstanceOf($expected));

            $this->cache
                ->expects($this->once())
                ->method('getItem')
                ->willReturn($cacheItem);
        }

        $this->container

            ->expects($this->exactly(3))
            ->method('get')
            ->will($this->onConsecutiveCalls($requestStack, $kernelMock, $translatorMock))
        ;

        $mock = new MockHandler([
            new Response(200, ['X-Foo' => 'Bar'], \json_encode(['foo' => 'bar'])),
        ]);

        $handler = HandlerStack::create($mock);
        $client = new Client(['handler' => $handler]);

        $versionCheckerMock = $this->setUpVersionCheckerMock(['getClient', 'getLockPath']);
        $versionCheckerMock
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->any())
            ->method('getClient')
            ->willReturn($client)
        ;
        $versionCheckerMock
            ->expects($this->once())
            ->method('getLockPath')
            ->willReturn($lockPath)
        ;

        if ('instanceOf' === $expectedType) {
            $this->assertInstanceOf($expected, $versionCheckerMock->check());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        } else {
            $versionCheckerMock->check();
        }
    }

    public function provider()
    {
        $baseDir = __DIR__ . '/testdata';

        return [
            'composer.lock ok' => [$baseDir.'/composer_ok.lock', 'instanceOf', \stdClass::class],
            'composer.lock broken' => [$baseDir.'/composer_broken.lock', 'exception', 'translated (#4)'],
            'composer.lock bundleless' => [$baseDir.'/composer_bundleless.lock', 'exception', 'translated'],
            'composer.lock not found' => [$baseDir.'/composer_not_there.lock', 'exception', 'translated'],
        ];
    }

    private function getVersionChecker(ContainerInterface $container, AdapterInterface $cache, $translator)
    {
        return new VersionChecker($container, $cache, $translator);
    }
}


Issues (3099)

Security Analysis not enabled

unit/Helper/VersionCheck/VersionCheckTest.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Kunstmaan\AdminBundle\Tests\Helper;
4
5			use Doctrine\Common\Cache\ArrayCache;
6			use GuzzleHttp\Client;
7			use GuzzleHttp\Handler\MockHandler;
8			use GuzzleHttp\HandlerStack;
9			use GuzzleHttp\Psr7\Response;
10			use Kunstmaan\AdminBundle\Helper\VersionCheck\Exception\ParseException;
11			use Kunstmaan\AdminBundle\Helper\VersionCheck\VersionChecker;
12			use PHPUnit\Framework\TestCase;
13			use Psr\Cache\CacheItemInterface;
14			use Symfony\Component\Cache\Adapter\AdapterInterface;
15			use Symfony\Component\Cache\Adapter\ArrayAdapter;
16			use Symfony\Component\DependencyInjection\ContainerInterface;
17			use Symfony\Component\HttpFoundation\Request;
18			use Symfony\Component\HttpFoundation\RequestStack;
19			use Symfony\Component\HttpKernel\Kernel;
20			use Symfony\Component\Translation\Translator;
21			use Symfony\Component\Translation\TranslatorInterface as LegacyTranslatorInterface;
22			use Symfony\Contracts\Translation\TranslatorInterface;
23
24			class VersionCheckTest extends TestCase
25			{
26			/** @var \PHPUnit\Framework\MockObject\MockObject\|LegacyTranslatorInterface\|TranslatorInterface */
27			private $translator;
28			/** @var ContainerInterface (mock) */
29			private $container;
30
31			/** @var ArrayAdapter */
32			private $cache;
33
34			public function setUp(): void
35			{
36			/* @var ContainerInterface $container */
37			$this->container = $this->createMock(ContainerInterface::class);
38
39			$this->cache = $this->createMock(AdapterInterface::class);
40
41			if (\interface_exists(TranslatorInterface::class)) {
42			$this->translator = $this->createMock(TranslatorInterface::class);
43			} else {
44			$this->translator = $this->createMock(LegacyTranslatorInterface::class);
45			}
46			}
47
48			/**
49			* @group legacy
50			* @expectedDeprecation Passing an instance of "Doctrine\Common\Cache\CacheProvider" as the second argument in "Kunstmaan\AdminBundle\Helper\VersionCheck\VersionChecker::__construct" is deprecated since KunstmaanAdminBundle 5.7 and an instance of "Symfony\Component\Cache\Adapter\AdapterInterface" will be required in KunstmaanAdminBundle 6.0.
51			*/
52			public function testDeprecatedCacheConstructorParameter()
53			{
54			new VersionChecker($this->createMock(ContainerInterface::class), new ArrayCache(), $this->translator);
55			}
56
57			/**
58			* @group legacy
59			*/
60			public function testCacheConstructorParameterType()
61			{
62			$this->expectException(\InvalidArgumentException::class);
63			$this->expectExceptionMessage('The "$cache" parameter should extend from "Doctrine\Common\Cache\CacheProvider" or implement "Symfony\Component\Cache\Adapter\AdapterInterface"');
64
65			new VersionChecker($this->createMock(ContainerInterface::class), new \stdClass(), $this->translator);
66			}
67
68			/**
69			* @group legacy
70			*/
71			public function testTranslatorConstructorParameterType()
72			{
73			$this->expectException(\InvalidArgumentException::class);
74			$this->expectExceptionMessage('The "$translator" parameter should be instance of "Symfony\Contracts\Translation\TranslatorInterface" or "Symfony\Component\Translation\TranslatorInterface"');
75
76			new VersionChecker($this->createMock(ContainerInterface::class), new ArrayCache(), new \stdClass());
77			}
78
79			/**
80			* @param array\|null $methods
81			*
82			* @return \PHPUnit\Framework\MockObject\MockObject\|VersionChecker
83			*/
84			public function setUpVersionCheckerMock(?array $methods)
85			{
86			$versionCheckerMock = $this->getMockBuilder(VersionChecker::class)
			0 ignored issues – show Deprecated Code introduced 2020-09-15 09:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit\Framework\MockOb...ckBuilder::setMethods()` has been deprecated with message: https://github.com/sebastianbergmann/phpunit/pull/3687 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
87			->setConstructorArgs([$this->container, $this->cache, $this->translator])
88			->setMethods($methods)
89			->getMock()
90			;
91
92			return $versionCheckerMock;
93			}
94
95			public function testIsEnabled()
96			{
97			$this->container
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Symfony\Component...ion\ContainerInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
98			->expects($this->exactly(3))
99			->method('getParameter')
100			->will($this->onConsecutiveCalls('url', 300, true))
101			;
102
103			$versionChecker = $this->getVersionChecker($this->container, new ArrayAdapter(), $this->translator);
104
105			$this->assertTrue($versionChecker->isEnabled());
106			}
107
108			public function testPeriodicallyCheck()
109			{
110			$this->container
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Symfony\Component...ion\ContainerInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
111			->expects($this->exactly(3))
112			->method('getParameter')
113			->will($this->onConsecutiveCalls('url', 300, true))
114			;
115
116			$cacheItem = $this->createMock(CacheItemInterface::class);
117			$cacheItem->method('isHit')->willReturn(true);
118			$cacheItem->method('get')->willReturn([]);
119
120			$this->cache
			0 ignored issues – show Bug introduced 2020-09-17 19:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Symfony\Component...e\Adapter\ArrayAdapter>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
121			->expects($this->once())
122			->method('getItem')
123			->willReturn($cacheItem)
124			;
125			$versionCheckerMock = $this->setUpVersionCheckerMock(null);
126			$versionCheckerMock->periodicallyCheck();
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `periodicallyCheck` does only exist in `Kunstmaan\AdminBundle\He...ionCheck\VersionChecker`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
127			}
128
129			public function testCheckWithInvalidResponse()
130			{
131			$this->container
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Symfony\Component...ion\ContainerInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
132			->expects($this->exactly(4))
133			->method('getParameter')
134			->will($this->onConsecutiveCalls('url', 300, true, 'title'))
135			;
136
137			$requestMock = $this->createMock(Request::class);
138
139			$stackMock = $this->createMock(RequestStack::class);
140			$stackMock
141			->expects($this->once())
142			->method('getCurrentRequest')
143			->willReturn($requestMock)
144			;
145			$kernelMock = $this->createMock(Kernel::class);
146
147			$this->container
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Symfony\Component...ion\ContainerInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
148			->expects($this->exactly(2))
149			->method('get')
150			->will($this->onConsecutiveCalls($stackMock, $kernelMock))
151			;
152
153			$versionCheckerMock = $this->setUpVersionCheckerMock(['parseComposer']);
154			$versionCheckerMock
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit\Framework\MockObject\MockObject`, but not in `Kunstmaan\AdminBundle\He...ionCheck\VersionChecker`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
155			->expects($this->once())
156			->method('parseComposer')
157			->willReturn(['name' => 'box/spout'])
158			;
159			$this->assertFalse($versionCheckerMock->check());
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `check` does only exist in `Kunstmaan\AdminBundle\He...ionCheck\VersionChecker`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
160			}
161
162			/**
163			* @dataProvider provider
164			*/
165			public function testCheck(string $lockPath, string $expectedType, string $expected)
166			{
167			if ('exception' === $expectedType) {
168			$this->expectException(ParseException::class);
169			$this->expectExceptionMessage($expected);
170			}
171
172			$this->container
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Symfony\Component...ion\ContainerInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
173			->expects($this->any())
174			->method('getParameter')
175			->will($this->onConsecutiveCalls('url', 300, true, 'title'))
176			;
177
178			$requestStack = new RequestStack();
179			$requestStack->push(new Request());
180
181			$translatorMock = $this->createMock(Translator::class);
182			$translatorMock
183			->expects($this->any())
184			->method('trans')
185			->willReturn('translated')
186			;
187
188			$kernelMock = $this->createMock(Kernel::class);
189
190			if ('instanceOf' === $expectedType) {
191			$cacheItem = $this->createMock(CacheItemInterface::class);
192			$cacheItem->method('isHit')->willReturn(false);
193			$cacheItem->expects($this->once())->method('expiresAfter')->with(300);
194			$cacheItem->expects($this->once())->method('set')->with($this->isInstanceOf($expected));
195
196			$this->cache
197			->expects($this->once())
198			->method('getItem')
199			->willReturn($cacheItem);
200			}
201
202			$this->container
			0 ignored issues – show Bug introduced 2020-09-17 19:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Symfony\Component...ion\ContainerInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
203			->expects($this->exactly(3))
204			->method('get')
205			->will($this->onConsecutiveCalls($requestStack, $kernelMock, $translatorMock))
206			;
207
208			$mock = new MockHandler([
209			new Response(200, ['X-Foo' => 'Bar'], \json_encode(['foo' => 'bar'])),
210			]);
211
212			$handler = HandlerStack::create($mock);
213			$client = new Client(['handler' => $handler]);
214
215			$versionCheckerMock = $this->setUpVersionCheckerMock(['getClient', 'getLockPath']);
216			$versionCheckerMock
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit\Framework\MockObject\MockObject`, but not in `Kunstmaan\AdminBundle\He...ionCheck\VersionChecker`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
217			->expects($this->any())
218			->method('getClient')
219			->willReturn($client)
220			;
221			$versionCheckerMock
222			->expects($this->once())
223			->method('getLockPath')
224			->willReturn($lockPath)
225			;
226
227			if ('instanceOf' === $expectedType) {
228			$this->assertInstanceOf($expected, $versionCheckerMock->check());
			0 ignored issues – show Bug introduced 2019-02-08 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `check` does only exist in `Kunstmaan\AdminBundle\He...ionCheck\VersionChecker`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
229			} else {
230			$versionCheckerMock->check();
231			}
232			}
233
234			public function provider()
235			{
236			$baseDir = __DIR__ . '/testdata';
237
238			return [
239			'composer.lock ok' => [$baseDir.'/composer_ok.lock', 'instanceOf', \stdClass::class],
240			'composer.lock broken' => [$baseDir.'/composer_broken.lock', 'exception', 'translated (#4)'],
241			'composer.lock bundleless' => [$baseDir.'/composer_bundleless.lock', 'exception', 'translated'],
242			'composer.lock not found' => [$baseDir.'/composer_not_there.lock', 'exception', 'translated'],
243			];
244			}
245
246			private function getVersionChecker(ContainerInterface $container, AdapterInterface $cache, $translator)
247			{
248			return new VersionChecker($container, $cache, $translator);
249			}
250			}
251

Kunstmaan / KunstmaanBundlesCMS

Issues (3099)

Security Analysis not enabled

unit/Helper/VersionCheck/VersionCheckTest.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like