Kunstmaan / KunstmaanBundlesCMS

src/Kunstmaan/AdminBundle/EventListener/PasswordResettingListener.php

<?php

namespace Kunstmaan\AdminBundle\EventListener;

use FOS\UserBundle\Event\FilterUserResponseEvent;
use FOS\UserBundle\Model\UserManager as FOSUserManager;
use Kunstmaan\AdminBundle\Event\ChangePasswordSuccessEvent;
use Kunstmaan\AdminBundle\Service\UserManager;

/**
 * Set password_changed property to 1 after changing the password
 */
class PasswordResettingListener
{
    /**
     * @var UserManager
     */
    private $userManager;

    /**
     * @param UserManager $userManager
     */
    public function __construct(/* UserManager */ $userManager)

This method seems to be duplicated in your project.

    {
        if (!$userManager instanceof UserManager && !$userManager instanceof FOSUserManager) {
            throw new \InvalidArgumentException(sprintf('The "$userManager" argument must be of type "%s" or type "%s"', UserManager::class, FOSUserManager::class));
        }
        if ($userManager instanceof FOSUserManager) {
            // NEXT_MAJOR set the usermanaged typehint to the kunstmaan usermanager.
            @trigger_error(sprintf('Passing the usermanager from FOSUserBundle as the first argument of "%s" is deprecated since KunstmaanAdminBundle 5.8 and will be removed in KunstmaanAdminBundle 6.0. Use the "%s" class instead.', __METHOD__, UserManager::class), E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }
        $this->userManager = $userManager;
    }

    /**
     * @param FilterUserResponseEvent $event
     *
     * @deprecated Using the Fos FilterUserResponseEvent is deprecated in KunstmaanNodeBundle 5.8 and will be removed in KunstmaanNodeBundle 6.0. Use the "Kunstmaan\AdminBundle\Event\ ChangePasswordSuccessEvent" instead.
     */
    public function onPasswordResettingSuccess(FilterUserResponseEvent $event)
    {
        $user = $event->getUser();
        $user->setPasswordChanged(true);
        $this->userManager->updateUser($user);

$user of type object<FOS\UserBundle\Model\UserInterface> is not a sub-type of object<Kunstmaan\AdminBundle\Entity\UserInterface>. It seems like you assume a child interface of the interface FOS\UserBundle\Model\UserInterface to be always present.

    }

    public function onPasswordResettingSuccessCMS(ChangePasswordSuccessEvent $event)
    {
        $user = $event->getUser();
        $user->setPasswordChanged(true);

The method setPasswordChanged() does not exist on Kunstmaan\AdminBundle\Entity\UserInterface. Did you maybe mean setPassword()?

        $this->userManager->updateUser($user);
    }
}