View GitHub Repository KunstmaanBundlesCMS

Schedule Inspection
Subscribe
Completed
Pull Request — master (#2737)
by Jeroen
10:25
created

UseFosUserOptionCompilerPass::process()   A

↳ Parent: UseFosUserOptionCompilerPass

Complexity

Conditions 2
Paths 2

Size

Total Lines 11

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 9
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 11
ccs 9
cts 9
cp 1
rs 9.9
c 0
b 0
f 0
cc 2
nc 2
nop 1
crap 2
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Kunstmaan\AdminBundle\DependencyInjection\Compiler;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
use Symfony\Component\DependencyInjection\ContainerBuilder;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
class UseFosUserOptionCompilerPass implements CompilerPassInterface

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
{

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                             3                         
                
                
                
    public function process(ContainerBuilder $container)

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                             3                         
                
                
                
        $enableCustomLogin = $container->getParameter('kunstmaan_admin.enable_new_cms_authentication');

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                             3                         
                
                
                
        if (!$enableCustomLogin) {

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                             3                         
                
                
                
            @trigger_error('Using FosUserBundle routing and services is deprecated since KunstmaanAdminBundle 5.8 and will be removed in KunstmaanAdminBundle 6.0. Use our custom implementation instead', E_USER_DEPRECATED);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Security
            Best Practice
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
If you suppress an error, we recommend checking for the error condition explicitly:


// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}





                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                             3                         
                
                
                
            $container->setParameter('kunstmaan_admin.user_class', $container->getParameter('fos_user.model.user.class'));

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                             3                         
                
                
                
            $container->setParameter('kunstmaan_admin.group_class', $container->getParameter('fos_user.model.group.class'));

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                             3                         
                
                
                
            $container->setDefinition('kunstmaan_admin.user_manager', $container->getDefinition('fos_user.user_manager.default'));

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                             3                         
                
                
                
            $container->setDefinition('kunstmaan_admin.group_manager', $container->getDefinition('fos_user.group_manager.default'));

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                             3                         
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    22