Kunstmaan\AdminBundle\Event\ChangePasswordSuccessEvent

Complexity

Total Complexity

5

Size/Duplication

Total Lines	38
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	6	1
A	getUser()	4	4	1
A	getRequest()	4	4	1
A	getResponse()	4	4	1
A	setResponse()	4	4	1

<?php

namespace Kunstmaan\AdminBundle\Event;

use Kunstmaan\AdminBundle\Entity\UserInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

final class ChangePasswordSuccessEvent extends BcEvent

This class seems to be duplicated in your project.

{
    /** @var Request */
    private $request;

    /** @var UserInterface */
    private $user;

    /** @var Response */
    private $response;

    public function __construct(UserInterface $user, Request $request, Response $response)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->user = $user;
        $this->request = $request;
        $this->response = $response;
    }

    public function getUser(): UserInterface
    {
        return $this->user;
    }

    public function getRequest(): Request
    {
        return $this->request;
    }

    public function getResponse(): Response
    {
        return $this->response;
    }

    public function setResponse(Response $response)
    {
        $this->response = $response;
    }
}