Completed
Pull Request — 4.2 (#1936)
by
unknown
27:25
created
src/Kunstmaan/AdminListBundle/AdminList/ItemAction/SimpleItemAction.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     }
46 46
 
47 47
     /**
48
-     * @param mixed $item
48
+     * @param \stdClass $item
49 49
      *
50 50
      * @return string
51 51
      */
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param mixed $item
63
+     * @param \stdClass $item
64 64
      *
65 65
      * @return string
66 66
      */
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
     }
71 71
 
72 72
     /**
73
-     * @param mixed $item
73
+     * @param \stdClass $item
74 74
      *
75 75
      * @return string
76 76
      */
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Controller/AdminListController.php 1 patch
Doc Comments   +8 added lines, -5 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
     /**
32 32
      * You can override this method to return the correct entity manager when using multiple databases ...
33 33
      *
34
-     * @return \Doctrine\Common\Persistence\ObjectManager|object
34
+     * @return \Doctrine\Common\Persistence\ObjectManager
35 35
      */
36 36
     protected function getEntityManager()
37 37
     {
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
      * Shows the list of entities
43 43
      *
44 44
      * @param AbstractAdminListConfigurator $configurator
45
-     * @param null|Request $request
45
+     * @param Request $request
46 46
      *
47 47
      * @return Response
48 48
      */
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      *
95 95
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
96 96
      * @param string $type The type to add
97
-     * @param null|Request $request
97
+     * @param Request $request
98 98
      *
99 99
      * @throws AccessDeniedHttpException
100 100
      *
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
      *
198 198
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
199 199
      * @param string $entityId The id of the entity that will be edited
200
-     * @param null|Request $request
200
+     * @param Request $request
201 201
      *
202 202
      * @throws NotFoundHttpException
203 203
      * @throws AccessDeniedHttpException
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
      *
359 359
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
360 360
      * @param integer $entityId The id to delete
361
-     * @param null|Request $request
361
+     * @param Request $request
362 362
      *
363 363
      * @throws NotFoundHttpException
364 364
      * @throws AccessDeniedHttpException
@@ -479,6 +479,9 @@  discard block
 block discarded – undo
479 479
         );
480 480
     }
481 481
 
482
+    /**
483
+     * @param \Doctrine\Common\Persistence\ObjectRepository $repo
484
+     */
482 485
     private function getMaxSortableField($repo, $sort)
483 486
     {
484 487
         $maxWeight = $repo->createQueryBuilder('i')
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Controller/EntityLockCheckController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     /**
18 18
      * You can override this method to return the correct entity manager when using multiple databases ...
19 19
      *
20
-     * @return \Doctrine\Common\Persistence\ObjectManager|object
20
+     * @return \Doctrine\Common\Persistence\ObjectManager
21 21
      */
22 22
     protected function getEntityManager()
23 23
     {
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Entity/LockableEntity.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
     }
112 112
 
113 113
     /**
114
-     * @param $entityClass
114
+     * @param string $entityClass
115 115
      *
116 116
      * @return LockableEntity
117 117
      */
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     /**
136 136
      * Set integer
137 137
      *
138
-     * @param $entityId
138
+     * @param integer $entityId
139 139
      *
140 140
      * @return LockableEntity
141 141
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\ORM\Mapping as ORM;
6 6
 use Kunstmaan\AdminBundle\Entity\AbstractEntity;
7
-use Symfony\Component\Validator\Constraints as Assert;
8 7
 
9 8
 /**
10 9
  * @ORM\Entity(repositoryClass="Kunstmaan\AdminListBundle\Repository\LockableEntityRepository")
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Service/EntityVersionLockService.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,6 +26,10 @@  discard block
 block discarded – undo
26 26
      */
27 27
     private $lockEnabled;
28 28
 
29
+    /**
30
+     * @param integer $threshold
31
+     * @param boolean $lockEnabled
32
+     */
29 33
     public function __construct(ObjectManager $em, $threshold, $lockEnabled)
30 34
     {
31 35
         $this->setObjectManager($em);
@@ -138,7 +142,7 @@  discard block
 block discarded – undo
138 142
      *
139 143
      * @param LockableEntity $entity
140 144
      * @param User $userToExclude
141
-     * @return EntityVersionLock[]
145
+     * @return \Kunstmaan\AdminListBundle\Repository\EntityVersionLock[]
142 146
      */
143 147
     protected function getEntityVersionLocksByLockableEntity(LockableEntity $entity, User $userToExclude = null)
144 148
     {
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Service/ExportService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Box\Spout\Common\Type;
6 6
 use Box\Spout\Writer\WriterFactory;
7
-use Box\Spout\Writer\WriterInterface;
8 7
 use Kunstmaan\AdminListBundle\AdminList\ExportableInterface;
9 8
 use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
10 9
 use Symfony\Component\HttpFoundation\Response;
Please login to merge, or discard this patch.
AdminListBundle/Tests/AdminList/ItemAction/SimpleItemActionTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 namespace Kunstmaan\AdminListBundle\Tests\AdminList\ItemAction;
3 3
 
4 4
 use Kunstmaan\AdminListBundle\AdminList\ItemAction\SimpleItemAction;
5
-
6 5
 use stdClass;
7 6
 
8 7
 /**
Please login to merge, or discard this patch.
AdminListBundle/Tests/Model/TestLockableEntityInterfaceImplementation.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -11,6 +11,9 @@
 block discarded – undo
11 11
 {
12 12
    protected $id;
13 13
 
14
+   /**
15
+    * @param string $id
16
+    */
14 17
    public function __construct($id)
15 18
    {
16 19
        $this->setId($id);
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Twig/AdminListTwigExtension.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -5,8 +5,6 @@
 block discarded – undo
5 5
 use Kunstmaan\AdminListBundle\AdminList\AdminList;
6 6
 use Kunstmaan\AdminListBundle\Service\ExportService;
7 7
 use Symfony\Component\DependencyInjection\ContainerInterface;
8
-use Symfony\Component\Routing\CompiledRoute;
9
-use Symfony\Component\Routing\Router;
10 8
 
11 9
 /**
12 10
  * AdminListTwigExtension
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     /**
18 18
      * Returns a list of functions to add to the existing list.
19 19
      *
20
-     * @return array An array of functions
20
+     * @return \Twig_SimpleFunction[] An array of functions
21 21
      */
22 22
     public function getFunctions()
23 23
     {
Please login to merge, or discard this patch.