Issues in ConfigController.php - All Issues - Inspection of "Merge pull request #2215 from sandergo90/feature/t..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e62fa2...4391c3 )

by Kristof

created 2019-01-14 09:33 UTC

ConfigBundle/Controller/ConfigController.php (1 issue)

Labels

Bug 1

Severity

Sander Goossens 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\ConfigBundle\Controller;

use Doctrine\ORM\EntityManagerInterface;
use Kunstmaan\ConfigBundle\Entity\AbstractConfig;
use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\RouterInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * Class ConfigController
 */
class ConfigController
{
    /**
     * @var RouterInterface
     */
    private $router;

    /**
     * @var EngineInterface
     */
    private $templating;

    /**
     * @var AuthorizationCheckerInterface
     */
    private $authorizationChecker;

    /**
     * @var EntityManagerInterface
     */
    private $em;

    /**
     * @var array
     */
    private $configuration;

    /**
     * @var FormFactoryInterface
     */
    private $formFactory;

    /**
     * @param RouterInterface               $router
     * @param EngineInterface               $templating
     * @param AuthorizationCheckerInterface $authorizationChecker
     * @param EntityManagerInterface        $em
     * @param array                         $configuration
     * @param ContainerInterface            $container
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param FormFactoryInterface          $formFactory
     */
    public function __construct(
        RouterInterface $router,
        EngineInterface $templating,
        AuthorizationCheckerInterface $authorizationChecker,
        EntityManagerInterface $em,
        array $configuration,
        /* ContainerInterface $container, */
        /* FormFactoryInterface */ $formFactory
    ) {
        $this->router = $router;
        $this->templating = $templating;
        $this->authorizationChecker = $authorizationChecker;
        $this->em = $em;
        $this->configuration = $configuration;

        if (func_num_args() > 6) {
            @trigger_error(sprintf('Passing the "container" as the sixth argument in "%s" is deprecated in KunstmaanConfigBundle 5.1 and will be removed in KunstmaanConfigBundle 6.0. Remove the "container" argument from your service definition.', __METHOD__), E_USER_DEPRECATED);

            $this->formFactory = func_get_arg(6);

            return;
        }

        $this->formFactory = $formFactory;
    }

    /**
     * Generates the site config administration form and fills it with a default value if needed.
     *
     * @param Request $request
     * @param string  $internalName
     *
     * @return array|RedirectResponse
     */
    public function indexAction(Request $request, $internalName)
    {
        /**
         * @var AbstractConfig
         */
        $entity = $this->getConfigEntityByInternalName($internalName);
        $entityClass = get_class($entity);

        // Check if current user has permission for the site config.
        foreach ($entity->getRoles() as $role) {
            $this->checkPermission($role);
        }

        $repo = $this->em->getRepository($entityClass);
        $config = $repo->findOneBy(array());

        if (!$config) {
            $config = new $entityClass();
        }

        $form = $this->formFactory->create(
            $entity->getDefaultAdminType(),
            $config
        );

        if ($request->isMethod('POST')) {
            $form->handleRequest($request);

            if ($form->isSubmitted() && $form->isValid()) {
                $this->em->persist($config);
                $this->em->flush();

                return new RedirectResponse($this->router->generate('kunstmaanconfigbundle_default', array('internalName' => $internalName)));
            }
        }

        return $this->templating->renderResponse(
            '@KunstmaanConfig/Settings/configSettings.html.twig',
            array(
                'form' => $form->createView(),
            )
        );
    }

    /**
     * Get site config entity by a given internal name
     * If entity not found, throw new NotFoundHttpException()
     *
     * @param string $internalName
     *
     * @return AbstractConfig
     *
     * @throws NotFoundHttpException
     */
    private function getConfigEntityByInternalName($internalName)
    {
        foreach ($this->configuration['entities'] as $class) {
            /** @var AbstractConfig $entity */
            $entity = new $class();

            if ($entity->getInternalName() == $internalName) {
                return $entity;
            }
        }

        throw new NotFoundHttpException();
    }

    /**
     * Check permission
     *
     * @param string $roleToCheck
     *
     * @throws AccessDeniedException
     */
    private function checkPermission($roleToCheck = 'ROLE_SUPER_ADMIN')
    {
        if (false === $this->authorizationChecker->isGranted($roleToCheck)) {
            throw new AccessDeniedException();
        }
    }
}


1		<?php
2
3		namespace Kunstmaan\ConfigBundle\Controller;
4
5		use Doctrine\ORM\EntityManagerInterface;
6		use Kunstmaan\ConfigBundle\Entity\AbstractConfig;
7		use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
8		use Symfony\Component\DependencyInjection\ContainerInterface;
9		use Symfony\Component\Form\FormFactoryInterface;
10		use Symfony\Component\HttpFoundation\RedirectResponse;
11		use Symfony\Component\HttpFoundation\Request;
12		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
13		use Symfony\Component\Routing\RouterInterface;
14		use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
15		use Symfony\Component\Security\Core\Exception\AccessDeniedException;
16
17		/**
18		* Class ConfigController
19		*/
20		class ConfigController
21		{
22		/**
23		* @var RouterInterface
24		*/
25		private $router;
26
27		/**
28		* @var EngineInterface
29		*/
30		private $templating;
31
32		/**
33		* @var AuthorizationCheckerInterface
34		*/
35		private $authorizationChecker;
36
37		/**
38		* @var EntityManagerInterface
39		*/
40		private $em;
41
42		/**
43		* @var array
44		*/
45		private $configuration;
46
47		/**
48		* @var FormFactoryInterface
49		*/
50		private $formFactory;
51
52		/**
53		* @param RouterInterface $router
54		* @param EngineInterface $templating
55		* @param AuthorizationCheckerInterface $authorizationChecker
56		* @param EntityManagerInterface $em
57		* @param array $configuration
58		* @param ContainerInterface $container
		0 ignored issues – show Bug introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$container`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
59		* @param FormFactoryInterface $formFactory
60		*/
61		public function __construct(
62		RouterInterface $router,
63		EngineInterface $templating,
64		AuthorizationCheckerInterface $authorizationChecker,
65		EntityManagerInterface $em,
66		array $configuration,
67		/* ContainerInterface $container, */
68		/* FormFactoryInterface */ $formFactory
69		) {
70		$this->router = $router;
71		$this->templating = $templating;
72		$this->authorizationChecker = $authorizationChecker;
73		$this->em = $em;
74		$this->configuration = $configuration;
75
76	View Code Duplication	if (func_num_args() > 6) {
77		@trigger_error(sprintf('Passing the "container" as the sixth argument in "%s" is deprecated in KunstmaanConfigBundle 5.1 and will be removed in KunstmaanConfigBundle 6.0. Remove the "container" argument from your service definition.', __METHOD__), E_USER_DEPRECATED);
78
79		$this->formFactory = func_get_arg(6);
80
81		return;
82		}
83
84		$this->formFactory = $formFactory;
85		}
86
87		/**
88		* Generates the site config administration form and fills it with a default value if needed.
89		*
90		* @param Request $request
91		* @param string $internalName
92		*
93		* @return array\|RedirectResponse
94		*/
95		public function indexAction(Request $request, $internalName)
96		{
97		/**
98		* @var AbstractConfig
99		*/
100		$entity = $this->getConfigEntityByInternalName($internalName);
101		$entityClass = get_class($entity);
102
103		// Check if current user has permission for the site config.
104		foreach ($entity->getRoles() as $role) {
105		$this->checkPermission($role);
106		}
107
108		$repo = $this->em->getRepository($entityClass);
109		$config = $repo->findOneBy(array());
110
111		if (!$config) {
112		$config = new $entityClass();
113		}
114
115		$form = $this->formFactory->create(
116		$entity->getDefaultAdminType(),
117		$config
118		);
119
120		if ($request->isMethod('POST')) {
121		$form->handleRequest($request);
122
123		if ($form->isSubmitted() && $form->isValid()) {
124		$this->em->persist($config);
125		$this->em->flush();
126
127		return new RedirectResponse($this->router->generate('kunstmaanconfigbundle_default', array('internalName' => $internalName)));
128		}
129		}
130
131		return $this->templating->renderResponse(
132		'@KunstmaanConfig/Settings/configSettings.html.twig',
133		array(
134		'form' => $form->createView(),
135		)
136		);
137		}
138
139		/**
140		* Get site config entity by a given internal name
141		* If entity not found, throw new NotFoundHttpException()
142		*
143		* @param string $internalName
144		*
145		* @return AbstractConfig
146		*
147		* @throws NotFoundHttpException
148		*/
149		private function getConfigEntityByInternalName($internalName)
150		{
151		foreach ($this->configuration['entities'] as $class) {
152		/** @var AbstractConfig $entity */
153		$entity = new $class();
154
155		if ($entity->getInternalName() == $internalName) {
156		return $entity;
157		}
158		}
159
160		throw new NotFoundHttpException();
161		}
162
163		/**
164		* Check permission
165		*
166		* @param string $roleToCheck
167		*
168		* @throws AccessDeniedException
169		*/
170		private function checkPermission($roleToCheck = 'ROLE_SUPER_ADMIN')
171		{
172		if (false === $this->authorizationChecker->isGranted($roleToCheck)) {
173		throw new AccessDeniedException();
174		}
175		}
176		}
177

Kunstmaan / KunstmaanBundlesCMS

Push — master ( e62fa2...4391c3 )

ConfigBundle/Controller/ConfigController.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like