Issues in DomainConfiguration.php - All Issues - Inspection of "Merge pull request #2215 from sandergo90/feature/t..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e62fa2...4391c3 )

by Kristof

created 2019-01-14 09:33 UTC

AdminBundle/Helper/DomainConfiguration.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Helper;

use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\RequestStack;

/**
 * Class DomainConfiguration
 *
 * Default (single domain) configuration handling
 */
class DomainConfiguration implements DomainConfigurationInterface
{
    /** @var ContainerInterface */
    protected $container;

    /** @var RequestStack */
    private $requestStack;

    /** @var bool */
    protected $multiLanguage;

    /** @var array */
    protected $requiredLocales;

    /** @var string */
    protected $defaultLocale;

    /**
     * @param ContainerInterface|string $multilanguage

     */
    public function __construct(/*ContainerInterface|RequestStack*/ $requestStack, $multilanguage = null, $defaultLocale = null, $requiredLocales = null)

    {
        if ($requestStack instanceof ContainerInterface) {
            @trigger_error('Container injection and the usage of the container is deprecated in KunstmaanNodeBundle 5.1 and will be removed in KunstmaanNodeBundle 6.0.', E_USER_DEPRECATED);

            $this->container = $requestStack;
            $this->multiLanguage = $this->container->getParameter(
                'multilanguage'
            );
            $this->defaultLocale = $this->container->getParameter(
                'defaultlocale'
            );
            $this->requiredLocales = explode(
                '|',
                $this->container->getParameter('requiredlocales')
            );
            $this->requestStack = $this->container->get('request_stack');

            return;
        }

        $this->requestStack = $requestStack;
        $this->multiLanguage = $multilanguage;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->defaultLocale = $defaultLocale;

        $this->requiredLocales = explode('|', $requiredLocales);
    }

    /**
     * @return string
     */
    public function getHost()
    {
        $request = $this->getMasterRequest();
        $host = is_null($request) ? '' : $request->getHost();

        return $host;
    }

    /**
     * @return array
     */
    public function getHosts()
    {
        return array($this->getHost());
    }

    /**
     * @return string
     */
    public function getDefaultLocale()
    {
        return $this->defaultLocale;
    }

    /**
     * @param string|null $host
     *
     * @return bool
     */
    public function isMultiLanguage($host = null)
    {
        return $this->multiLanguage;
    }

    /**
     * @param string|null $host
     *
     * @return array
     */
    public function getFrontendLocales($host = null)
    {
        return $this->requiredLocales;
    }

    /**
     * @param string|null $host
     *
     * @return array
     */
    public function getBackendLocales($host = null)
    {
        return $this->requiredLocales;
    }

    /**
     * @return bool
     */
    public function isMultiDomainHost()
    {
        return false;
    }

    /**
     * @param string|null $host
     */
    public function getRootNode($host = null)
    {
        return null;
    }

    /**
     * @return array
     */
    public function getExtraData()
    {
        return array();
    }

    /**
     * @return array
     */
    public function getLocalesExtraData()
    {
        return array();
    }

    /**
     * @return null|\Symfony\Component\HttpFoundation\Request
     */
    protected function getMasterRequest()
    {
        return $this->requestStack->getMasterRequest();
    }

    /**
     * @return array
     */
    public function getFullHostConfig()
    {
        return array();
    }

    /**
     * @param string|null $host
     */
    public function getFullHost($host = null)
    {
        return null;
    }

    /**
     * @param int $id
     */
    public function getFullHostById($id)
    {
        return null;
    }

    public function getHostSwitched()
    {
        return null;
    }

    /**
     * @param string|null $host
     */
    public function getHostBaseUrl($host = null)
    {
        return null;
    }
}


1		<?php
2
3		namespace Kunstmaan\AdminBundle\Helper;
4
5		use Symfony\Component\DependencyInjection\ContainerInterface;
6		use Symfony\Component\HttpFoundation\RequestStack;
7
8		/**
9		* Class DomainConfiguration
10		*
11		* Default (single domain) configuration handling
12		*/
13		class DomainConfiguration implements DomainConfigurationInterface
14		{
15		/** @var ContainerInterface */
16		protected $container;
17
18		/** @var RequestStack */
19		private $requestStack;
20
21		/** @var bool */
22		protected $multiLanguage;
23
24		/** @var array */
25		protected $requiredLocales;
26
27		/** @var string */
28		protected $defaultLocale;
29
30		/**
31		* @param ContainerInterface\|string $multilanguage
		0 ignored issues – show Documentation introduced 2018-06-04 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$multilanguage` not be `ContainerInterface\|string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
32		*/
33	View Code Duplication	public function __construct(/ContainerInterface\|RequestStack/ $requestStack, $multilanguage = null, $defaultLocale = null, $requiredLocales = null)
		0 ignored issues – show Duplication introduced 2018-06-04 15:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		if ($requestStack instanceof ContainerInterface) {
36		@trigger_error('Container injection and the usage of the container is deprecated in KunstmaanNodeBundle 5.1 and will be removed in KunstmaanNodeBundle 6.0.', E_USER_DEPRECATED);
37
38		$this->container = $requestStack;
39		$this->multiLanguage = $this->container->getParameter(
40		'multilanguage'
41		);
42		$this->defaultLocale = $this->container->getParameter(
43		'defaultlocale'
44		);
45		$this->requiredLocales = explode(
46		'\|',
47		$this->container->getParameter('requiredlocales')
48		);
49		$this->requestStack = $this->container->get('request_stack');
50
51		return;
52		}
53
54		$this->requestStack = $requestStack;
55		$this->multiLanguage = $multilanguage;
		0 ignored issues – show Documentation Bug introduced 2018-06-04 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$multilanguage` can also be of type `object<Symfony\Component...ion\ContainerInterface>` or `string`. However, the property `$multiLanguage` is declared as type `boolean`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
56		$this->defaultLocale = $defaultLocale;
57
58		$this->requiredLocales = explode('\|', $requiredLocales);
59		}
60
61		/**
62		* @return string
63		*/
64		public function getHost()
65		{
66		$request = $this->getMasterRequest();
67		$host = is_null($request) ? '' : $request->getHost();
68
69		return $host;
70		}
71
72		/**
73		* @return array
74		*/
75		public function getHosts()
76		{
77		return array($this->getHost());
78		}
79
80		/**
81		* @return string
82		*/
83		public function getDefaultLocale()
84		{
85		return $this->defaultLocale;
86		}
87
88		/**
89		* @param string\|null $host
90		*
91		* @return bool
92		*/
93		public function isMultiLanguage($host = null)
94		{
95		return $this->multiLanguage;
96		}
97
98		/**
99		* @param string\|null $host
100		*
101		* @return array
102		*/
103		public function getFrontendLocales($host = null)
104		{
105		return $this->requiredLocales;
106		}
107
108		/**
109		* @param string\|null $host
110		*
111		* @return array
112		*/
113		public function getBackendLocales($host = null)
114		{
115		return $this->requiredLocales;
116		}
117
118		/**
119		* @return bool
120		*/
121		public function isMultiDomainHost()
122		{
123		return false;
124		}
125
126		/**
127		* @param string\|null $host
128		*/
129		public function getRootNode($host = null)
130		{
131		return null;
132		}
133
134		/**
135		* @return array
136		*/
137		public function getExtraData()
138		{
139		return array();
140		}
141
142		/**
143		* @return array
144		*/
145		public function getLocalesExtraData()
146		{
147		return array();
148		}
149
150		/**
151		* @return null\|\Symfony\Component\HttpFoundation\Request
152		*/
153		protected function getMasterRequest()
154		{
155		return $this->requestStack->getMasterRequest();
156		}
157
158		/**
159		* @return array
160		*/
161		public function getFullHostConfig()
162		{
163		return array();
164		}
165
166		/**
167		* @param string\|null $host
168		*/
169		public function getFullHost($host = null)
170		{
171		return null;
172		}
173
174		/**
175		* @param int $id
176		*/
177		public function getFullHostById($id)
178		{
179		return null;
180		}
181
182		public function getHostSwitched()
183		{
184		return null;
185		}
186
187		/**
188		* @param string\|null $host
189		*/
190		public function getHostBaseUrl($host = null)
191		{
192		return null;
193		}
194		}
195

Kunstmaan / KunstmaanBundlesCMS

Push — master ( e62fa2...4391c3 )

AdminBundle/Helper/DomainConfiguration.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like