Kunstmaan / KunstmaanBundlesCMS

src/Kunstmaan/AdminBundle/Twig/MultiDomainAdminTwigExtension.php

<?php

namespace Kunstmaan\AdminBundle\Twig;

use Kunstmaan\AdminBundle\Helper\DomainConfigurationInterface;

class MultiDomainAdminTwigExtension extends \Twig_Extension
{
    /**
     * @var DomainConfigurationInterface
     */
    private $domainConfiguration;

    public function __construct(DomainConfigurationInterface $domainConfiguration)
    {
        $this->domainConfiguration = $domainConfiguration;
    }


    /**
     * Get Twig functions defined in this extension.
     *
     * @return array

Consider making the return type a bit more specific; maybe use \Twig_SimpleFunction[].

     */
    public function getFunctions()
    {
        return array(
            new \Twig_SimpleFunction('multidomain_widget', array($this, 'renderWidget'), array('needs_environment' => true, 'is_safe' => array('html'))),
            new \Twig_SimpleFunction('is_multidomain_site', array($this, 'isMultiDomainSite')),
            new \Twig_SimpleFunction('get_switched_host', array($this, 'getSwitchedHost')),
            new \Twig_SimpleFunction('switched_host_is_current', array($this, 'switchedHostIsCurrent')),
        );
    }

    /**
     * Render multidomain switcher widget.
     *
     * @param \Twig_Environment $env
     * @param array             $locales    The locales

There is no parameter named $locales. Was it maybe removed?

     * @param string            $route      The route
     * @param array             $parameters The route parameters
     *
     * @return string
     */
    public function renderWidget(\Twig_Environment $env, $route, array $parameters = array())

This method seems to be duplicated in your project.

    {
        $template = $env->loadTemplate(
            "@KunstmaanAdmin/MultiDomainAdminTwigExtension/widget.html.twig"
        );

        return $template->render(
            array_merge(
                $parameters,
                array(
                    'hosts' => $this->getAdminDomainHosts(),
                    'route' => $route
                )
            )
        );
    }

    /**
     * Check if site is multiDomain
     *
     * @return bool
     */
    public function isMultiDomainSite()
    {
        return $this->domainConfiguration->isMultiDomainHost();
    }

    /**
     * @return string
     */
    public function getSwitchedHost()
    {
        return $this->domainConfiguration->getHostSwitched();
    }

    /**
     * @return string

Should the return type not be boolean?

     */
    public function switchedHostIsCurrent()
    {
        return $this->domainConfiguration->getHost() == $this->getSwitchedHost()['host'];
    }

    public function getAdminDomainHosts()
    {
        return $this->domainConfiguration->getHosts();
    }
}