Kunstmaan\AdminBundle\Tests\Helper\Security\Acl\OAuthUserFinderTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getEm()	0	8	2
A	testFindUserByGoogleSignInData()	0	9	1
A	setUp()	0	6	1

<?php

namespace Kunstmaan\AdminBundle\Tests\Helper\Security\Acl;

use DateTime;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Kunstmaan\AdminBundle\Entity\User;
use Kunstmaan\AdminBundle\Helper\Security\OAuth\OAuthUserFinder;
use PHPUnit\Framework\TestCase;

class OAuthUserFinderTest extends TestCase
{
    /**
     * @var OAuthUserFinder
     */
    private $object;

    /**
     * @var EntityManager
     */
    private $em;

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject

Should the return type not be \PHPUnit\Framework\MockObject\MockObject|EntityManager?

     */
    private function getEm()
    {
        if (!isset($this->em)) {
            $this->em = $this->createMock(EntityManager::class);

It seems like $this->createMock(\Doctrine\ORM\EntityManager::class) of type object<PHPUnit\Framework\MockObject\MockObject> is incompatible with the declared type object<Doctrine\ORM\EntityManager> of property $em.

        }

        return $this->em;
    }

    public function setUp(): void
    {
        $em = $this->getEm();
        $object = new OAuthUserFinder($em, User::class);

It seems like $em defined by $this->getEm() on line 38 can also be of type object<PHPUnit\Framework\MockObject\MockObject>; however, Kunstmaan\AdminBundle\Helper\Security\OAuth\OAuthUserFinder::__construct() does only seem to accept object<Doctrine\ORM\EntityManagerInterface>, maybe add an additional type check?

        $this->object = $object;
    }

    public function testFindUserByGoogleSignInData()
    {
        $object = $this->object;
        $repo = $this->createMock(EntityRepository::class);
        $repo->expects($this->exactly(3))->method('findOneBy')->will($this->onConsecutiveCalls(new DateTime(), new DateTime(), new User()));
        $this->getEm()->expects($this->exactly(3))->method('getRepository')->willReturn($repo);

The method expects does only exist in PHPUnit\Framework\MockObject\MockObject, but not in Doctrine\ORM\EntityManager.

        $user = $object->findUserByGoogleSignInData('someone@gmail.com', 12345679);
        $this->assertInstanceOf(User::class, $user);
    }
}