Issues in ACLPermissionCreatorTest.php - All Issues - Inspection of "Update changelog for 5.3.5 release" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ba8ed9...770316 )

by Jeroen

created 2019-10-18 12:57 UTC

unit/Helper/Creators/ACLPermissionCreatorTest.php (4 issues)

Labels

Documentation 4

Severity

Minor 4

Ruud Denivel 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Tests\Helper\Creators;

use Kunstmaan\AdminBundle\Entity\User;
use Kunstmaan\AdminBundle\Helper\Creators\ACLPermissionCreator;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Security\Acl\Domain\RoleSecurityIdentity;
use Symfony\Component\Security\Acl\Exception\AclNotFoundException;
use Symfony\Component\Security\Acl\Model\EntryInterface;
use Symfony\Component\Security\Acl\Model\MutableAclInterface;
use Symfony\Component\Security\Acl\Model\MutableAclProviderInterface;
use Symfony\Component\Security\Acl\Model\ObjectIdentityInterface;
use Symfony\Component\Security\Acl\Model\ObjectIdentityRetrievalStrategyInterface;

/**
 * Class ACLPermissionCreatorTest
 */
class ACLPermissionCreatorTest extends TestCase
{
    public function testInitByExample()
    {
        $security = new RoleSecurityIdentity('ADMIN');
        $entry = $this->createMock(EntryInterface::class);
        $user = $this->createMock(ObjectIdentityInterface::class);
        $provider = $this->createMock(MutableAclProviderInterface::class);
        $strategy = $this->createMock(ObjectIdentityRetrievalStrategyInterface::class);
        $mutableAcl = $this->createMock(MutableAclInterface::class);

        $entry->expects($this->once())->method('getSecurityIdentity')->willReturn($security);
        $mutableAcl->expects($this->once())->method('getObjectAces')->willReturn([$entry]);
        $strategy->expects($this->exactly(2))->method('getObjectIdentity')->willReturn($user);
        $provider->expects($this->once())->method('findAcl')->willReturn($mutableAcl);
        $provider->expects($this->once())->method('createAcl')->willReturn($mutableAcl);
        $provider->expects($this->once())->method('updateAcl')->willReturn($mutableAcl);

        $aclCreator = new ACLPermissionCreator($provider, $strategy);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $aclCreator->initByExample($user, new User(), true);
    }

    public function testInitByMap()
    {
        $user = $this->createMock(ObjectIdentityInterface::class);
        $provider = $this->createMock(MutableAclProviderInterface::class);
        $strategy = $this->createMock(ObjectIdentityRetrievalStrategyInterface::class);
        $mutableAcl = $this->createMock(MutableAclInterface::class);

        $strategy->expects($this->once())->method('getObjectIdentity')->willReturn($user);
        $provider->expects($this->once())->method('createAcl')->willReturn($mutableAcl);
        $provider->expects($this->once())->method('updateAcl')->willReturn($mutableAcl);
        $provider->expects($this->once())->method('deleteAcl')->willThrowException(new AclNotFoundException());

        $aclCreator = new ACLPermissionCreator($provider, $strategy);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $aclCreator->initByMap($user, ['key' => 'value'], true);
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminBundle\Tests\Helper\Creators;
4
5			use Kunstmaan\AdminBundle\Entity\User;
6			use Kunstmaan\AdminBundle\Helper\Creators\ACLPermissionCreator;
7			use PHPUnit\Framework\TestCase;
8			use Symfony\Component\Security\Acl\Domain\RoleSecurityIdentity;
9			use Symfony\Component\Security\Acl\Exception\AclNotFoundException;
10			use Symfony\Component\Security\Acl\Model\EntryInterface;
11			use Symfony\Component\Security\Acl\Model\MutableAclInterface;
12			use Symfony\Component\Security\Acl\Model\MutableAclProviderInterface;
13			use Symfony\Component\Security\Acl\Model\ObjectIdentityInterface;
14			use Symfony\Component\Security\Acl\Model\ObjectIdentityRetrievalStrategyInterface;
15
16			/**
17			* Class ACLPermissionCreatorTest
18			*/
19			class ACLPermissionCreatorTest extends TestCase
20			{
21			public function testInitByExample()
22			{
23			$security = new RoleSecurityIdentity('ADMIN');
24			$entry = $this->createMock(EntryInterface::class);
25			$user = $this->createMock(ObjectIdentityInterface::class);
26			$provider = $this->createMock(MutableAclProviderInterface::class);
27			$strategy = $this->createMock(ObjectIdentityRetrievalStrategyInterface::class);
28			$mutableAcl = $this->createMock(MutableAclInterface::class);
29
30			$entry->expects($this->once())->method('getSecurityIdentity')->willReturn($security);
31			$mutableAcl->expects($this->once())->method('getObjectAces')->willReturn([$entry]);
32			$strategy->expects($this->exactly(2))->method('getObjectIdentity')->willReturn($user);
33			$provider->expects($this->once())->method('findAcl')->willReturn($mutableAcl);
34			$provider->expects($this->once())->method('createAcl')->willReturn($mutableAcl);
35			$provider->expects($this->once())->method('updateAcl')->willReturn($mutableAcl);
36
37			$aclCreator = new ACLPermissionCreator($provider, $strategy);
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$provider` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...leAclProviderInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$strategy` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...ievalStrategyInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38			$aclCreator->initByExample($user, new User(), true);
39			}
40
41			public function testInitByMap()
42			{
43			$user = $this->createMock(ObjectIdentityInterface::class);
44			$provider = $this->createMock(MutableAclProviderInterface::class);
45			$strategy = $this->createMock(ObjectIdentityRetrievalStrategyInterface::class);
46			$mutableAcl = $this->createMock(MutableAclInterface::class);
47
48			$strategy->expects($this->once())->method('getObjectIdentity')->willReturn($user);
49			$provider->expects($this->once())->method('createAcl')->willReturn($mutableAcl);
50			$provider->expects($this->once())->method('updateAcl')->willReturn($mutableAcl);
51			$provider->expects($this->once())->method('deleteAcl')->willThrowException(new AclNotFoundException());
52
53			$aclCreator = new ACLPermissionCreator($provider, $strategy);
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$provider` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...leAclProviderInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$strategy` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...ievalStrategyInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54			$aclCreator->initByMap($user, ['key' => 'value'], true);
55			}
56			}
57

Kunstmaan / KunstmaanBundlesCMS

Push — master ( ba8ed9...770316 )

unit/Helper/Creators/ACLPermissionCreatorTest.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like