Issues in MigrationsDiffCommand.php - All Issues - Inspection of "Merge branch '5.6'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae5e03...0447ee )

by Jeroen

created 2020-08-07 09:00 UTC

TranslatorBundle/Command/MigrationsDiffCommand.php (1 issue)

Showing only issues like (Show All)

mismatching argument types.

Documentation Minor

Joeri Verdeyen 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\TranslatorBundle\Command;

use Doctrine\Bundle\DoctrineBundle\Command\Proxy\DoctrineCommandHelper;
use Doctrine\Bundle\MigrationsBundle\Command\DoctrineCommand;
use Kunstmaan\TranslatorBundle\Service\Command\DiffCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Command for generate migration classes by checking the translation flag value
 *
 * @final since 5.1
 *
 * @deprecated This class is deprecated since KunstmaanTranslatorBundle 5.2 and will be removed in 6.0.
 */
class MigrationsDiffCommand extends DiffCommand
{
    protected function configure()
    {
        parent::configure();

        $this
            ->setName('kuma:translator:migrations:diff')
            ->addOption('em', null, InputOption::VALUE_OPTIONAL, 'The entity manager to use for this command.')
        ;
    }

    public function execute(InputInterface $input, OutputInterface $output)
    {
        DoctrineCommandHelper::setApplicationEntityManager($this->getApplication(), $input->getOption('em'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $configuration = $this->getMigrationConfiguration($input, $output);
        DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);

        $exitCode = parent::execute($input, $output);

        return is_numeric($exitCode) ? (int) $exitCode : 0;
    }
}


1			<?php
2
3			namespace Kunstmaan\TranslatorBundle\Command;
4
5			use Doctrine\Bundle\DoctrineBundle\Command\Proxy\DoctrineCommandHelper;
6			use Doctrine\Bundle\MigrationsBundle\Command\DoctrineCommand;
7			use Kunstmaan\TranslatorBundle\Service\Command\DiffCommand;
8			use Symfony\Component\Console\Input\InputInterface;
9			use Symfony\Component\Console\Input\InputOption;
10			use Symfony\Component\Console\Output\OutputInterface;
11
12			/**
13			* Command for generate migration classes by checking the translation flag value
14			*
15			* @final since 5.1
16			*
17			* @deprecated This class is deprecated since KunstmaanTranslatorBundle 5.2 and will be removed in 6.0.
18			*/
19			class MigrationsDiffCommand extends DiffCommand
20			{
21			protected function configure()
22			{
23			parent::configure();
24
25			$this
26			->setName('kuma:translator:migrations:diff')
27			->addOption('em', null, InputOption::VALUE_OPTIONAL, 'The entity manager to use for this command.')
28			;
29			}
30
31			public function execute(InputInterface $input, OutputInterface $output)
32			{
33			DoctrineCommandHelper::setApplicationEntityManager($this->getApplication(), $input->getOption('em'));
			0 ignored issues – show Documentation introduced 2019-09-09 19:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->getApplication()` is of type `null\|object<Symfony\Comp...nt\Console\Application>`, but the function expects a `object<Symfony\Bundle\Fr...le\Console\Application>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34
35			$configuration = $this->getMigrationConfiguration($input, $output);
36			DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
37
38			$exitCode = parent::execute($input, $output);
39
40			return is_numeric($exitCode) ? (int) $exitCode : 0;
41			}
42			}
43

Kunstmaan / KunstmaanBundlesCMS

Push — master ( ae5e03...0447ee )

TranslatorBundle/Command/MigrationsDiffCommand.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like