Issues in KunstmaanNodeExtension.php - All Issues - Inspection of "Merge branch '5.6'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae5e03...0447ee )

by Jeroen

created 2020-08-07 09:00 UTC

DependencyInjection/KunstmaanNodeExtension.php (1 issue)

Labels

Severity

Informational 1

Danny van Wijk 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\NodeBundle\DependencyInjection;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
use Symfony\Component\DependencyInjection\Loader;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;

/**
 * This is the class that loads and manages your bundle configuration
 *
 * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
 */
class KunstmaanNodeExtension extends Extension implements PrependExtensionInterface
{
    /**
     * {@inheritdoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $configuration = new Configuration();
        $config = $this->processConfiguration($configuration, $configs);

        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));

        $container->setParameter('twig.form.resources', array_merge(
            $container->getParameter('twig.form.resources'),
            ['@KunstmaanNode/Form/formWidgets.html.twig']
        ));

        $nodePagesDefinition = new Definition('Kunstmaan\NodeBundle\Helper\PagesConfiguration', [$config['pages']]);
        $nodePagesDefinition->setPublic(true);
        $container->setDefinition('kunstmaan_node.pages_configuration', $nodePagesDefinition);

        $container->setParameter('kunstmaan_node.permissions.enabled', $config['enable_permissions']);
        $container->setParameter('kunstmaan_node.show_add_homepage', $config['show_add_homepage']);
        $container->setParameter('kunstmaan_node.show_duplicate_with_children', $config['show_duplicate_with_children']);
        $container->setParameter('kunstmaan_node.enable_export_page_template', $config['enable_export_page_template']);
        $container->setParameter('kunstmaan_node.lock_check_interval', $config['lock']['check_interval']);
        $container->setParameter('kunstmaan_node.lock_threshold', $config['lock']['threshold']);
        $container->setParameter('kunstmaan_node.lock_enabled', $config['lock']['enabled']);

        $loader->load('services.yml');
        $loader->load('commands.yml');
    }

    public function prepend(ContainerBuilder $container)
    {
        $cmfRoutingExtraConfig['chain']['routers_by_id']['router.default'] = 100;
        $cmfRoutingExtraConfig['chain']['replace_symfony_router'] = true;
        $container->prependExtensionConfig('cmf_routing', $cmfRoutingExtraConfig);

        $configs = $container->getExtensionConfig($this->getAlias());
        $config = $this->processConfiguration(new Configuration(), $configs);

        // set twig global params
        $twigConfig['globals']['nodebundleisactive'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $twigConfig['globals']['publish_later_stepping'] = $config['publish_later_stepping'];
        $twigConfig['globals']['unpublish_later_stepping'] = $config['unpublish_later_stepping'];
        $container->prependExtensionConfig('twig', $twigConfig);
    }
}


1		<?php
2
3		namespace Kunstmaan\NodeBundle\DependencyInjection;
4
5		use Symfony\Component\Config\FileLocator;
6		use Symfony\Component\DependencyInjection\ContainerBuilder;
7		use Symfony\Component\DependencyInjection\Definition;
8		use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
9		use Symfony\Component\DependencyInjection\Loader;
10		use Symfony\Component\HttpKernel\DependencyInjection\Extension;
11
12		/**
13		* This is the class that loads and manages your bundle configuration
14		*
15		* To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
16		*/
17		class KunstmaanNodeExtension extends Extension implements PrependExtensionInterface
18		{
19		/**
20		* {@inheritdoc}
21		*/
22	1	public function load(array $configs, ContainerBuilder $container)
23		{
24	1	$configuration = new Configuration();
25	1	$config = $this->processConfiguration($configuration, $configs);
26
27	1	$loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
28
29	1	$container->setParameter('twig.form.resources', array_merge(
30	1	$container->getParameter('twig.form.resources'),
31	1	['@KunstmaanNode/Form/formWidgets.html.twig']
32		));
33
34	1	$nodePagesDefinition = new Definition('Kunstmaan\NodeBundle\Helper\PagesConfiguration', [$config['pages']]);
35	1	$nodePagesDefinition->setPublic(true);
36	1	$container->setDefinition('kunstmaan_node.pages_configuration', $nodePagesDefinition);
37
38	1	$container->setParameter('kunstmaan_node.permissions.enabled', $config['enable_permissions']);
39	1	$container->setParameter('kunstmaan_node.show_add_homepage', $config['show_add_homepage']);
40	1	$container->setParameter('kunstmaan_node.show_duplicate_with_children', $config['show_duplicate_with_children']);
41	1	$container->setParameter('kunstmaan_node.enable_export_page_template', $config['enable_export_page_template']);
42	1	$container->setParameter('kunstmaan_node.lock_check_interval', $config['lock']['check_interval']);
43	1	$container->setParameter('kunstmaan_node.lock_threshold', $config['lock']['threshold']);
44	1	$container->setParameter('kunstmaan_node.lock_enabled', $config['lock']['enabled']);
45
46	1	$loader->load('services.yml');
47	1	$loader->load('commands.yml');
48	1	}
49
50	1	public function prepend(ContainerBuilder $container)
51		{
52	1	$cmfRoutingExtraConfig['chain']['routers_by_id']['router.default'] = 100;
53	1	$cmfRoutingExtraConfig['chain']['replace_symfony_router'] = true;
54	1	$container->prependExtensionConfig('cmf_routing', $cmfRoutingExtraConfig);
55
56	1	$configs = $container->getExtensionConfig($this->getAlias());
57	1	$config = $this->processConfiguration(new Configuration(), $configs);
58
59		// set twig global params
60	1	$twigConfig['globals']['nodebundleisactive'] = true;
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$twigConfig` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$twigConfig = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
61	1	$twigConfig['globals']['publish_later_stepping'] = $config['publish_later_stepping'];
62	1	$twigConfig['globals']['unpublish_later_stepping'] = $config['unpublish_later_stepping'];
63	1	$container->prependExtensionConfig('twig', $twigConfig);
64	1	}
65		}
66

Kunstmaan / KunstmaanBundlesCMS

Push — master ( ae5e03...0447ee )

DependencyInjection/KunstmaanNodeExtension.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like