Issues in MediaManager.php - All Issues - Inspection of "Merge branch '5.6'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae5e03...0447ee )

by Jeroen

created 2020-08-07 09:00 UTC

src/Kunstmaan/MediaBundle/Helper/MediaManager.php (4 issues)

Labels

Severity

Kris Pypen 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\MediaBundle\Helper;

use Kunstmaan\MediaBundle\Entity\Media;
use Kunstmaan\MediaBundle\Helper\Media\AbstractMediaHandler;
use Symfony\Component\HttpFoundation\File\File;

/**
 * MediaManager
 */
class MediaManager
{
    /**
     * @var AbstractMediaHandler[]
     */
    protected $handlers = array();

    /**
     * @var AbstractMediaHandler
     */
    protected $defaultHandler;

    /**
     * @param AbstractMediaHandler $handler Media handler
     *
     * @return MediaManager
     */
    public function addHandler(AbstractMediaHandler $handler)
    {
        $this->handlers[$handler->getName()] = $handler;

        return $this;
    }

    /**
     * @param AbstractMediaHandler $handler Media handler
     *
     * @return MediaManager
     */
    public function setDefaultHandler(AbstractMediaHandler $handler)
    {
        $this->defaultHandler = $handler;

        return $this;
    }

    /**
     * Returns handler with the highest priority to handle the Media item which can handle the item. If no handler is found, it returns FileHandler
     *
     * @param Media|File $media
     *
     * @return AbstractMediaHandler
     */
    public function getHandler($media)

    {
        $bestHandler = $this->defaultHandler;
        foreach ($this->handlers as $handler) {
            if ($handler->canHandle($media) && $handler->getPriority() > $bestHandler->getPriority()) {
                $bestHandler = $handler;
            }
        }

        return $bestHandler;
    }

    /**
     * Returns handler with the highest priority to handle the Media item based on the Type. If no handler is found, it returns FileHandler
     *
     * @param string $type
     *
     * @return AbstractMediaHandler
     */
    public function getHandlerForType($type)

    {
        $bestHandler = $this->defaultHandler;
        foreach ($this->handlers as $handler) {
            if ($handler->getType() == $type && $handler->getPriority() > $bestHandler->getPriority()) {
                $bestHandler = $handler;
            }
        }

        return $bestHandler;
    }

    /**
     * @return AbstractMediaHandler[]
     */
    public function getHandlers()
    {
        return $this->handlers;
    }

    /**
     * @param \Kunstmaan\MediaBundle\Entity\Media $media
     *
     * @return MediaManager
     */
    public function prepareMedia(Media $media)
    {
        $handler = $this->getHandler($media);
        $handler->prepareMedia($media);

        return $this;
    }

    /**
     * @param Media $media The media
     * @param bool  $new   Is new
     */
    public function saveMedia(Media $media, $new = false)
    {
        $handler = $this->getHandler($media);

        if ($new) {
            $handler->saveMedia($media);
        } else {
            $handler->updateMedia($media);
        }
    }

    /**
     * @param \Kunstmaan\MediaBundle\Entity\Media $media
     */
    public function removeMedia(Media $media)
    {
        $handler = $this->getHandler($media);
        $handler->removeMedia($media);
    }

    /**
     * @param mixed $data
     *
     * @return Media

     */
    public function createNew($data)
    {
        foreach ($this->handlers as $handler) {
            $result = $handler->createNew($data);
            if ($result) {
                return $result;
            }
        }

        return null;
    }

    /**
     * @return array
     */
    public function getFolderAddActions()
    {
        $result = array();
        foreach ($this->handlers as $handler) {
            $actions = $handler->getAddFolderActions();
            if ($actions) {

                $result = array_merge($actions, $result);
            }
        }

        return $result;
    }
}


1			<?php
2
3			namespace Kunstmaan\MediaBundle\Helper;
4
5			use Kunstmaan\MediaBundle\Entity\Media;
6			use Kunstmaan\MediaBundle\Helper\Media\AbstractMediaHandler;
7			use Symfony\Component\HttpFoundation\File\File;
8
9			/**
10			* MediaManager
11			*/
12			class MediaManager
13			{
14			/**
15			* @var AbstractMediaHandler[]
16			*/
17			protected $handlers = array();
18
19			/**
20			* @var AbstractMediaHandler
21			*/
22			protected $defaultHandler;
23
24			/**
25			* @param AbstractMediaHandler $handler Media handler
26			*
27			* @return MediaManager
28			*/
29	10		public function addHandler(AbstractMediaHandler $handler)
30			{
31	10		$this->handlers[$handler->getName()] = $handler;
32
33	10		return $this;
34			}
35
36			/**
37			* @param AbstractMediaHandler $handler Media handler
38			*
39			* @return MediaManager
40			*/
41	14		public function setDefaultHandler(AbstractMediaHandler $handler)
42			{
43	14		$this->defaultHandler = $handler;
44
45	14		return $this;
46			}
47
48			/**
49			* Returns handler with the highest priority to handle the Media item which can handle the item. If no handler is found, it returns FileHandler
50			*
51			* @param Media\|File $media
52			*
53			* @return AbstractMediaHandler
54			*/
55	10	View Code Duplication	public function getHandler($media)
			0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56			{
57	10		$bestHandler = $this->defaultHandler;
58	10		foreach ($this->handlers as $handler) {
59	6		if ($handler->canHandle($media) && $handler->getPriority() > $bestHandler->getPriority()) {
60	6		$bestHandler = $handler;
61			}
62			}
63
64	10		return $bestHandler;
65			}
66
67			/**
68			* Returns handler with the highest priority to handle the Media item based on the Type. If no handler is found, it returns FileHandler
69			*
70			* @param string $type
71			*
72			* @return AbstractMediaHandler
73			*/
74	1	View Code Duplication	public function getHandlerForType($type)
			0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75			{
76	1		$bestHandler = $this->defaultHandler;
77	1		foreach ($this->handlers as $handler) {
78	1		if ($handler->getType() == $type && $handler->getPriority() > $bestHandler->getPriority()) {
79	1		$bestHandler = $handler;
80			}
81			}
82
83	1		return $bestHandler;
84			}
85
86			/**
87			* @return AbstractMediaHandler[]
88			*/
89	1		public function getHandlers()
90			{
91	1		return $this->handlers;
92			}
93
94			/**
95			* @param \Kunstmaan\MediaBundle\Entity\Media $media
96			*
97			* @return MediaManager
98			*/
99	2		public function prepareMedia(Media $media)
100			{
101	2		$handler = $this->getHandler($media);
102	2		$handler->prepareMedia($media);
103
104	2		return $this;
105			}
106
107			/**
108			* @param Media $media The media
109			* @param bool $new Is new
110			*/
111	3		public function saveMedia(Media $media, $new = false)
112			{
113	3		$handler = $this->getHandler($media);
114
115	3		if ($new) {
116	2		$handler->saveMedia($media);
117			} else {
118	2		$handler->updateMedia($media);
119			}
120	3		}
121
122			/**
123			* @param \Kunstmaan\MediaBundle\Entity\Media $media
124			*/
125	2		public function removeMedia(Media $media)
126			{
127	2		$handler = $this->getHandler($media);
128	2		$handler->removeMedia($media);
129	2		}
130
131			/**
132			* @param mixed $data
133			*
134			* @return Media
			0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `Media\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
135			*/
136	1		public function createNew($data)
137			{
138	1		foreach ($this->handlers as $handler) {
139	1		$result = $handler->createNew($data);
140	1		if ($result) {
141	1		return $result;
142			}
143			}
144
145	1		return null;
146			}
147
148			/**
149			* @return array
150			*/
151	1		public function getFolderAddActions()
152			{
153	1		$result = array();
154	1		foreach ($this->handlers as $handler) {
155	1		$actions = $handler->getAddFolderActions();
156	1		if ($actions) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$actions` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
157	1		$result = array_merge($actions, $result);
158			}
159			}
160
161	1		return $result;
162			}
163			}
164

Kunstmaan / KunstmaanBundlesCMS

Push — master ( ae5e03...0447ee )

src/Kunstmaan/MediaBundle/Helper/MediaManager.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like