Kunstmaan / KunstmaanBundlesCMS

src/Kunstmaan/FormBundle/EventListener/ConfigureActionsMenuListener.php

<?php

namespace Kunstmaan\FormBundle\EventListener;

use Doctrine\ORM\EntityManager;
use Kunstmaan\FormBundle\Entity\AbstractFormPage;
use Kunstmaan\NodeBundle\Event\ConfigureActionMenuEvent;
use Symfony\Component\Routing\RouterInterface;

/**
 * An event listener to add a formsubmissions link to the submenu of nodes.
 */
class ConfigureActionsMenuListener
{
    /**
     * @var EntityManager
     */
    private $em;

    /**
     * @var Router
     */
    private $router;

    /**
     * @param EntityManager   $em     The entity manager
     * @param RouterInterface $router The router
     */
    public function __construct(EntityManager $em, RouterInterface $router)

You have injected the EntityManager via parameter $em. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->router = $router;

It seems like $router of type object<Symfony\Component\Routing\RouterInterface> is incompatible with the declared type object<Kunstmaan\FormBundle\EventListener\Router> of property $router.

        $this->em = $em;
    }

    /**
     * Configure the form submissions link on top of the form in the sub action menu
     *
     * @param ConfigureActionMenuEvent $event
     */
    public function onSubActionMenuConfigure(ConfigureActionMenuEvent $event)
    {
        $menu = $event->getMenu();
        $activeNodeVersion = $event->getActiveNodeVersion();

        if (!is_null($activeNodeVersion)) {
            $page = $activeNodeVersion->getRef($this->em);
            if ($page instanceof AbstractFormPage) {
                $activeNodeTranslation = $activeNodeVersion->getNodeTranslation();
                $menu->addChild('subaction.formsubmissions', array('uri' => $this->router->generate('KunstmaanFormBundle_formsubmissions_list', array('nodeTranslationId' => $activeNodeTranslation->getId()))));
            }
        }
    }
}