Kunstmaan / KunstmaanBundlesCMS

src/Kunstmaan/DashboardBundle/Repository/AnalyticsSegmentRepository.php

<?php

namespace Kunstmaan\DashboardBundle\Repository;

use Doctrine\ORM\EntityRepository;
use Kunstmaan\DashboardBundle\Entity\AnalyticsConfig;
use Kunstmaan\DashboardBundle\Entity\AnalyticsOverview;
use Kunstmaan\DashboardBundle\Entity\AnalyticsSegment;

/**
 * AnalyticsSegmentRepository
 *
 * This class was generated by the Doctrine ORM. Add your own custom
 * repository methods below.
 */
class AnalyticsSegmentRepository extends EntityRepository
{
    /**
     * Get a segment
     *
     * @param int $id
     *
     * @return AnalyticsOverview|bool

Should the return type not be AnalyticsOverview|boolean|null?

     */
    public function deleteSegment($id)
    {
        $em = $this->getEntityManager();
        $qb = $em->createQueryBuilder();
        $qb->select('s')
            ->from('KunstmaanDashboardBundle:AnalyticsSegment', 's')
            ->where('s.id = :id')
            ->setParameter('id', $id);

        $results = $qb->getQuery()->getResult();
        if ($results) {
            $em->remove($results[0]);
            $em->flush();
        }
    }

    /**
     * Initialise a segment by adding new overviews if they don't exist yet
     *
     * @param AnalyticsSegment $segment
     * @param int              $configId

Should the type for parameter $configId not be false|integer?

     */
    public function initSegment($segment, $configId = false)
    {
        if (!\count($segment->getOverviews()->toArray())) {
            if ($configId) {

The expression $configId of type false|integer is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

                $config = $this->getEntityManager()->getRepository(AnalyticsConfig::class)->find($configId);
            } else {
                $config = $this->getEntityManager()->getRepository(AnalyticsConfig::class)->findFirst();
            }
            $this->getEntityManager()->getRepository(AnalyticsOverview::class)->addOverviews($config, $segment);
        }
    }
}