Issues in AnalyticsGoal.php - All Issues - Inspection of "Merge branch '5.6'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae5e03...0447ee )

by Jeroen

created 2020-08-07 09:00 UTC

Kunstmaan/DashboardBundle/Entity/AnalyticsGoal.php (3 issues)

Labels

Severity

Brent Roose 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\DashboardBundle\Entity;

use Doctrine\ORM\Mapping as ORM;
use Kunstmaan\AdminBundle\Entity\AbstractEntity;

/**
 * AnalyticsGoal
 *
 * @ORM\Table(name="kuma_analytics_goal")
 * @ORM\Entity(repositoryClass="Kunstmaan\DashboardBundle\Repository\AnalyticsGoalRepository")
 */
class AnalyticsGoal extends AbstractEntity
{
    /**
     * @ORM\ManyToOne(targetEntity="AnalyticsOverview", inversedBy="goals")
     * @ORM\JoinColumn(name="overview_id", referencedColumnName="id")
     */
    private $overview;

    /**
     * @var int
     *
     * @ORM\Column(name="position", type="integer")
     */
    private $position;

    /**
     * @var string
     *
     * @ORM\Column(name="name", type="string", length=255)
     */
    private $name;

    /**
     * @var int
     *
     * @ORM\Column(name="visits", type="integer")
     */
    private $visits;

    /**
     * @var array
     *
     * @ORM\Column(name="chart_data", type="text")
     */
    private $chartData = '';

    /**
     * Get overview
     *
     * @return int
     */
    public function getOverview()
    {
        return $this->overview;
    }

    /**
     * Set overview
     *
     * @param int $overview
     *
     * @return $this
     */
    public function setOverview($overview)
    {
        $this->overview = $overview;

        return $this;
    }

    /**
     * Set position
     *
     * @param int $position
     *
     * @return AnalyticsGoal
     */
    public function setPosition($position)
    {
        $this->position = $position;

        return $this;
    }

    /**
     * Get position
     *
     * @return int
     */
    public function getPosition()
    {
        return $this->position;
    }

    /**
     * Set name
     *
     * @param string $name
     *
     * @return AnalyticsGoal
     */
    public function setName($name)
    {
        $this->name = $name;

        return $this;
    }

    /**
     * Get name
     *
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Set visits
     *
     * @param int $visits
     *
     * @return AnalyticsGoal
     */
    public function setVisits($visits)
    {
        $this->visits = $visits;

        return $this;
    }

    /**
     * Get visits
     *
     * @return int

     */
    public function getVisits()
    {
        return number_format($this->visits);
    }

    /**
     * Set chartData
     *
     * @param string $chartData
     *
     * @return AnalyticsGoal
     */
    public function setChartData($chartData)
    {
        $this->chartData = $chartData;


        return $this;
    }

    /**
     * Get chartData
     *
     * @return string

     */
    public function getChartData()
    {
        return $this->chartData;
    }
}


1		<?php
2
3		namespace Kunstmaan\DashboardBundle\Entity;
4
5		use Doctrine\ORM\Mapping as ORM;
6		use Kunstmaan\AdminBundle\Entity\AbstractEntity;
7
8		/**
9		* AnalyticsGoal
10		*
11		* @ORM\Table(name="kuma_analytics_goal")
12		* @ORM\Entity(repositoryClass="Kunstmaan\DashboardBundle\Repository\AnalyticsGoalRepository")
13		*/
14		class AnalyticsGoal extends AbstractEntity
15		{
16		/**
17		* @ORM\ManyToOne(targetEntity="AnalyticsOverview", inversedBy="goals")
18		* @ORM\JoinColumn(name="overview_id", referencedColumnName="id")
19		*/
20		private $overview;
21
22		/**
23		* @var int
24		*
25		* @ORM\Column(name="position", type="integer")
26		*/
27		private $position;
28
29		/**
30		* @var string
31		*
32		* @ORM\Column(name="name", type="string", length=255)
33		*/
34		private $name;
35
36		/**
37		* @var int
38		*
39		* @ORM\Column(name="visits", type="integer")
40		*/
41		private $visits;
42
43		/**
44		* @var array
45		*
46		* @ORM\Column(name="chart_data", type="text")
47		*/
48		private $chartData = '';
49
50		/**
51		* Get overview
52		*
53		* @return int
54		*/
55	1	public function getOverview()
56		{
57	1	return $this->overview;
58		}
59
60		/**
61		* Set overview
62		*
63		* @param int $overview
64		*
65		* @return $this
66		*/
67	1	public function setOverview($overview)
68		{
69	1	$this->overview = $overview;
70
71	1	return $this;
72		}
73
74		/**
75		* Set position
76		*
77		* @param int $position
78		*
79		* @return AnalyticsGoal
80		*/
81	1	public function setPosition($position)
82		{
83	1	$this->position = $position;
84
85	1	return $this;
86		}
87
88		/**
89		* Get position
90		*
91		* @return int
92		*/
93	1	public function getPosition()
94		{
95	1	return $this->position;
96		}
97
98		/**
99		* Set name
100		*
101		* @param string $name
102		*
103		* @return AnalyticsGoal
104		*/
105	1	public function setName($name)
106		{
107	1	$this->name = $name;
108
109	1	return $this;
110		}
111
112		/**
113		* Get name
114		*
115		* @return string
116		*/
117	1	public function getName()
118		{
119	1	return $this->name;
120		}
121
122		/**
123		* Set visits
124		*
125		* @param int $visits
126		*
127		* @return AnalyticsGoal
128		*/
129	2	public function setVisits($visits)
130		{
131	2	$this->visits = $visits;
132
133	2	return $this;
134		}
135
136		/**
137		* Get visits
138		*
139		* @return int
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `string`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
140		*/
141	2	public function getVisits()
142		{
143	2	return number_format($this->visits);
144		}
145
146		/**
147		* Set chartData
148		*
149		* @param string $chartData
150		*
151		* @return AnalyticsGoal
152		*/
153	1	public function setChartData($chartData)
154		{
155	1	$this->chartData = $chartData;
		0 ignored issues – show Documentation Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$chartData` of type `string` is incompatible with the declared type `array` of property `$chartData`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
156
157	1	return $this;
158		}
159
160		/**
161		* Get chartData
162		*
163		* @return string
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `array`? Also, consider making the array more specific, something like `array<String>`, or `String[]`. This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. If the return type contains the type array, this check recommends the use of a more specific type like `String[]` or `array<String>`. Loading history...
164		*/
165	1	public function getChartData()
166		{
167	1	return $this->chartData;
168		}
169		}
170

Kunstmaan / KunstmaanBundlesCMS

Push — master ( ae5e03...0447ee )

Kunstmaan/DashboardBundle/Entity/AnalyticsGoal.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like