Issues in AbstractDoctrineORMAdminListConfiguratorTest.php - All Issues - Inspection of "Merge branch '5.6'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae5e03...0447ee )

by Jeroen

created 2020-08-07 09:00 UTC

AbstractDoctrineORMAdminListConfiguratorTest.php (6 issues)

Labels

Severity

Major 6

Peter Zentjens 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminListBundle\Tests\AdminList\Configurator;

use Doctrine\ORM\AbstractQuery;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\QueryBuilder;
use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
use Kunstmaan\AdminBundle\Helper\Security\Acl\Permission\PermissionDefinition;
use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
use Kunstmaan\AdminListBundle\AdminList\Filter;
use Kunstmaan\AdminListBundle\AdminList\FilterBuilder;
use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM\AbstractORMFilterType;
use Pagerfanta\Pagerfanta;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Session\Session;

class AbstractDoctrineORMAdminListConfiguratorTest extends TestCase
{
    /** @var EntityManagerInterface */
    private $emMock;

    /** @var AclHelper */
    private $aclHelperMock;

    public function setUp()
    {
        $queryMock = $this->createMock(AbstractQuery::class);
        $queryMock
            ->expects($this->any())
            ->method('iterate')
            ->willReturn($this->createMock(\Iterator::class))
        ;

        $this->emMock = $this->createMock(EntityManagerInterface::class);

        $this->aclHelperMock = $this->createMock(AclHelper::class);

        $this->aclHelperMock
            ->expects($this->any())
            ->method('apply')
            ->willReturn($queryMock)
        ;

        $queryBuilderMock = $this->createMock(QueryBuilder::class);
        $queryBuilderMock
            ->expects($this->any())
            ->method('getQuery')
            ->willReturn($queryMock)
        ;

        $entityRepositoryMock = $this->createMock(EntityRepository::class);
        $entityRepositoryMock
            ->expects($this->any())
            ->method('createQueryBuilder')
            ->willReturn($queryBuilderMock)
        ;

        $this->emMock
            ->expects($this->any())
            ->method('getRepository')
            ->with('Bundle:MyEntity')
            ->willReturn($entityRepositoryMock)
        ;
        $this->emMock
            ->expects($this->any())
            ->method('getClassMetadata')
            ->willReturn($this->createMock(ClassMetadata::class))
        ;
    }

    public function testGetEditUrl()
    {
        $abstractMock = $this->setUpAbstractMock();

        $item = new class() {
            public function getId()
            {
                return 747;
            }
        };

        $editUrl = $abstractMock->getEditUrlFor($item);
        $this->assertIsArray($editUrl);
        $this->assertArrayHasKey('path', $editUrl);
        $this->assertArrayHasKey('params', $editUrl);
        $this->assertEquals('bundle_admin_myentity_'.AbstractDoctrineORMAdminListConfigurator::SUFFIX_EDIT, $editUrl['path']);
        $this->assertContains(747, $editUrl['params']);
    }

    public function testGetDeleteUrl()
    {
        $abstractMock = $this->setUpAbstractMock();

        $item = new class() {
            public function getId()
            {
                return 747;
            }
        };

        $editUrl = $abstractMock->getDeleteUrlFor($item);
        $this->assertIsArray($editUrl);
        $this->assertArrayHasKey('path', $editUrl);
        $this->assertArrayHasKey('params', $editUrl);
        $this->assertEquals('bundle_admin_myentity_'.AbstractDoctrineORMAdminListConfigurator::SUFFIX_DELETE, $editUrl['path']);
        $this->assertContains(747, $editUrl['params']);
    }

    public function testGetPagerFanta()
    {
        $abstractMock = $this->setUpAbstractMock();

        $this->assertInstanceOf(Pagerfanta::class, $abstractMock->getPagerfanta());
    }

    public function testGetQueryDefault()
    {
        $abstractMock = $this->setUpAbstractMock();

        // default
        $this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());

        // no longer null, direct return
        $this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());

        // check the iterator in one go
        $this->assertInstanceOf(\Iterator::class, $abstractMock->getIterator());
    }

    public function testGetQueryWithFilter()
    {
        $abstractORMFilterTypeMock = $this->createMock(AbstractORMFilterType::class);

        $filterBuilderMock = $this->createMock(FilterBuilder::class);
        $filterBuilderMock
            ->expects($this->any())
            ->method('getCurrentFilters')
            ->willReturn([
                new Filter('foo', ['type' => $abstractORMFilterTypeMock, 'options' => []], 'uid'),
            ])
        ;

        /** @var AbstractDoctrineORMAdminListConfigurator $abstractMock */
        $abstractMock = $this->setUpAbstractMock(['getFilterBuilder']);
        $abstractMock

            ->expects($this->any())
            ->method('getFilterBuilder')
            ->willReturn($filterBuilderMock)
        ;

        $abstractMock->addFilter('foo');
        $this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());
    }

    public function testGetQueryWithOrderBy()
    {
        /** @var AbstractDoctrineORMAdminListConfigurator $abstractMock */
        $abstractMock = $this->setUpAbstractMock(['getFilterBuilder']);

        $filterBuilderMock = $this->createMock(FilterBuilder::class);
        $filterBuilderMock
            ->expects($this->once())
            ->method('bindRequest')
        ;
        $filterBuilderMock
            ->expects($this->any())
            ->method('getCurrentFilters')
            ->willReturn([])
        ;

        $abstractMock

            ->expects($this->exactly(2))
            ->method('getFilterBuilder')
            ->willReturn($filterBuilderMock)
        ;

        $requestMock = $this->getMockBuilder(Request::class)
            ->setConstructorArgs([['page' => 1], [], ['_route' => 'testroute']])
            ->setMethods(['getSession'])
            ->getMock()
        ;

        $sessionMock = $this->createMock(Session::class);
        $sessionMock
            ->expects($this->once())
            ->method('has')
            ->willReturn(true)
        ;
        $sessionMock
            ->expects($this->once())
            ->method('get')
            ->with('listconfig_testroute')
            ->willReturn(['page' => 1, 'orderBy' => 'foo', 'orderDirection' => 'up'])
        ;

        $requestMock
            ->expects($this->exactly(2))
            ->method('getSession')
            ->willReturn($sessionMock)
        ;

        $abstractMock->bindRequest($requestMock);
        $this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());
    }

    public function testGetQueryWithPermissionDefAndAcl()
    {
        $abstractMock = $this->setUpAbstractMock();

        /** @var PermissionDefinition $permissionDefinitionMock */
        $permissionDefinitionMock = $this->createMock(PermissionDefinition::class);
        $this->assertInstanceOf(AbstractDoctrineORMAdminListConfigurator::class, $abstractMock->setPermissionDefinition($permissionDefinitionMock));
        $this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());
    }

    public function testSetGetPermissionDefinition()
    {
        $abstractMock = $this->setUpAbstractMock();

        /** @var PermissionDefinition $permissionDefinitionMock */
        $permissionDefinitionMock = $this->createMock(PermissionDefinition::class);
        $this->assertInstanceOf(AbstractDoctrineORMAdminListConfigurator::class, $abstractMock->setPermissionDefinition($permissionDefinitionMock));
        $this->assertInstanceOf(PermissionDefinition::class, $abstractMock->getPermissionDefinition());
    }

    public function testSetGetEntityManager()
    {
        $abstractMock = $this->setUpAbstractMock();

        /** @var EntityManagerInterface $emMock */
        $emMock = $this->createMock(EntityManagerInterface::class);
        $this->assertInstanceOf(AbstractDoctrineORMAdminListConfigurator::class, $abstractMock->setEntityManager($emMock));
        $this->assertInstanceOf(EntityManagerInterface::class, $abstractMock->getEntityManager());
    }

    public function setUpAbstractMock(array $methods = [])
    {
        /** @var AbstractDoctrineORMAdminListConfigurator $abstractMock */
        $abstractMock = $this->getMockForAbstractClass(AbstractDoctrineORMAdminListConfigurator::class, [$this->emMock], '', true, true, true, $methods);
        $abstractMock

            ->expects($this->any())
            ->method('getBundleName')
            ->willReturn('Bundle')
        ;
        $abstractMock

            ->expects($this->any())
            ->method('getEntityName')
            ->willReturn('MyEntity')
        ;

        return $abstractMock;
    }
}


1		<?php
2
3		namespace Kunstmaan\AdminListBundle\Tests\AdminList\Configurator;
4
5		use Doctrine\ORM\AbstractQuery;
6		use Doctrine\ORM\EntityManagerInterface;
7		use Doctrine\ORM\EntityRepository;
8		use Doctrine\ORM\Mapping\ClassMetadata;
9		use Doctrine\ORM\QueryBuilder;
10		use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
11		use Kunstmaan\AdminBundle\Helper\Security\Acl\Permission\PermissionDefinition;
12		use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
13		use Kunstmaan\AdminListBundle\AdminList\Filter;
14		use Kunstmaan\AdminListBundle\AdminList\FilterBuilder;
15		use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM\AbstractORMFilterType;
16		use Pagerfanta\Pagerfanta;
17		use PHPUnit\Framework\TestCase;
18		use Symfony\Component\HttpFoundation\Request;
19		use Symfony\Component\HttpFoundation\Session\Session;
20
21		class AbstractDoctrineORMAdminListConfiguratorTest extends TestCase
22		{
23		/** @var EntityManagerInterface */
24		private $emMock;
25
26		/** @var AclHelper */
27		private $aclHelperMock;
28
29		public function setUp()
30		{
31		$queryMock = $this->createMock(AbstractQuery::class);
32		$queryMock
33		->expects($this->any())
34		->method('iterate')
35		->willReturn($this->createMock(\Iterator::class))
36		;
37
38		$this->emMock = $this->createMock(EntityManagerInterface::class);
		0 ignored issues – show Documentation Bug introduced 2019-02-06 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createMock(\Doctr...anagerInterface::class)` of type `object<PHPUnit\Framework\MockObject\MockObject>` is incompatible with the declared type `object<Doctrine\ORM\EntityManagerInterface>` of property `$emMock`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
39		$this->aclHelperMock = $this->createMock(AclHelper::class);
		0 ignored issues – show Documentation Bug introduced 2019-02-06 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createMock(\Kunst...y\Acl\AclHelper::class)` of type `object<PHPUnit\Framework\MockObject\MockObject>` is incompatible with the declared type `object<Kunstmaan\AdminBu...Security\Acl\AclHelper>` of property `$aclHelperMock`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
40		$this->aclHelperMock
41		->expects($this->any())
42		->method('apply')
43		->willReturn($queryMock)
44		;
45
46		$queryBuilderMock = $this->createMock(QueryBuilder::class);
47		$queryBuilderMock
48		->expects($this->any())
49		->method('getQuery')
50		->willReturn($queryMock)
51		;
52
53		$entityRepositoryMock = $this->createMock(EntityRepository::class);
54		$entityRepositoryMock
55		->expects($this->any())
56		->method('createQueryBuilder')
57		->willReturn($queryBuilderMock)
58		;
59
60		$this->emMock
61		->expects($this->any())
62		->method('getRepository')
63		->with('Bundle:MyEntity')
64		->willReturn($entityRepositoryMock)
65		;
66		$this->emMock
67		->expects($this->any())
68		->method('getClassMetadata')
69		->willReturn($this->createMock(ClassMetadata::class))
70		;
71		}
72
73	View Code Duplication	public function testGetEditUrl()
74		{
75		$abstractMock = $this->setUpAbstractMock();
76
77		$item = new class() {
78		public function getId()
79		{
80		return 747;
81		}
82		};
83
84		$editUrl = $abstractMock->getEditUrlFor($item);
85		$this->assertIsArray($editUrl);
86		$this->assertArrayHasKey('path', $editUrl);
87		$this->assertArrayHasKey('params', $editUrl);
88		$this->assertEquals('bundle_admin_myentity_'.AbstractDoctrineORMAdminListConfigurator::SUFFIX_EDIT, $editUrl['path']);
89		$this->assertContains(747, $editUrl['params']);
90		}
91
92	View Code Duplication	public function testGetDeleteUrl()
93		{
94		$abstractMock = $this->setUpAbstractMock();
95
96		$item = new class() {
97		public function getId()
98		{
99		return 747;
100		}
101		};
102
103		$editUrl = $abstractMock->getDeleteUrlFor($item);
104		$this->assertIsArray($editUrl);
105		$this->assertArrayHasKey('path', $editUrl);
106		$this->assertArrayHasKey('params', $editUrl);
107		$this->assertEquals('bundle_admin_myentity_'.AbstractDoctrineORMAdminListConfigurator::SUFFIX_DELETE, $editUrl['path']);
108		$this->assertContains(747, $editUrl['params']);
109		}
110
111		public function testGetPagerFanta()
112		{
113		$abstractMock = $this->setUpAbstractMock();
114
115		$this->assertInstanceOf(Pagerfanta::class, $abstractMock->getPagerfanta());
116		}
117
118		public function testGetQueryDefault()
119		{
120		$abstractMock = $this->setUpAbstractMock();
121
122		// default
123		$this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());
124
125		// no longer null, direct return
126		$this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());
127
128		// check the iterator in one go
129		$this->assertInstanceOf(\Iterator::class, $abstractMock->getIterator());
130		}
131
132		public function testGetQueryWithFilter()
133		{
134		$abstractORMFilterTypeMock = $this->createMock(AbstractORMFilterType::class);
135
136		$filterBuilderMock = $this->createMock(FilterBuilder::class);
137		$filterBuilderMock
138		->expects($this->any())
139		->method('getCurrentFilters')
140		->willReturn([
141		new Filter('foo', ['type' => $abstractORMFilterTypeMock, 'options' => []], 'uid'),
142		])
143		;
144
145		/** @var AbstractDoctrineORMAdminListConfigurator $abstractMock */
146		$abstractMock = $this->setUpAbstractMock(['getFilterBuilder']);
147		$abstractMock
		0 ignored issues – show Bug introduced 2019-02-07 08:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Kunstmaan\AdminLi...MAdminListConfigurator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
148		->expects($this->any())
149		->method('getFilterBuilder')
150		->willReturn($filterBuilderMock)
151		;
152
153		$abstractMock->addFilter('foo');
154		$this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());
155		}
156
157		public function testGetQueryWithOrderBy()
158		{
159		/** @var AbstractDoctrineORMAdminListConfigurator $abstractMock */
160		$abstractMock = $this->setUpAbstractMock(['getFilterBuilder']);
161
162		$filterBuilderMock = $this->createMock(FilterBuilder::class);
163		$filterBuilderMock
164		->expects($this->once())
165		->method('bindRequest')
166		;
167		$filterBuilderMock
168		->expects($this->any())
169		->method('getCurrentFilters')
170		->willReturn([])
171		;
172
173		$abstractMock
		0 ignored issues – show Bug introduced 2019-02-06 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Kunstmaan\AdminLi...MAdminListConfigurator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
174		->expects($this->exactly(2))
175		->method('getFilterBuilder')
176		->willReturn($filterBuilderMock)
177		;
178
179		$requestMock = $this->getMockBuilder(Request::class)
180		->setConstructorArgs([['page' => 1], [], ['_route' => 'testroute']])
181		->setMethods(['getSession'])
182		->getMock()
183		;
184
185		$sessionMock = $this->createMock(Session::class);
186		$sessionMock
187		->expects($this->once())
188		->method('has')
189		->willReturn(true)
190		;
191		$sessionMock
192		->expects($this->once())
193		->method('get')
194		->with('listconfig_testroute')
195		->willReturn(['page' => 1, 'orderBy' => 'foo', 'orderDirection' => 'up'])
196		;
197
198		$requestMock
199		->expects($this->exactly(2))
200		->method('getSession')
201		->willReturn($sessionMock)
202		;
203
204		$abstractMock->bindRequest($requestMock);
205		$this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());
206		}
207
208	View Code Duplication	public function testGetQueryWithPermissionDefAndAcl()
209		{
210		$abstractMock = $this->setUpAbstractMock();
211
212		/** @var PermissionDefinition $permissionDefinitionMock */
213		$permissionDefinitionMock = $this->createMock(PermissionDefinition::class);
214		$this->assertInstanceOf(AbstractDoctrineORMAdminListConfigurator::class, $abstractMock->setPermissionDefinition($permissionDefinitionMock));
215		$this->assertInstanceOf(AbstractQuery::class, $abstractMock->getQuery());
216		}
217
218	View Code Duplication	public function testSetGetPermissionDefinition()
219		{
220		$abstractMock = $this->setUpAbstractMock();
221
222		/** @var PermissionDefinition $permissionDefinitionMock */
223		$permissionDefinitionMock = $this->createMock(PermissionDefinition::class);
224		$this->assertInstanceOf(AbstractDoctrineORMAdminListConfigurator::class, $abstractMock->setPermissionDefinition($permissionDefinitionMock));
225		$this->assertInstanceOf(PermissionDefinition::class, $abstractMock->getPermissionDefinition());
226		}
227
228	View Code Duplication	public function testSetGetEntityManager()
229		{
230		$abstractMock = $this->setUpAbstractMock();
231
232		/** @var EntityManagerInterface $emMock */
233		$emMock = $this->createMock(EntityManagerInterface::class);
234		$this->assertInstanceOf(AbstractDoctrineORMAdminListConfigurator::class, $abstractMock->setEntityManager($emMock));
235		$this->assertInstanceOf(EntityManagerInterface::class, $abstractMock->getEntityManager());
236		}
237
238	View Code Duplication	public function setUpAbstractMock(array $methods = [])
239		{
240		/** @var AbstractDoctrineORMAdminListConfigurator $abstractMock */
241		$abstractMock = $this->getMockForAbstractClass(AbstractDoctrineORMAdminListConfigurator::class, [$this->emMock], '', true, true, true, $methods);
242		$abstractMock
		0 ignored issues – show Bug introduced 2019-02-06 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Kunstmaan\AdminLi...MAdminListConfigurator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
243		->expects($this->any())
244		->method('getBundleName')
245		->willReturn('Bundle')
246		;
247		$abstractMock
		0 ignored issues – show Bug introduced 2019-02-06 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Kunstmaan\AdminLi...MAdminListConfigurator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
248		->expects($this->any())
249		->method('getEntityName')
250		->willReturn('MyEntity')
251		;
252
253		return $abstractMock;
254		}
255		}
256

Kunstmaan / KunstmaanBundlesCMS

Push — master ( ae5e03...0447ee )

AbstractDoctrineORMAdminListConfiguratorTest.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like