Issues in TabPaneTest.php - All Issues - Inspection of "Merge branch '5.6'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae5e03...0447ee )

by Jeroen

created 2020-08-07 09:00 UTC

Tests/unit/Helper/FormWidgets/Tabs/TabPaneTest.php (2 issues)

Labels

Severity

Major 2

Ruud Denivel 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Tests\Helper\FormWidgets\Tabs;

use Doctrine\ORM\EntityManager;
use Kunstmaan\AdminBundle\Helper\FormWidgets\Tabs\Tab;
use Kunstmaan\AdminBundle\Helper\FormWidgets\Tabs\TabPane;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Form\Form;
use Symfony\Component\Form\FormBuilder;
use Symfony\Component\Form\FormFactory;
use Symfony\Component\Form\FormView;
use Symfony\Component\HttpFoundation\Request;

/**
 * Class TabPaneTest
 */
class TabPaneTest extends TestCase
{
    /**
     * @throws \ReflectionException
     */
    public function testTabPane()
    {
        $request = $this->createMock(Request::class);
        $request->request = $this->createMock(Request::class);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $factory = $this->createMock(FormFactory::class);
        $builder = $this->createMock(FormBuilder::class);
        $form = $this->createMock(Form::class);
        $view = $this->createMock(FormView::class);
        $tab = $this->createMock(Tab::class);
        $tab2 = clone $tab;

        $request->expects($this->exactly(2))->method('get')->willReturn($tab);
        $tab->expects($this->any())->method('getExtraParams')->willReturn([1, 2, 3, 4, 5]);
        $tab->expects($this->any())->method('getTitle')->willReturn('Pass!');
        $form->expects($this->any())->method('createView')->willReturn($view);
        $form->expects($this->any())->method('isValid')->willReturn(true);
        $builder->expects($this->once())->method('getForm')->willReturn($form);
        $factory->expects($this->once())->method('createBuilder')->willReturn($builder);
        $em = $this->createMock(EntityManager::class);

        $tabPane = new TabPane('Title', $request, $factory);

        $tabPane->addTab($tab);
        $tabPane->addTab($tab2, 0);
        $tabPane->buildForm();
        $tabPane->bindRequest(new Request());
        $tabPane->persist($em);
        $tabPane->removeTab($tab2);
        $this->assertCount(5, $tabPane->getExtraParams(new Request()));
        $this->assertInstanceOf(Form::class, $tabPane->getForm());
        $this->assertInstanceOf(FormView::class, $tabPane->getFormView());
        $this->assertTrue($tabPane->isValid());
        $this->assertInstanceOf(Tab::class, $tabPane->getActiveTab());
        $this->assertNull($tabPane->getTabByPosition(5));
        $this->assertNotNull($tabPane->getTabByPosition(0));
        $this->assertNull($tabPane->getTabByTitle('Fail!'));
        $this->assertNotNull($tabPane->getTabByTitle('Pass!'));
        $tabPane->removeTabByTitle('Pass!');
        $tabPane->removeTabByTitle('not here');
        $this->assertEmpty($tabPane->getTabs());
        $tabPane->addTab($tab);
        $tabPane->addTab($tab2, 0);
        $tabPane->removeTabByPosition(0);
        $this->assertCount(1, $tabPane->getTabs());

        $request->request->expects($this->exactly(2))->method('get')->willReturn($tab);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        new TabPane('Title', $request, $factory);
    }
}


Push — master ( ae5e03...0447ee )

Tests/unit/Helper/FormWidgets/Tabs/TabPaneTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1			<?php
2
3			namespace Kunstmaan\AdminBundle\Tests\Helper\FormWidgets\Tabs;
4
5			use Doctrine\ORM\EntityManager;
6			use Kunstmaan\AdminBundle\Helper\FormWidgets\Tabs\Tab;
7			use Kunstmaan\AdminBundle\Helper\FormWidgets\Tabs\TabPane;
8			use PHPUnit\Framework\TestCase;
9			use Symfony\Component\Form\Form;
10			use Symfony\Component\Form\FormBuilder;
11			use Symfony\Component\Form\FormFactory;
12			use Symfony\Component\Form\FormView;
13			use Symfony\Component\HttpFoundation\Request;
14
15			/**
16			* Class TabPaneTest
17			*/
18			class TabPaneTest extends TestCase
19			{
20			/**
21			* @throws \ReflectionException
22			*/
23			public function testTabPane()
24			{
25			$request = $this->createMock(Request::class);
26			$request->request = $this->createMock(Request::class);
			0 ignored issues – show Bug introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `request` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
27			$factory = $this->createMock(FormFactory::class);
28			$builder = $this->createMock(FormBuilder::class);
29			$form = $this->createMock(Form::class);
30			$view = $this->createMock(FormView::class);
31			$tab = $this->createMock(Tab::class);
32			$tab2 = clone $tab;
33
34			$request->expects($this->exactly(2))->method('get')->willReturn($tab);
35			$tab->expects($this->any())->method('getExtraParams')->willReturn([1, 2, 3, 4, 5]);
36			$tab->expects($this->any())->method('getTitle')->willReturn('Pass!');
37			$form->expects($this->any())->method('createView')->willReturn($view);
38			$form->expects($this->any())->method('isValid')->willReturn(true);
39			$builder->expects($this->once())->method('getForm')->willReturn($form);
40			$factory->expects($this->once())->method('createBuilder')->willReturn($builder);
41			$em = $this->createMock(EntityManager::class);
42
43			$tabPane = new TabPane('Title', $request, $factory);
44
45			$tabPane->addTab($tab);
46			$tabPane->addTab($tab2, 0);
47			$tabPane->buildForm();
48			$tabPane->bindRequest(new Request());
49			$tabPane->persist($em);
50			$tabPane->removeTab($tab2);
51			$this->assertCount(5, $tabPane->getExtraParams(new Request()));
52			$this->assertInstanceOf(Form::class, $tabPane->getForm());
53			$this->assertInstanceOf(FormView::class, $tabPane->getFormView());
54			$this->assertTrue($tabPane->isValid());
55			$this->assertInstanceOf(Tab::class, $tabPane->getActiveTab());
56			$this->assertNull($tabPane->getTabByPosition(5));
57			$this->assertNotNull($tabPane->getTabByPosition(0));
58			$this->assertNull($tabPane->getTabByTitle('Fail!'));
59			$this->assertNotNull($tabPane->getTabByTitle('Pass!'));
60			$tabPane->removeTabByTitle('Pass!');
61			$tabPane->removeTabByTitle('not here');
62			$this->assertEmpty($tabPane->getTabs());
63			$tabPane->addTab($tab);
64			$tabPane->addTab($tab2, 0);
65			$tabPane->removeTabByPosition(0);
66			$this->assertCount(1, $tabPane->getTabs());
67
68			$request->request->expects($this->exactly(2))->method('get')->willReturn($tab);
			0 ignored issues – show Bug introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `request` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
69			new TabPane('Title', $request, $factory);
70			}
71			}
72

Kunstmaan / KunstmaanBundlesCMS

Push — master ( ae5e03...0447ee )

Tests/unit/Helper/FormWidgets/Tabs/TabPaneTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like