Kunstmaan /
KunstmaanBundlesCMS
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 27 | class FormSubmissionsController extends Controller |
||
|
|
|||
| 28 | { |
||
| 29 | /** |
||
| 30 | * The index action will use an admin list to list all the form pages |
||
| 31 | * |
||
| 32 | * @Route("/", name="KunstmaanFormBundle_formsubmissions") |
||
| 33 | * @Template("@KunstmaanAdminList/Default/list.html.twig") |
||
| 34 | * |
||
| 35 | * @return array |
||
| 36 | */ |
||
| 37 | View Code Duplication | public function indexAction(Request $request) |
|
| 38 | { |
||
| 39 | /* @var EntityManager $em */ |
||
| 40 | $em = $this->getDoctrine()->getManager(); |
||
| 41 | $aclHelper = $this->container->get('kunstmaan_admin.acl.helper'); |
||
| 42 | |||
| 43 | /* @var AdminList $adminList */ |
||
| 44 | $adminList = $this->get('kunstmaan_adminlist.factory')->createList( |
||
| 45 | new FormPageAdminListConfigurator($em, $aclHelper, PermissionMap::PERMISSION_VIEW) |
||
| 46 | ); |
||
| 47 | $adminList->bindRequest($request); |
||
| 48 | |||
| 49 | return array('adminlist' => $adminList); |
||
| 50 | } |
||
| 51 | |||
| 52 | /** |
||
| 53 | * The list action will use an admin list to list all the form submissions related to the given $nodeTranslationId |
||
| 54 | * |
||
| 55 | * @param int $nodeTranslationId |
||
| 56 | * |
||
| 57 | * @Route("/list/{nodeTranslationId}", requirements={"nodeTranslationId" = "\d+"}, |
||
| 58 | * name="KunstmaanFormBundle_formsubmissions_list", methods={"GET", "POST"}) |
||
| 59 | * @Template("@KunstmaanForm/FormSubmissions/list.html.twig") |
||
| 60 | * |
||
| 61 | * @return array |
||
| 62 | */ |
||
| 63 | public function listAction(Request $request, $nodeTranslationId) |
||
| 64 | { |
||
| 65 | $em = $this->getDoctrine()->getManager(); |
||
| 66 | $nodeTranslation = $em->getRepository(NodeTranslation::class)->find($nodeTranslationId); |
||
| 67 | |||
| 68 | /** @var AdminList $adminList */ |
||
| 69 | $adminList = $this->get('kunstmaan_adminlist.factory')->createList( |
||
| 70 | new FormSubmissionAdminListConfigurator($em, $nodeTranslation, $this->getParameter('kunstmaan_form.deletable_formsubmissions')) |
||
| 71 | ); |
||
| 72 | $adminList->bindRequest($request); |
||
| 73 | |||
| 74 | return array('nodetranslation' => $nodeTranslation, 'adminlist' => $adminList); |
||
| 75 | } |
||
| 76 | |||
| 77 | /** |
||
| 78 | * The edit action will be used to edit a given submission. |
||
| 79 | * |
||
| 80 | * @param int $nodeTranslationId The node translation id |
||
| 81 | * @param int $submissionId The submission id |
||
| 82 | * |
||
| 83 | * @Route("/list/{nodeTranslationId}/{submissionId}", requirements={"nodeTranslationId" = "\d+", "submissionId" = |
||
| 84 | * "\d+"}, name="KunstmaanFormBundle_formsubmissions_list_edit", methods={"GET", "POST"}) |
||
| 85 | * @Template("@KunstmaanForm/FormSubmissions/edit.html.twig") |
||
| 86 | * |
||
| 87 | * @return array |
||
| 88 | */ |
||
| 89 | public function editAction($nodeTranslationId, $submissionId) |
||
| 90 | { |
||
| 91 | $em = $this->getDoctrine()->getManager(); |
||
| 92 | $nodeTranslation = $em->getRepository(NodeTranslation::class)->find($nodeTranslationId); |
||
| 93 | $formSubmission = $em->getRepository(FormSubmission::class)->find($submissionId); |
||
| 94 | $request = $this->container->get('request_stack')->getCurrentRequest(); |
||
| 95 | $deletableFormsubmission = $this->getParameter('kunstmaan_form.deletable_formsubmissions'); |
||
| 96 | |||
| 97 | /** @var AdminList $adminList */ |
||
| 98 | $adminList = $this->get('kunstmaan_adminlist.factory')->createList( |
||
| 99 | new FormSubmissionAdminListConfigurator($em, $nodeTranslation, $deletableFormsubmission) |
||
| 100 | ); |
||
| 101 | $adminList->bindRequest($request); |
||
| 102 | |||
| 103 | return [ |
||
| 104 | 'nodetranslation' => $nodeTranslation, |
||
| 105 | 'formsubmission' => $formSubmission, |
||
| 106 | 'adminlist' => $adminList, |
||
| 107 | ]; |
||
| 108 | } |
||
| 109 | |||
| 110 | /** |
||
| 111 | * Export as CSV of all the form submissions for the given $nodeTranslationId |
||
| 112 | * |
||
| 113 | * @param int $nodeTranslationId |
||
| 114 | * |
||
| 115 | * @Route("/export/{nodeTranslationId}.{_format}", requirements={"nodeTranslationId" = "\d+","_format" = |
||
| 116 | * "csv|xlsx|ods"}, name="KunstmaanFormBundle_formsubmissions_export", methods={"GET"}) |
||
| 117 | * |
||
| 118 | * @return Response |
||
| 119 | */ |
||
| 120 | public function exportAction($nodeTranslationId, $_format) |
||
| 133 | |||
| 134 | /** |
||
| 135 | * @Route( |
||
| 136 | * "/{id}/delete", |
||
| 137 | * requirements={"id" = "\d+"}, |
||
| 138 | * name="KunstmaanFormBundle_formsubmissions_delete", |
||
| 139 | * methods={"POST"} |
||
| 140 | * ) |
||
| 141 | * |
||
| 142 | * @param Request $request |
||
| 143 | * @param int $id |
||
| 144 | * |
||
| 145 | * @return RedirectResponse |
||
| 146 | * |
||
| 147 | * @throws AccessDeniedException |
||
| 148 | */ |
||
| 149 | public function deleteAction(Request $request, $id) |
||
| 188 | } |
||
| 189 |
Loading history...
This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message.
The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead.