OAuthUserFinderTest::testFindUserByGoogleSignInData() - Code Metrics - Inspection of "[AllBundles] Bump supported php version and upgrad..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2748)

by Jeroen

created 2020-09-20 11:07 UTC

testFindUserByGoogleSignInData() A

↳ Parent: OAuthUserFinderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Kunstmaan\AdminBundle\Tests\Helper\Security\Acl;

use DateTime;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Kunstmaan\AdminBundle\Entity\User;
use Kunstmaan\AdminBundle\Helper\Security\OAuth\OAuthUserFinder;
use PHPUnit\Framework\TestCase;

class OAuthUserFinderTest extends TestCase
{
    /**
     * @var OAuthUserFinder
     */
    private $object;

    /**
     * @var EntityManager
     */
    private $em;

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject

     */
    private function getEm()
    {
        if (!isset($this->em)) {
            $this->em = $this->createMock(EntityManager::class);

        }

        return $this->em;
    }

    public function setUp(): void
    {
        $em = $this->getEm();
        $object = new OAuthUserFinder($em, User::class);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->object = $object;
    }

    public function testFindUserByGoogleSignInData()
    {
        $object = $this->object;
        $repo = $this->createMock(EntityRepository::class);
        $repo->expects($this->exactly(3))->method('findOneBy')->will($this->onConsecutiveCalls(new DateTime(), new DateTime(), new User()));
        $this->getEm()->expects($this->exactly(3))->method('getRepository')->willReturn($repo);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $user = $object->findUserByGoogleSignInData('[email protected]', 12345679);
        $this->assertInstanceOf(User::class, $user);
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminBundle\Tests\Helper\Security\Acl;
4
5			use DateTime;
6			use Doctrine\ORM\EntityManager;
7			use Doctrine\ORM\EntityRepository;
8			use Kunstmaan\AdminBundle\Entity\User;
9			use Kunstmaan\AdminBundle\Helper\Security\OAuth\OAuthUserFinder;
10			use PHPUnit\Framework\TestCase;
11
12			class OAuthUserFinderTest extends TestCase
13			{
14			/**
15			* @var OAuthUserFinder
16			*/
17			private $object;
18
19			/**
20			* @var EntityManager
21			*/
22			private $em;
23
24			/**
25			* @return \PHPUnit_Framework_MockObject_MockObject
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Should the return type not be `\PHPUnit\Framework\MockO...ockObject\|EntityManager`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
26			*/
27			private function getEm()
28			{
29			if (!isset($this->em)) {
30			$this->em = $this->createMock(EntityManager::class);
			0 ignored issues – show Documentation Bug introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report It seems like `$this->createMock(\Doctr...M\EntityManager::class)` of type `object<PHPUnit\Framework\MockObject\MockObject>` is incompatible with the declared type `object<Doctrine\ORM\EntityManager>` of property `$em`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
31			}
32
33			return $this->em;
34			}
35
36			public function setUp(): void
37			{
38			$em = $this->getEm();
39			$object = new OAuthUserFinder($em, User::class);
			0 ignored issues – show Bug introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report It seems like `$em` defined by `$this->getEm()` on line `38` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Kunstmaan\AdminBundle\He...erFinder::__construct()` does only seem to accept `object<Doctrine\ORM\EntityManagerInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
40			$this->object = $object;
41			}
42
43			public function testFindUserByGoogleSignInData()
44			{
45			$object = $this->object;
46			$repo = $this->createMock(EntityRepository::class);
47			$repo->expects($this->exactly(3))->method('findOneBy')->will($this->onConsecutiveCalls(new DateTime(), new DateTime(), new User()));
48			$this->getEm()->expects($this->exactly(3))->method('getRepository')->willReturn($repo);
			0 ignored issues – show Bug introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit\Framework\MockObject\MockObject`, but not in `Doctrine\ORM\EntityManager`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
49			$user = $object->findUserByGoogleSignInData('[email protected]', 12345679);
50			$this->assertInstanceOf(User::class, $user);
51			}
52			}
53

Kunstmaan / KunstmaanBundlesCMS

Pull Request — master (#2748)

testFindUserByGoogleSignInData() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like