Issues in KunstmaanVotingExtensionTest.php - All Issues - Inspection of "Merge pull request #2346 from deZinc/refactor-admi..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1db3cd...632e40 )

by Jeroen

created 2019-02-12 10:53 UTC

KunstmaanVotingExtensionTest.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\VotingBundle\Tests\DependencyInjection;

use Kunstmaan\VotingBundle\DependencyInjection\KunstmaanVotingExtension;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ContainerBuilder;

class KunstmaanVotingExtensionTest extends TestCase
{
    /**
     * @var KunstmaanVotingExtension
     */
    private $extension;

    /**
     * Root name of the configuration
     *
     * @var string
     */
    private $root;

    public function setUp()
    {
        parent::setUp();

        $this->extension = $this->getExtension();
        $this->root = 'kuma_voting';
    }

    public function testGetConfigWithOverrideDefaultValue()

    {
        $container = $this->getContainer();
        $container->setParameter('voting_default_value', 2);
        $this->extension->load([['actions' => [['name' => 'foo', 'max_number_by_ip' => 2]]]], $container);
        $this->assertTrue($container->hasParameter($this->root . '.actions'));
        $this->assertTrue(is_array($container->getParameter($this->root . '.actions')));

        $actions = $container->getParameter($this->root . '.actions');
        if (isset($actions['up_vote'])) {
            $this->assertEquals(2, $actions['up_vote']['default_value']);
        }
        if (isset($actions['down_vote'])) {
            $this->assertEquals(-2, $actions['down_vote']['default_value']);
        }
        if (isset($actions['facebook_like'])) {
            $this->assertEquals(2, $actions['facebook_like']['default_value']);
        }
    }

    public function testGetConfigWithDefaultValues()
    {
        $container = $this->getContainer();
        $this->extension->load(array(array()), $container);
        $this->assertTrue($container->hasParameter($this->root . '.actions'));
        $this->assertTrue(is_array($container->getParameter($this->root . '.actions')));

        $actions = $container->getParameter($this->root . '.actions');
        if (isset($actions['up_vote'])) {
            $this->assertEquals(1, $actions['up_vote']['default_value']);
        }
        if (isset($actions['down_vote'])) {
            $this->assertEquals(-1, $actions['down_vote']['default_value']);
        }
        if (isset($actions['facebook_like'])) {
            $this->assertEquals(1, $actions['facebook_like']['default_value']);
        }
    }

    public function testGetConfigWithOverrideValues()

    {
        $configs = array(
            'actions' => array(
                'up_vote' => array(
                    'default_value' => '2',
                ),
                'down_vote' => array(
                    'default_value' => '-5',
                ),
            ),
        );

        $container = $this->getContainer();
        $this->extension->load(array($configs), $container);
        $this->assertTrue($container->hasParameter($this->root . '.actions'));
        $this->assertTrue(is_array($container->getParameter($this->root . '.actions')));

        $actions = $container->getParameter($this->root . '.actions');
        if (isset($actions['up_vote'])) {
            $this->assertEquals(2, $actions['up_vote']['default_value']);
        }
        if (isset($actions['down_vote'])) {
            $this->assertEquals(-5, $actions['down_vote']['default_value']);
        }
        if (isset($actions['facebook_like'])) {
            $this->assertEquals(1, $actions['facebook_like']['default_value']);
        }
    }

    /**
     * @return KunstmaanVotingExtension
     */
    protected function getExtension()
    {
        return new KunstmaanVotingExtension();
    }

    /**
     * @return ContainerBuilder
     */
    private function getContainer()
    {
        return new ContainerBuilder();
    }
}


1		<?php
2
3		namespace Kunstmaan\VotingBundle\Tests\DependencyInjection;
4
5		use Kunstmaan\VotingBundle\DependencyInjection\KunstmaanVotingExtension;
6		use PHPUnit\Framework\TestCase;
7		use Symfony\Component\DependencyInjection\ContainerBuilder;
8
9		class KunstmaanVotingExtensionTest extends TestCase
10		{
11		/**
12		* @var KunstmaanVotingExtension
13		*/
14		private $extension;
15
16		/**
17		* Root name of the configuration
18		*
19		* @var string
20		*/
21		private $root;
22
23		public function setUp()
24		{
25		parent::setUp();
26
27		$this->extension = $this->getExtension();
28		$this->root = 'kuma_voting';
29		}
30
31	View Code Duplication	public function testGetConfigWithOverrideDefaultValue()
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		$container = $this->getContainer();
34		$container->setParameter('voting_default_value', 2);
35		$this->extension->load([['actions' => [['name' => 'foo', 'max_number_by_ip' => 2]]]], $container);
36		$this->assertTrue($container->hasParameter($this->root . '.actions'));
37		$this->assertTrue(is_array($container->getParameter($this->root . '.actions')));
38
39		$actions = $container->getParameter($this->root . '.actions');
40		if (isset($actions['up_vote'])) {
41		$this->assertEquals(2, $actions['up_vote']['default_value']);
42		}
43		if (isset($actions['down_vote'])) {
44		$this->assertEquals(-2, $actions['down_vote']['default_value']);
45		}
46		if (isset($actions['facebook_like'])) {
47		$this->assertEquals(2, $actions['facebook_like']['default_value']);
48		}
49		}
50
51		public function testGetConfigWithDefaultValues()
52		{
53		$container = $this->getContainer();
54		$this->extension->load(array(array()), $container);
55		$this->assertTrue($container->hasParameter($this->root . '.actions'));
56		$this->assertTrue(is_array($container->getParameter($this->root . '.actions')));
57
58		$actions = $container->getParameter($this->root . '.actions');
59		if (isset($actions['up_vote'])) {
60		$this->assertEquals(1, $actions['up_vote']['default_value']);
61		}
62		if (isset($actions['down_vote'])) {
63		$this->assertEquals(-1, $actions['down_vote']['default_value']);
64		}
65		if (isset($actions['facebook_like'])) {
66		$this->assertEquals(1, $actions['facebook_like']['default_value']);
67		}
68		}
69
70	View Code Duplication	public function testGetConfigWithOverrideValues()
		0 ignored issues – show Duplication introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		$configs = array(
73		'actions' => array(
74		'up_vote' => array(
75		'default_value' => '2',
76		),
77		'down_vote' => array(
78		'default_value' => '-5',
79		),
80		),
81		);
82
83		$container = $this->getContainer();
84		$this->extension->load(array($configs), $container);
85		$this->assertTrue($container->hasParameter($this->root . '.actions'));
86		$this->assertTrue(is_array($container->getParameter($this->root . '.actions')));
87
88		$actions = $container->getParameter($this->root . '.actions');
89		if (isset($actions['up_vote'])) {
90		$this->assertEquals(2, $actions['up_vote']['default_value']);
91		}
92		if (isset($actions['down_vote'])) {
93		$this->assertEquals(-5, $actions['down_vote']['default_value']);
94		}
95		if (isset($actions['facebook_like'])) {
96		$this->assertEquals(1, $actions['facebook_like']['default_value']);
97		}
98		}
99
100		/**
101		* @return KunstmaanVotingExtension
102		*/
103		protected function getExtension()
104		{
105		return new KunstmaanVotingExtension();
106		}
107
108		/**
109		* @return ContainerBuilder
110		*/
111		private function getContainer()
112		{
113		return new ContainerBuilder();
114		}
115		}
116

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 1db3cd...632e40 )

KunstmaanVotingExtensionTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like