Issues in ExceptionController.php - All Issues - Inspection of "Merge pull request #2346 from deZinc/refactor-admi..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1db3cd...632e40 )

by Jeroen

created 2019-02-12 10:53 UTC

AdminBundle/Controller/ExceptionController.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Controller;

use Doctrine\ORM\EntityManager;
use Kunstmaan\AdminBundle\AdminList\ExceptionAdminListConfigurator;
use Kunstmaan\AdminBundle\Entity\Exception;
use Kunstmaan\AdminListBundle\Controller\AdminListController;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;

class ExceptionController extends AdminListController
{
    private function getAdminListConfigurator()
    {
        if (!isset($this->configurator)) {
            $this->configurator = new ExceptionAdminListConfigurator($this->getEntityManager());
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        return $this->configurator;
    }

    /**
     * @Route("/", name="kunstmaanadminbundle_admin_exception")
     */
    public function indexAction(Request $request)
    {
        return parent::doIndexAction($this->getAdminListConfigurator(), $request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @Route("/resolve_all", name="kunstmaanadminbundle_admin_exception_resolve_all")
     *
     * @return RedirectResponse
     *
     * @throws \Doctrine\ORM\NonUniqueResultException
     * @throws \Doctrine\ORM\NoResultException
     * @throws \InvalidArgumentException
     */
    public function resolveAllAction()
    {
        $this->getEntityManager()->getRepository(Exception::class)->markAllAsResolved();

        $indexUrl = $this->getAdminListConfigurator()->getIndexUrl();

        return new RedirectResponse(
            $this->generateUrl(
                $indexUrl['path'],
                isset($indexUrl['params']) ? $indexUrl['params'] : array()
            )
        );
    }

    /**
     * @Route("/toggle_resolve/{id}", name="kunstmaanadminbundle_admin_exception_toggle_resolve")
     *
     * @param Request   $request
     * @param Exception $model
     *
     * @return RedirectResponse
     *
     * @throws \Doctrine\ORM\OptimisticLockException
     * @throws \InvalidArgumentException
     * @throws \Doctrine\ORM\ORMInvalidArgumentException
     */
    public function toggleResolveAction(Request $request, Exception $model)
    {
        /* @var EntityManager $em */
        $em = $this->getEntityManager();

        $this->getAdminListConfigurator();

        $model->setResolved(!$model->isResolved());

        $em->persist($model);
        $em->flush();

        $indexUrl = $this->configurator->getIndexUrl();

        return new RedirectResponse(
            $this->generateUrl(
                $indexUrl['path'],
                isset($indexUrl['params']) ? $indexUrl['params'] : array()
            )
        );
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminBundle\Controller;
4
5			use Doctrine\ORM\EntityManager;
6			use Kunstmaan\AdminBundle\AdminList\ExceptionAdminListConfigurator;
7			use Kunstmaan\AdminBundle\Entity\Exception;
8			use Kunstmaan\AdminListBundle\Controller\AdminListController;
9			use Symfony\Component\Routing\Annotation\Route;
10			use Symfony\Component\HttpFoundation\RedirectResponse;
11			use Symfony\Component\HttpFoundation\Request;
12
13			class ExceptionController extends AdminListController
14			{
15			private function getAdminListConfigurator()
16			{
17			if (!isset($this->configurator)) {
18			$this->configurator = new ExceptionAdminListConfigurator($this->getEntityManager());
			0 ignored issues – show Bug introduced 2018-04-18 13:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `configurator` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			}
20
21			return $this->configurator;
22			}
23
24			/**
25			* @Route("/", name="kunstmaanadminbundle_admin_exception")
26			*/
27			public function indexAction(Request $request)
28			{
29			return parent::doIndexAction($this->getAdminListConfigurator(), $request);
			0 ignored issues – show Comprehensibility Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`doIndexAction()` instead of `indexAction()`). Are you sure this is correct? If so, you might want to change this to `$this->doIndexAction()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
30			}
31
32			/**
33			* @Route("/resolve_all", name="kunstmaanadminbundle_admin_exception_resolve_all")
34			*
35			* @return RedirectResponse
36			*
37			* @throws \Doctrine\ORM\NonUniqueResultException
38			* @throws \Doctrine\ORM\NoResultException
39			* @throws \InvalidArgumentException
40			*/
41			public function resolveAllAction()
42			{
43			$this->getEntityManager()->getRepository(Exception::class)->markAllAsResolved();
44
45			$indexUrl = $this->getAdminListConfigurator()->getIndexUrl();
46
47			return new RedirectResponse(
48			$this->generateUrl(
49			$indexUrl['path'],
50			isset($indexUrl['params']) ? $indexUrl['params'] : array()
51			)
52			);
53			}
54
55			/**
56			* @Route("/toggle_resolve/{id}", name="kunstmaanadminbundle_admin_exception_toggle_resolve")
57			*
58			* @param Request $request
59			* @param Exception $model
60			*
61			* @return RedirectResponse
62			*
63			* @throws \Doctrine\ORM\OptimisticLockException
64			* @throws \InvalidArgumentException
65			* @throws \Doctrine\ORM\ORMInvalidArgumentException
66			*/
67			public function toggleResolveAction(Request $request, Exception $model)
68			{
69			/* @var EntityManager $em */
70			$em = $this->getEntityManager();
71
72			$this->getAdminListConfigurator();
73
74			$model->setResolved(!$model->isResolved());
75
76			$em->persist($model);
77			$em->flush();
78
79			$indexUrl = $this->configurator->getIndexUrl();
80
81			return new RedirectResponse(
82			$this->generateUrl(
83			$indexUrl['path'],
84			isset($indexUrl['params']) ? $indexUrl['params'] : array()
85			)
86			);
87			}
88			}
89

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 1db3cd...632e40 )

AdminBundle/Controller/ExceptionController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like