Kunstmaan\AdminListBundle\Traits\ChangeableLimitTrait

Complexity

Total Complexity

14

Size/Duplication

Total Lines	82
Duplicated Lines	15.85 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
C	bindRequest()	13	53	12
A	getLimit()	0	4	1
A	getLimitOptions()	0	9	1

<?php

namespace Kunstmaan\AdminListBundle\Traits;

use Symfony\Component\HttpFoundation\Request;

/**
 * Trait ChangeableLimitTrait
 */
trait ChangeableLimitTrait
{
    private $limit;

    /**
     * Bind current request.
     *
     * @param Request $request
     */
    public function bindRequest(Request $request)
    {
        $query = $request->query;
        $session = $request->getSession();

        $adminListName = 'listconfig_' . $request->get('_route');

        $this->page = $request->query->getInt('page', 1);

The property page does not exist. Did you maybe forget to declare it?

        $this->limit = $request->query->getInt('limit', $this->getLimitOptions()[0]);

        $adminListSessionData = $request->getSession()->get($adminListName);
        if (!$query->has('limit') && null !== $adminListSessionData && isset($adminListSessionData['limit'])) {
            $this->limit = $adminListSessionData['limit'];
        }

        if ($request->query->has('limit') && !$request->query->has('page')) {
            $this->page = 1;
        }

        // Allow alphanumeric, _ & . in order by parameter!
        $this->orderBy = preg_replace('/[^[a-zA-Z0-9\_\.]]/', '', $request->query->get('orderBy', ''));

The property orderBy does not exist. Did you maybe forget to declare it?

        $this->orderDirection = $request->query->getAlpha('orderDirection', '');

The property orderDirection does not exist. Did you maybe forget to declare it?

        // there is a session and the filter param is not set
        if ($session->has($adminListName) && !$query->has('filter')) {

This code seems to be duplicated across your project.

            if (!$query->has('page') && !$query->has('limit')) {
                $this->page = $adminListSessionData['page'];
            }

            if (!$query->has('orderBy')) {
                $this->orderBy = $adminListSessionData['orderBy'];
            }

            if (!$query->has('orderDirection')) {
                $this->orderDirection = $adminListSessionData['orderDirection'];
            }
        }

        // save current parameters
        $session->set(
            $adminListName,
            [
                'page' => $this->page,
                'limit' => $this->limit,
                'orderBy' => $this->orderBy,
                'orderDirection' => $this->orderDirection,
            ]
        );

        // Remove limit from query param so it doesn't affect the session of the filter builder
        $request->query->remove('limit');
        $this->getFilterBuilder()->bindRequest($request);

It seems like getFilterBuilder() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @return int
     */
    public function getLimit()
    {
        return $this->limit;
    }

    /** @return array */

Consider making the return type a bit more specific; maybe use integer[].

    public function getLimitOptions()
    {
        return [
            10,
            20,
            50,
            100,
        ];
    }
}