Issues in CloneListenerTest.php - All Issues - Inspection of "[AllBundles] Switch from styleci to flintci" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 5.6 (#2830)

by Jeroen

created 2020-11-06 12:16 UTC

Tests/unit/EventListener/CloneListenerTest.php (3 issues)

Labels

Documentation 3

Severity

Maciej Łebkowski 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\PagePartBundle\Tests\EventListener;

use Kunstmaan\AdminBundle\Event\DeepCloneAndSaveEvent;
use Kunstmaan\PagePartBundle\Entity\PagePartRef;
use Kunstmaan\PagePartBundle\Entity\PageTemplateConfiguration;
use Kunstmaan\PagePartBundle\EventListener\CloneListener;
use Kunstmaan\PagePartBundle\Helper\HasPagePartsInterface;
use Kunstmaan\PagePartBundle\Helper\HasPageTemplateInterface;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfigurator;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationReaderInterface;
use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationService;
use Kunstmaan\PagePartBundle\Repository\PagePartRefRepository;
use PHPUnit\Framework\TestCase;

/**
 * Class CloneListenerTest
 */
class CloneListenerTest extends TestCase
{
    /**
     * @var \Doctrine\ORM\EntityManager|\PHPUnit_Framework_MockObject_MockObject
     */
    private $em;

    /**
     * @var PagePartAdminConfiguratorInterface
     */
    private $configurator;

    /**
     * @var \Doctrine\ORM\EntityRepository|\PHPUnit_Framework_MockObject_MockObject
     */
    private $repo;

    /**
     * @var CloneListener
     */
    private $object;

    /**
     * @var PagePartConfigurationReaderInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $reader;

    /**
     * @var PageTemplateConfigurationService|\PHPUnit_Framework_MockObject_MockObject
     */
    private $templateService;

    protected function setUp()
    {
        $this->em = $this->getMockBuilder('Doctrine\ORM\EntityManager')
            ->disableOriginalConstructor()
            ->getMock();

        $this->repo = $this->getMockBuilder(PagePartRefRepository::class)
            ->disableOriginalConstructor()
            ->getMock();

        $this->em->expects($this->any())
            ->method('getRepository')
            ->with($this->equalTo(PagePartRef::class))
            ->willReturn($this->repo);

        $this->configurator = new PagePartAdminConfigurator();
        $this->configurator->setContext('main');

        $this->reader = $this->createMock(PagePartConfigurationReaderInterface::class);
        $this->reader
            ->expects($this->any())
            ->method('getPagePartAdminConfigurators')
            ->willReturn([$this->configurator]);

        $this->reader
            ->expects($this->any())
            ->method('getPagePartContexts')
            ->willReturn([$this->configurator->getContext()]);

        $this->templateService = $this->getMockBuilder(PageTemplateConfigurationService::class)->disableOriginalConstructor()->getMock();

        $this->object = new CloneListener($this->em, $this->reader, $this->templateService);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testClonePagePart()
    {
        $entity = $this->createMock(HasPagePartsInterface::class);

        $clone = clone $entity;

        $this->repo->expects($this->once())
            ->method('copyPageParts')
            ->with($this->em, $entity, $clone, 'main');

        $event = new DeepCloneAndSaveEvent($entity, $clone);
        $this->object->postDeepCloneAndSave($event);
    }

    public function testClonePageTemplate()
    {
        $entity = $this->createMock(HasPageTemplateInterface::class);

        /** @var HasPageTemplateInterface|\PHPUnit_Framework_MockObject_MockObject $clone */
        $clone = clone $entity;

        $entity->expects($this->any())
            ->method('getId')
            ->willReturn(1);

        $clone->expects($this->any())
            ->method('getId')
            ->willReturn(2);

        $this->repo->expects($this->once())
            ->method('copyPageParts')
            ->with($this->em, $entity, $clone, 'main');

        $configuration = new PageTemplateConfiguration();
        $configuration->setId(1);
        $configuration->setPageId(1);

        $this->templateService->expects($this->once())
            ->method('findOrCreateFor')
            ->with($this->identicalTo($entity))
            ->willReturn($configuration);

        $newConfiguration = clone $configuration;
        $newConfiguration->setId(null);
        $newConfiguration->setPageId($clone->getId());

        $this->em->expects($this->once())
            ->method('persist')
            ->with($newConfiguration);

        $event = new DeepCloneAndSaveEvent($entity, $clone);
        $this->object->postDeepCloneAndSave($event);
    }
}


1		<?php
2
3		namespace Kunstmaan\PagePartBundle\Tests\EventListener;
4
5		use Kunstmaan\AdminBundle\Event\DeepCloneAndSaveEvent;
6		use Kunstmaan\PagePartBundle\Entity\PagePartRef;
7		use Kunstmaan\PagePartBundle\Entity\PageTemplateConfiguration;
8		use Kunstmaan\PagePartBundle\EventListener\CloneListener;
9		use Kunstmaan\PagePartBundle\Helper\HasPagePartsInterface;
10		use Kunstmaan\PagePartBundle\Helper\HasPageTemplateInterface;
11		use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfigurator;
12		use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
13		use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationReaderInterface;
14		use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationService;
15		use Kunstmaan\PagePartBundle\Repository\PagePartRefRepository;
16		use PHPUnit\Framework\TestCase;
17
18		/**
19		* Class CloneListenerTest
20		*/
21		class CloneListenerTest extends TestCase
22		{
23		/**
24		* @var \Doctrine\ORM\EntityManager\|\PHPUnit_Framework_MockObject_MockObject
25		*/
26		private $em;
27
28		/**
29		* @var PagePartAdminConfiguratorInterface
30		*/
31		private $configurator;
32
33		/**
34		* @var \Doctrine\ORM\EntityRepository\|\PHPUnit_Framework_MockObject_MockObject
35		*/
36		private $repo;
37
38		/**
39		* @var CloneListener
40		*/
41		private $object;
42
43		/**
44		* @var PagePartConfigurationReaderInterface\|\PHPUnit_Framework_MockObject_MockObject
45		*/
46		private $reader;
47
48		/**
49		* @var PageTemplateConfigurationService\|\PHPUnit_Framework_MockObject_MockObject
50		*/
51		private $templateService;
52
53		protected function setUp()
54		{
55		$this->em = $this->getMockBuilder('Doctrine\ORM\EntityManager')
56		->disableOriginalConstructor()
57		->getMock();
58
59		$this->repo = $this->getMockBuilder(PagePartRefRepository::class)
60		->disableOriginalConstructor()
61		->getMock();
62
63		$this->em->expects($this->any())
64		->method('getRepository')
65		->with($this->equalTo(PagePartRef::class))
66		->willReturn($this->repo);
67
68		$this->configurator = new PagePartAdminConfigurator();
69		$this->configurator->setContext('main');
70
71		$this->reader = $this->createMock(PagePartConfigurationReaderInterface::class);
72		$this->reader
73		->expects($this->any())
74		->method('getPagePartAdminConfigurators')
75		->willReturn([$this->configurator]);
76
77		$this->reader
78		->expects($this->any())
79		->method('getPagePartContexts')
80		->willReturn([$this->configurator->getContext()]);
81
82		$this->templateService = $this->getMockBuilder(PageTemplateConfigurationService::class)->disableOriginalConstructor()->getMock();
83
84		$this->object = new CloneListener($this->em, $this->reader, $this->templateService);
		0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->em` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ORM\EntityManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->reader` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Kunstmaan\PagePar...urationReaderInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->templateService` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Kunstmaan\PagePar...teConfigurationService>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85		}
86
87	View Code Duplication	public function testClonePagePart()
88		{
89		$entity = $this->createMock(HasPagePartsInterface::class);
90
91		$clone = clone $entity;
92
93		$this->repo->expects($this->once())
94		->method('copyPageParts')
95		->with($this->em, $entity, $clone, 'main');
96
97		$event = new DeepCloneAndSaveEvent($entity, $clone);
98		$this->object->postDeepCloneAndSave($event);
99		}
100
101		public function testClonePageTemplate()
102		{
103		$entity = $this->createMock(HasPageTemplateInterface::class);
104
105		/** @var HasPageTemplateInterface\|\PHPUnit_Framework_MockObject_MockObject $clone */
106		$clone = clone $entity;
107
108		$entity->expects($this->any())
109		->method('getId')
110		->willReturn(1);
111
112		$clone->expects($this->any())
113		->method('getId')
114		->willReturn(2);
115
116		$this->repo->expects($this->once())
117		->method('copyPageParts')
118		->with($this->em, $entity, $clone, 'main');
119
120		$configuration = new PageTemplateConfiguration();
121		$configuration->setId(1);
122		$configuration->setPageId(1);
123
124		$this->templateService->expects($this->once())
125		->method('findOrCreateFor')
126		->with($this->identicalTo($entity))
127		->willReturn($configuration);
128
129		$newConfiguration = clone $configuration;
130		$newConfiguration->setId(null);
131		$newConfiguration->setPageId($clone->getId());
132
133		$this->em->expects($this->once())
134		->method('persist')
135		->with($newConfiguration);
136
137		$event = new DeepCloneAndSaveEvent($entity, $clone);
138		$this->object->postDeepCloneAndSave($event);
139		}
140		}
141

Kunstmaan / KunstmaanBundlesCMS

Pull Request — 5.6 (#2830)

Tests/unit/EventListener/CloneListenerTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like