Issues in URLHelper.php - All Issues - Inspection of "[AllBundles] Switch from styleci to flintci" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 5.6 (#2830)

by Jeroen

created 2020-11-06 12:16 UTC

src/Kunstmaan/NodeBundle/Helper/URLHelper.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Derek Stephen McLean 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\NodeBundle\Helper;

use Doctrine\ORM\EntityManager;
use Kunstmaan\AdminBundle\Helper\DomainConfigurationInterface;
use Kunstmaan\NodeBundle\Validation\URLValidator;
use Psr\Log\LoggerInterface;
use Symfony\Component\Routing\RouterInterface;

/**
 * A helper for replacing url's
 */
class URLHelper
{
    use URLValidator;

    /**
     * @var EntityManager
     */
    private $em;

    /**
     * @var RouterInterface
     */
    private $router;

    /**
     * @var LoggerInterface
     */
    private $logger;

    /** @var array */
    private $nodeTranslationCache = [];

    /** @var array */
    private $mediaCache = [];

    /**
     * @var DomainConfigurationInterface
     */
    private $domainConfiguration;

    public function __construct(EntityManager $em, RouterInterface $router, LoggerInterface $logger, DomainConfigurationInterface $domainConfiguration)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->em = $em;
        $this->router = $router;
        $this->logger = $logger;
        $this->domainConfiguration = $domainConfiguration;
    }

    /**
     * Replace a given text, according to the node translation id and the multidomain site id.
     *
     * @param string $text
     *
     * @return string
     */
    public function replaceUrl($text)
    {
        if ($this->isEmailAddress($text)) {
            $text = sprintf('%s:%s', 'mailto', $text);
        }

        if ($this->isInternalLink($text)) {
            preg_match_all("/\[(([a-z_A-Z\.]+):)?NT([0-9]+)\]/", $text, $matches, PREG_SET_ORDER);

            if (\count($matches) > 0) {
                foreach ($matches as $match) {
                    $fullTag = $match[0];
                    $hostId = $match[2];

                    $hostConfig = !empty($hostId) ? $this->domainConfiguration->getFullHostById($hostId) : null;
                    $host = null !== $hostConfig && array_key_exists('host', $hostConfig) ? $hostConfig['host'] : null;
                    $hostBaseUrl = $this->domainConfiguration->getHostBaseUrl($host);

                    $nodeTranslationId = $match[3];
                    $nodeTranslation = $this->getNodeTranslation($nodeTranslationId);

                    if ($nodeTranslation) {
                        $urlParams = ['url' => $nodeTranslation['url']];
                        // Only add locale if multilingual site
                        if ($this->domainConfiguration->isMultiLanguage($host)) {
                            $urlParams['_locale'] = $nodeTranslation['lang'];
                        }

                        // Only add other site, when having this.
                        if ($hostId) {
                            $urlParams['otherSite'] = $hostId;
                        }

                        $url = $this->router->generate('_slug', $urlParams);

                        $text = str_replace($fullTag, $hostId ? $hostBaseUrl . $url : $url, $text);
                    } else {
                        $this->logger->error('No NodeTranslation found in the database when replacing url tag ' . $fullTag);
                    }
                }
            }
        }

        if ($this->isInternalMediaLink($text)) {
            preg_match_all("/\[(([a-z_A-Z]+):)?M([0-9]+)\]/", $text, $matches, PREG_SET_ORDER);

            if (\count($matches) > 0) {
                foreach ($matches as $match) {
                    $fullTag = $match[0];
                    $mediaId = $match[3];

                    $mediaItem = $this->getMedia($mediaId);
                    if ($mediaItem) {
                        $text = str_replace($fullTag, $mediaItem['url'], $text);
                    } else {
                        $this->logger->error('No Media found in the database when replacing url tag ' . $fullTag);
                    }
                }
            }
        }

        return $text;
    }

    private function getNodeTranslation($nodeTranslationId): array
    {
        if (isset($this->nodeTranslationCache[$nodeTranslationId])) {
            return $this->nodeTranslationCache[$nodeTranslationId];
        }

        $stmt = $this->em->getConnection()->executeQuery(
            'SELECT url, lang FROM kuma_node_translations WHERE id = :nodeTranslationId',
            ['nodeTranslationId' => $nodeTranslationId]
        );
        $nodeTranslation = $stmt->fetch();

        $this->nodeTranslationCache[$nodeTranslationId] = $nodeTranslation;

        return $nodeTranslation;
    }

    private function getMedia($mediaId): array
    {
        if (isset($this->mediaCache[$mediaId])) {
            return $this->mediaCache[$mediaId];
        }

        $stmt = $this->em->getConnection()->executeQuery(
            'SELECT url FROM kuma_media WHERE id = :mediaId',
            ['mediaId' => $mediaId]
        );
        $media = $stmt->fetch();

        $this->mediaCache[$mediaId] = $media;

        return $media;
    }
}


1		<?php
2
3		namespace Kunstmaan\NodeBundle\Helper;
4
5		use Doctrine\ORM\EntityManager;
6		use Kunstmaan\AdminBundle\Helper\DomainConfigurationInterface;
7		use Kunstmaan\NodeBundle\Validation\URLValidator;
8		use Psr\Log\LoggerInterface;
9		use Symfony\Component\Routing\RouterInterface;
10
11		/**
12		* A helper for replacing url's
13		*/
14		class URLHelper
15		{
16		use URLValidator;
17
18		/**
19		* @var EntityManager
20		*/
21		private $em;
22
23		/**
24		* @var RouterInterface
25		*/
26		private $router;
27
28		/**
29		* @var LoggerInterface
30		*/
31		private $logger;
32
33		/** @var array */
34		private $nodeTranslationCache = [];
35
36		/** @var array */
37		private $mediaCache = [];
38
39		/**
40		* @var DomainConfigurationInterface
41		*/
42		private $domainConfiguration;
43
44	3	public function __construct(EntityManager $em, RouterInterface $router, LoggerInterface $logger, DomainConfigurationInterface $domainConfiguration)
		0 ignored issues – show Bug introduced 2018-04-18 13:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this You have injected the EntityManager via parameter `$em`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
45		{
46	3	$this->em = $em;
47	3	$this->router = $router;
48	3	$this->logger = $logger;
49	3	$this->domainConfiguration = $domainConfiguration;
50	3	}
51
52		/**
53		* Replace a given text, according to the node translation id and the multidomain site id.
54		*
55		* @param string $text
56		*
57		* @return string
58		*/
59	3	public function replaceUrl($text)
60		{
61	3	if ($this->isEmailAddress($text)) {
62	1	$text = sprintf('%s:%s', 'mailto', $text);
63		}
64
65	3	if ($this->isInternalLink($text)) {
66	1	preg_match_all("/\[(([a-z_A-Z\.]+):)?NT([0-9]+)\]/", $text, $matches, PREG_SET_ORDER);
67
68	1	if (\count($matches) > 0) {
69	1	foreach ($matches as $match) {
70	1	$fullTag = $match[0];
71	1	$hostId = $match[2];
72
73	1	$hostConfig = !empty($hostId) ? $this->domainConfiguration->getFullHostById($hostId) : null;
74	1	$host = null !== $hostConfig && array_key_exists('host', $hostConfig) ? $hostConfig['host'] : null;
75	1	$hostBaseUrl = $this->domainConfiguration->getHostBaseUrl($host);
76
77	1	$nodeTranslationId = $match[3];
78	1	$nodeTranslation = $this->getNodeTranslation($nodeTranslationId);
79
80	1	if ($nodeTranslation) {
81	1	$urlParams = ['url' => $nodeTranslation['url']];
82		// Only add locale if multilingual site
83	1	if ($this->domainConfiguration->isMultiLanguage($host)) {
84		$urlParams['_locale'] = $nodeTranslation['lang'];
85		}
86
87		// Only add other site, when having this.
88	1	if ($hostId) {
89		$urlParams['otherSite'] = $hostId;
90		}
91
92	1	$url = $this->router->generate('_slug', $urlParams);
93
94	1	$text = str_replace($fullTag, $hostId ? $hostBaseUrl . $url : $url, $text);
95		} else {
96		$this->logger->error('No NodeTranslation found in the database when replacing url tag ' . $fullTag);
97		}
98		}
99		}
100		}
101
102	3	if ($this->isInternalMediaLink($text)) {
103	1	preg_match_all("/\[(([a-z_A-Z]+):)?M([0-9]+)\]/", $text, $matches, PREG_SET_ORDER);
104
105	1	if (\count($matches) > 0) {
106	1	foreach ($matches as $match) {
107	1	$fullTag = $match[0];
108	1	$mediaId = $match[3];
109
110	1	$mediaItem = $this->getMedia($mediaId);
111	1	if ($mediaItem) {
112	1	$text = str_replace($fullTag, $mediaItem['url'], $text);
113		} else {
114		$this->logger->error('No Media found in the database when replacing url tag ' . $fullTag);
115		}
116		}
117		}
118		}
119
120	3	return $text;
121		}
122
123	1	private function getNodeTranslation($nodeTranslationId): array
124		{
125	1	if (isset($this->nodeTranslationCache[$nodeTranslationId])) {
126	1	return $this->nodeTranslationCache[$nodeTranslationId];
127		}
128
129	1	$stmt = $this->em->getConnection()->executeQuery(
130	1	'SELECT url, lang FROM kuma_node_translations WHERE id = :nodeTranslationId',
131	1	['nodeTranslationId' => $nodeTranslationId]
132		);
133	1	$nodeTranslation = $stmt->fetch();
134
135	1	$this->nodeTranslationCache[$nodeTranslationId] = $nodeTranslation;
136
137	1	return $nodeTranslation;
138		}
139
140	1	private function getMedia($mediaId): array
141		{
142	1	if (isset($this->mediaCache[$mediaId])) {
143	1	return $this->mediaCache[$mediaId];
144		}
145
146	1	$stmt = $this->em->getConnection()->executeQuery(
147	1	'SELECT url FROM kuma_media WHERE id = :mediaId',
148	1	['mediaId' => $mediaId]
149		);
150	1	$media = $stmt->fetch();
151
152	1	$this->mediaCache[$mediaId] = $media;
153
154	1	return $media;
155		}
156		}
157

Kunstmaan / KunstmaanBundlesCMS

Pull Request — 5.6 (#2830)

src/Kunstmaan/NodeBundle/Helper/URLHelper.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like