Completed
Pull Request — 5.6 (#2830)
by Jeroen
14:14
created

AdminBundle/Controller/ExceptionController.php (1 issue)

mismatching argument types where a subclass or implementation is assumed.

Compatibility Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace Kunstmaan\AdminBundle\Controller;
4
5
use Doctrine\ORM\EntityManager;
6
use Kunstmaan\AdminBundle\AdminList\ExceptionAdminListConfigurator;
7
use Kunstmaan\AdminBundle\Entity\Exception;
8
use Kunstmaan\AdminListBundle\Controller\AdminListController;
9
use Symfony\Component\HttpFoundation\RedirectResponse;
10
use Symfony\Component\HttpFoundation\Request;
11
use Symfony\Component\Routing\Annotation\Route;
12
13
class ExceptionController extends AdminListController
14
{
15
    /** @var ExceptionAdminListConfigurator */
16
    private $configurator;
17
18
    private function getAdminListConfigurator()
19
    {
20
        if (!isset($this->configurator)) {
21
            $this->configurator = new ExceptionAdminListConfigurator($this->getEntityManager());
0 ignored issues
show
$this->getEntityManager() of type object<Doctrine\Persistence\ObjectManager> is not a sub-type of object<Doctrine\ORM\EntityManager>. It seems like you assume a concrete implementation of the interface Doctrine\Persistence\ObjectManager to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
22
        }
23
24
        return $this->configurator;
25
    }
26
27
    /**
28
     * @Route("/", name="kunstmaanadminbundle_admin_exception")
29
     */
30
    public function indexAction(Request $request)
31
    {
32
        return parent::doIndexAction($this->getAdminListConfigurator(), $request);
33
    }
34
35
    /**
36
     * @Route("/resolve_all", name="kunstmaanadminbundle_admin_exception_resolve_all")
37
     *
38
     * @return RedirectResponse
39
     *
40
     * @throws \Doctrine\ORM\NonUniqueResultException
41
     * @throws \Doctrine\ORM\NoResultException
42
     * @throws \InvalidArgumentException
43
     */
44
    public function resolveAllAction()
45
    {
46
        $this->getEntityManager()->getRepository(Exception::class)->markAllAsResolved();
47
48
        $indexUrl = $this->getAdminListConfigurator()->getIndexUrl();
49
50
        return new RedirectResponse(
51
            $this->generateUrl(
52
                $indexUrl['path'],
53
                isset($indexUrl['params']) ? $indexUrl['params'] : []
54
            )
55
        );
56
    }
57
58
    /**
59
     * @Route("/toggle_resolve/{id}", name="kunstmaanadminbundle_admin_exception_toggle_resolve")
60
     *
61
     * @return RedirectResponse
62
     *
63
     * @throws \Doctrine\ORM\OptimisticLockException
64
     * @throws \InvalidArgumentException
65
     * @throws \Doctrine\ORM\ORMInvalidArgumentException
66
     */
67
    public function toggleResolveAction(Request $request, Exception $model)
68
    {
69
        /* @var EntityManager $em */
70
        $em = $this->getEntityManager();
71
72
        $this->getAdminListConfigurator();
73
74
        $model->setResolved(!$model->isResolved());
75
76
        $em->persist($model);
77
        $em->flush();
78
79
        $indexUrl = $this->configurator->getIndexUrl();
80
81
        return new RedirectResponse(
82
            $this->generateUrl(
83
                $indexUrl['path'],
84
                isset($indexUrl['params']) ? $indexUrl['params'] : []
85
            )
86
        );
87
    }
88
}
89