Kunstmaan\DashboardBundle\Command\Helper\Analytics\AbstractAnalyticsCommandHelper

Complexity

Total Complexity

8

Size/Duplication

Total Lines	103
Duplicated Lines	13.59 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getTimestamps()	0	19	4
A	getExtra()	0	11	2
A	executeQuery()	14	14	1
	getData()	0	1	?

<?php

namespace Kunstmaan\DashboardBundle\Command\Helper\Analytics;

use Doctrine\ORM\EntityManager;
use Kunstmaan\DashboardBundle\Entity\AnalyticsOverview;
use Kunstmaan\DashboardBundle\Helper\Google\Analytics\ConfigHelper;
use Kunstmaan\DashboardBundle\Helper\Google\Analytics\QueryHelper;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class AbstractAnalyticsCommandHelper
 */
abstract class AbstractAnalyticsCommandHelper
{
    /** @var ConfigHelper $configHelper */
    protected $configHelper;

    /** @var QueryHelper $queryHelper */
    protected $query;

    /** @var EntityManager $em */
    protected $em;

    /** @var OutputInterface $output */
    protected $output;

    /**
     * Constructor
     *
     * @param $configHelper
     * @param $queryHelper
     * @param $output
     * @param $em
     */
    public function __construct($configHelper, $queryHelper, $output, $em)
    {
        $this->configHelper = $configHelper;
        $this->query = $queryHelper;
        $this->output = $output;
        $this->em = $em;
    }

    /**
     * @param AnalyticsOverview $overview
     *
     * @return array

Consider making the return type a bit more specific; maybe use array<string,string>.

     *
     * @throws \Exception
     */
    protected function getTimestamps(AnalyticsOverview $overview)
    {
        // if yearoverview set the begin time to the first day of this year
        $profileStartDate = explode('T', $this->configHelper->getActiveProfile()['created'])[0];
        if ($overview->getUseYear()) {
            $begin_date = date('Y-m-d', mktime(0, 0, 0, 1, 1, date('Y')));
            $begin = strtotime($profileStartDate) > strtotime($begin_date) ? date('Y-m-d', strtotime($profileStartDate)) : $begin_date;
        } else {
            // check if timespan is't more than existence of the profile; if so, use the creation time in stead of the timespan time
            $begin = strtotime($profileStartDate) > strtotime('-'.$overview->getTimespan().' days') ? date(
                'Y-m-d',
                strtotime($profileStartDate)
            ) : date('Y-m-d', strtotime('-'.$overview->getTimespan().' days'));
        }
        // set the end time
        $end = date('Y-m-d', strtotime('-'.$overview->getStartOffset().' days'));

        return ['begin' => $begin, 'end' => $end];
    }

    /**
     * Get the extra data for an overview, can be overridden
     *
     * @param AnalyticsOverview $overview
     *
     * @return array
     */
    protected function getExtra(AnalyticsOverview $overview)
    {
        $extra = [];

        // add segment
        if ($overview->getSegment()) {
            $extra['segment'] = $overview->getSegment()->getQuery();
        }

        return $extra;
    }

    /**
     * Executes the query
     *
     * @param AnalyticsOverview $overview
     * @param                   $metrics
     *
     * @return mixed
     * @throws \Exception
     */
    protected function executeQuery(AnalyticsOverview $overview, $metrics)

This method seems to be duplicated in your project.

    {
        $timestamps = $this->getTimestamps($overview);
        $extra = $this->getExtra($overview);
        // execute query
        $results = $this->query->getResultsByDate(
            $timestamps['begin'],
            $timestamps['end'],
            $metrics,
            $extra
        );

        return $results->getRows();
    }

    public abstract function getData(AnalyticsOverview $overview);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

The abstract declaration must precede the visibility declaration

}