Completed
Pull Request — 3.6 (#1940)
by Sander
09:43
created
src/Kunstmaan/AdminBundle/Command/CreateGroupCommand.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -7,9 +7,7 @@
 block discarded – undo
7 7
 use Symfony\Component\Console\Input\InputInterface;
8 8
 use Symfony\Component\Console\Input\InputOption;
9 9
 use Symfony\Component\Console\Output\OutputInterface;
10
-
11 10
 use Doctrine\ORM\EntityManager;
12
-
13 11
 use Kunstmaan\AdminBundle\Entity\Group;
14 12
 use Kunstmaan\AdminBundle\Entity\Role;
15 13
 
Please login to merge, or discard this patch.
src/Kunstmaan/AdminBundle/Command/CreateRoleCommand.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -6,9 +6,7 @@
 block discarded – undo
6 6
 use Symfony\Component\Console\Input\InputArgument;
7 7
 use Symfony\Component\Console\Input\InputInterface;
8 8
 use Symfony\Component\Console\Output\OutputInterface;
9
-
10 9
 use Doctrine\ORM\EntityManager;
11
-
12 10
 use Kunstmaan\AdminBundle\Entity\Role;
13 11
 
14 12
 /**
Please login to merge, or discard this patch.
src/Kunstmaan/AdminBundle/Command/FixGuestCommand.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
     /**
85 85
      * Check if the specified role is in use, both in the roles and the acl security identities tables
86 86
      *
87
-     * @param $roleName
87
+     * @param string $roleName
88 88
      *
89 89
      * @return bool
90 90
      */
Please login to merge, or discard this patch.
src/Kunstmaan/AdminBundle/DependencyInjection/KunstmaanAdminExtension.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Kunstmaan\AdminBundle\DependencyInjection;
4 4
 
5 5
 use InvalidArgumentException;
6
-
7 6
 use Symfony\Component\DependencyInjection\ContainerBuilder;
8 7
 use Symfony\Component\Config\FileLocator;
9 8
 use Symfony\Component\DependencyInjection\Definition;
Please login to merge, or discard this patch.
src/Kunstmaan/AdminBundle/Entity/Group.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Kunstmaan\AdminBundle\Entity;
4 4
 
5 5
 use InvalidArgumentException;
6
-
7 6
 use Symfony\Component\Validator\Constraints as Assert;
8 7
 use Symfony\Component\Validator\Context\ExecutionContextInterface;
9 8
 use Symfony\Component\Security\Core\Role\RoleInterface;
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/AdminList/FilterBuilder.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Kunstmaan\AdminListBundle\AdminList;
4 4
 
5 5
 use Symfony\Component\HttpFoundation\Request;
6
-
7 6
 use Kunstmaan\AdminListBundle\AdminList\FilterType\FilterTypeInterface;
8 7
 
9 8
 /**
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Controller/AdminListController.php 1 patch
Doc Comments   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -39,9 +39,9 @@  discard block
 block discarded – undo
39 39
      * Shows the list of entities
40 40
      *
41 41
      * @param AbstractAdminListConfigurator $configurator
42
-     * @param null|Request $request
42
+     * @param Request $request
43 43
      *
44
-     * @return array
44
+     * @return Response
45 45
      */
46 46
     protected function doIndexAction(AbstractAdminListConfigurator $configurator, Request $request)
47 47
     {
@@ -91,11 +91,11 @@  discard block
 block discarded – undo
91 91
      *
92 92
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
93 93
      * @param string $type The type to add
94
-     * @param null|Request $request
94
+     * @param Request $request
95 95
      *
96 96
      * @throws AccessDeniedHttpException
97 97
      *
98
-     * @return array
98
+     * @return Response
99 99
      */
100 100
     protected function doAddAction(AbstractAdminListConfigurator $configurator, $type = null, Request $request)
101 101
     {
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
      *
178 178
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
179 179
      * @param string $entityId The id of the entity that will be edited
180
-     * @param null|Request $request
180
+     * @param Request $request
181 181
      *
182 182
      * @throws NotFoundHttpException
183 183
      * @throws AccessDeniedHttpException
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
      *
282 282
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
283 283
      * @param integer $entityId The id to delete
284
-     * @param null|Request $request
284
+     * @param Request $request
285 285
      *
286 286
      * @throws NotFoundHttpException
287 287
      * @throws AccessDeniedHttpException
@@ -384,6 +384,9 @@  discard block
 block discarded – undo
384 384
         );
385 385
     }
386 386
 
387
+    /**
388
+     * @param \Doctrine\ORM\EntityRepository $repo
389
+     */
387 390
     private function getMaxSortableField($repo, $sort)
388 391
     {
389 392
         $maxWeight = $repo->createQueryBuilder('i')
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Service/ExportService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Kunstmaan\AdminListBundle\Service;
4 4
 
5
-use Box\Spout\Writer\WriterInterface;
6 5
 use Kunstmaan\AdminListBundle\AdminList\ExportableInterface;
7 6
 use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
8 7
 use Symfony\Component\HttpFoundation\Response;
Please login to merge, or discard this patch.
AdminListBundle/Tests/AdminList/ItemAction/SimpleItemActionTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 namespace Kunstmaan\AdminListBundle\Tests\AdminList\ItemAction;
3 3
 
4 4
 use stdClass;
5
-
6 5
 use Kunstmaan\AdminListBundle\AdminList\ItemAction\SimpleItemAction;
7 6
 
8 7
 /**
Please login to merge, or discard this patch.