Issues in ImportCommandHandlerTest.php - Fixed Issues - Inspection of "[AllBundle] Fix risky tests (#2407)" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c5c436...b453a3 )

by Ruud

created 2019-03-22 10:39 UTC

unit/Service/Importer/ImportCommandHandlerTest.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\TranslatorBundle\Tests\Service\Importer;

use Kunstmaan\TranslatorBundle\Model\Import\ImportCommand;
use Kunstmaan\TranslatorBundle\Tests\unit\WebTestCase;

class ImportCommandHandlerTest extends WebTestCase
{
    private $importCommandHandler;

    public function setUp()
    {
        static::bootKernel(['test_case' => 'TranslatorBundleTest', 'root_config' => 'config.yaml']);
        $container = static::$kernel->getContainer();
        static::loadFixtures($container);

        $this->importCommandHandler = $container->get('kunstmaan_translator.service.importer.command_handler');
    }

    /**
     * @group handler
     */
    public function testExecuteImportCommand()

    {
        $importCommand = new ImportCommand();
        $importCommand
            ->setForce(false)
            ->setLocales(false)
            ->setGlobals(true)
            ->setDefaultBundle(false);

        $this->importCommandHandler->executeImportCommand($importCommand);
    }

    public function testdetermineLocalesToImport()
    {
        $importCommand = new ImportCommand();
        $importCommand
            ->setForce(false)
            ->setLocales(false)
            ->setGlobals(true)
            ->setDefaultBundle(false);

        $locales = $this->importCommandHandler->determineLocalesToImport($importCommand);
        $this->assertEquals(array('nl', 'en', 'de'), $locales);
    }

    public function testParseRequestedLocalesMulti()
    {
        $locale = 'nl,De,   FR';
        $expectedArray = array('nl', 'de', 'fr');
        $locales = $this->importCommandHandler->parseRequestedLocales($locale);
        $this->assertEquals($expectedArray, $locales);
    }

    public function testParseRequestedLocalesSingle()
    {
        $locale = 'dE';
        $expectedArray = array('de');
        $locales = $this->importCommandHandler->parseRequestedLocales($locale);
        $this->assertEquals($expectedArray, $locales);
    }

    public function testParseRequestedLocalesArray()
    {
        $locale = array('dE', 'NL', 'es');
        $expectedArray = array('de', 'nl', 'es');
        $locales = $this->importCommandHandler->parseRequestedLocales($locale);
        $this->assertEquals($expectedArray, $locales);
    }

    public function testImportGlobalTranslationFiles()
    {
    }

    public function testImportBundleTranslationFiles()
    {
        $importCommand = new ImportCommand();
        $importCommand
            ->setForce(false)
            ->setLocales(false)
            ->setGlobals(true)
            ->setDefaultBundle('own');

        $this->importCommandHandler->importBundleTranslationFiles($importCommand);
    }
}


1		<?php
2
3		namespace Kunstmaan\TranslatorBundle\Tests\Service\Importer;
4
5		use Kunstmaan\TranslatorBundle\Model\Import\ImportCommand;
6		use Kunstmaan\TranslatorBundle\Tests\unit\WebTestCase;
7
8		class ImportCommandHandlerTest extends WebTestCase
9		{
10		private $importCommandHandler;
11
12	View Code Duplication	public function setUp()
13		{
14		static::bootKernel(['test_case' => 'TranslatorBundleTest', 'root_config' => 'config.yaml']);
15		$container = static::$kernel->getContainer();
16		static::loadFixtures($container);
17
18		$this->importCommandHandler = $container->get('kunstmaan_translator.service.importer.command_handler');
19		}
20
21		/**
22		* @group handler
23		*/
24	View Code Duplication	public function testExecuteImportCommand()
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		$importCommand = new ImportCommand();
27		$importCommand
28		->setForce(false)
29		->setLocales(false)
30		->setGlobals(true)
31		->setDefaultBundle(false);
32
33		$this->importCommandHandler->executeImportCommand($importCommand);
34		}
35
36		public function testdetermineLocalesToImport()
37		{
38		$importCommand = new ImportCommand();
39		$importCommand
40		->setForce(false)
41		->setLocales(false)
42		->setGlobals(true)
43		->setDefaultBundle(false);
44
45		$locales = $this->importCommandHandler->determineLocalesToImport($importCommand);
46		$this->assertEquals(array('nl', 'en', 'de'), $locales);
47		}
48
49		public function testParseRequestedLocalesMulti()
50		{
51		$locale = 'nl,De, FR';
52		$expectedArray = array('nl', 'de', 'fr');
53		$locales = $this->importCommandHandler->parseRequestedLocales($locale);
54		$this->assertEquals($expectedArray, $locales);
55		}
56
57		public function testParseRequestedLocalesSingle()
58		{
59		$locale = 'dE';
60		$expectedArray = array('de');
61		$locales = $this->importCommandHandler->parseRequestedLocales($locale);
62		$this->assertEquals($expectedArray, $locales);
63		}
64
65		public function testParseRequestedLocalesArray()
66		{
67		$locale = array('dE', 'NL', 'es');
68		$expectedArray = array('de', 'nl', 'es');
69		$locales = $this->importCommandHandler->parseRequestedLocales($locale);
70		$this->assertEquals($expectedArray, $locales);
71		}
72
73		public function testImportGlobalTranslationFiles()
74		{
75		}
76
77	View Code Duplication	public function testImportBundleTranslationFiles()
78		{
79		$importCommand = new ImportCommand();
80		$importCommand
81		->setForce(false)
82		->setLocales(false)
83		->setGlobals(true)
84		->setDefaultBundle('own');
85
86		$this->importCommandHandler->importBundleTranslationFiles($importCommand);
87		}
88		}
89

Kunstmaan / KunstmaanBundlesCMS

Push — master ( c5c436...b453a3 )

unit/Service/Importer/ImportCommandHandlerTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like