Kunstmaan\TranslatorBundle\Tests\Service\Importer\ImportCommandHandlerTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	100
Duplicated Lines	38 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	8	8	1
A	testExecuteImportCommand()	0	11	1
A	testdetermineLocalesToImport()	0	12	1
A	testParseRequestedLocalesMulti()	0	7	1
A	testParseRequestedLocalesSingle()	0	7	1
A	testParseRequestedLocalesArray()	0	7	1
A	testImportBundleTranslationFiles()	15	15	2
A	testImportSf4TranslationFiles()	15	15	2

<?php

namespace Kunstmaan\TranslatorBundle\Tests\Service\Importer;

use Kunstmaan\TranslatorBundle\Model\Import\ImportCommand;
use Kunstmaan\TranslatorBundle\Tests\unit\WebTestCase;
use Symfony\Component\HttpKernel\Kernel;

class ImportCommandHandlerTest extends WebTestCase
{
    private $importCommandHandler;

    public function setUp()

This method seems to be duplicated in your project.

    {
        static::bootKernel(['test_case' => 'TranslatorBundleTest', 'root_config' => 'config.yaml']);
        $container = static::$kernel->getContainer();
        static::loadFixtures($container);

It seems like $container defined by static::$kernel->getContainer() on line 16 can be null; however, Kunstmaan\TranslatorBundle\Tests\unit\WebTestCase::loadFixtures() does not accept null, maybe add an additional type check?

        $this->importCommandHandler = $container->get('kunstmaan_translator.service.importer.command_handler');
    }

    /**
     * @group handler
     */
    public function testExecuteImportCommand()
    {
        $importCommand = new ImportCommand();
        $importCommand
            ->setForce(false)
            ->setLocales(false)
            ->setGlobals(true)
            ->setDefaultBundle(false);

        $this->assertEquals(7, $this->importCommandHandler->executeImportCommand($importCommand));
    }

    public function testdetermineLocalesToImport()
    {
        $importCommand = new ImportCommand();
        $importCommand
            ->setForce(false)
            ->setLocales(false)
            ->setGlobals(true)
            ->setDefaultBundle(false);

        $locales = $this->importCommandHandler->determineLocalesToImport($importCommand);
        $this->assertEquals(array('nl', 'en', 'de'), $locales);
    }

    public function testParseRequestedLocalesMulti()
    {
        $locale = 'nl,De,   FR';
        $expectedArray = array('nl', 'de', 'fr');
        $locales = $this->importCommandHandler->parseRequestedLocales($locale);
        $this->assertEquals($expectedArray, $locales);
    }

    public function testParseRequestedLocalesSingle()
    {
        $locale = 'dE';
        $expectedArray = array('de');
        $locales = $this->importCommandHandler->parseRequestedLocales($locale);
        $this->assertEquals($expectedArray, $locales);
    }

    public function testParseRequestedLocalesArray()
    {
        $locale = array('dE', 'NL', 'es');
        $expectedArray = array('de', 'nl', 'es');
        $locales = $this->importCommandHandler->parseRequestedLocales($locale);
        $this->assertEquals($expectedArray, $locales);
    }

    /**
     * @group legacy
     */
    public function testImportBundleTranslationFiles()

This method seems to be duplicated in your project.

    {
        if (Kernel::VERSION_ID >= 40000) {
            $this->markTestSkipped('Skip symfony 3 test');
        }

        $importCommand = new ImportCommand();
        $importCommand
            ->setForce(false)
            ->setLocales(false)
            ->setGlobals(true)
            ->setDefaultBundle('own');

        $this->assertEquals(0, $this->importCommandHandler->importBundleTranslationFiles($importCommand));
    }

    public function testImportSf4TranslationFiles()

This method seems to be duplicated in your project.

    {
        if (Kernel::VERSION_ID < 40000) {
            $this->markTestSkipped('Skip symfony 4 test');
        }

        $importCommand = new ImportCommand();
        $importCommand
            ->setForce(false)
            ->setLocales(false)
            ->setGlobals(true)
            ->setDefaultBundle('own');

        $this->assertEquals(7, $this->importCommandHandler->importBundleTranslationFiles($importCommand));
    }
}