ManipulateImageService::cropImage() - Code Metrics - Inspection of "[MediaBunde] New feature cropping media objects on..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2609)

unknown

created 2020-11-10 11:04 UTC

ManipulateImageService::cropImage() B

↳ Parent: ManipulateImageService

Complexity

Conditions	9
Paths	48

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	53
rs	7.4698
c	0
b	0
f	0
cc	9
nc	48
nop	3

How to fix Long Method

<?php

namespace Kunstmaan\MediaBundle\Helper;

use Kunstmaan\MediaBundle\Entity\EditableMediaWrapper;
use Kunstmaan\UtilitiesBundle\Helper\Slugifier;
use Liip\ImagineBundle\Exception\Imagine\Filter\NonExistingFilterException;
use Liip\ImagineBundle\Imagine\Filter\FilterConfiguration;
use Liip\ImagineBundle\Service\FilterService;

class ManipulateImageService
{
    /** @var Slugifier */
    private $slugifier;

    /** @var FilterService */
    private $filterService;

    /** @var FilterConfiguration */
    private $filterConfiguration;

    public function __construct(Slugifier $slugifier, FilterService $filterService, FilterConfiguration $filterConfiguration)
    {
        $this->slugifier = $slugifier;
        $this->filterService = $filterService;
        $this->filterConfiguration = $filterConfiguration;
    }

    public function getFocusPointClass(EditableMediaWrapper $editableMediaWrapper, string $view = ''): string
    {
        if (null === $editableMediaWrapper->getRunTimeConfig()) {
            return '';
        }

        $runTimeConfig = json_decode($editableMediaWrapper->getRunTimeConfig(), true);

        if (!is_array($runTimeConfig) || empty($view) || !isset($runTimeConfig[$view]['class'])) {
            return '';
        }

        return $runTimeConfig[$view]['class'];
    }

    public function cropImage(EditableMediaWrapper $editableMediaWrapper, string $view = '', string $filter = 'optim'): string
    {
        $media = $editableMediaWrapper->getMedia();
        $path = $media->getUrl();
        $path = str_replace('://', '---', $path);

        $runTimeConfigForView = [];
        if ($editableMediaWrapper->getRunTimeConfig() !== null) {
            $runTimeConfig = json_decode($editableMediaWrapper->getRunTimeConfig(), true);

            if (
                is_array($runTimeConfig)
                && !empty($view)
                && isset($runTimeConfig[$view]['start'], $runTimeConfig[$view]['size'])
            ) {
                $runTimeConfigForView = [
                    'crop' => [
                        'start' => $runTimeConfig[$view]['start'],
                        'size' => $runTimeConfig[$view]['size'],
                    ],
                ];
            }
        }

        try {
            $filterConfig = $this->filterConfiguration->get($filter);
        } catch (NonExistingFilterException $exception) {
            $filterConfig = $this->filterConfiguration->get('optim');
        }

        $oemConfig = null;
        if (isset($filterConfig['filters'])) {
            $oemConfig = $filterConfig;
            unset($filterConfig['filters']['crop']);
            $runTimeConfigForView = array_merge_recursive($runTimeConfigForView, $filterConfig['filters']);
            unset($filterConfig['filters']);
            $this->filterConfiguration->set($filter, $filterConfig);
        }

        try {
            $response = $this->filterService->getUrlOfFilteredImageWithRuntimeFilters($path, $filter, $runTimeConfigForView);
        } catch (\Exception $exception) {
            $runTimeConfigForView = [];

            $response = $this->filterService->getUrlOfFilteredImageWithRuntimeFilters($path, 'optim', $runTimeConfigForView);
        }

        if ($oemConfig !== null) {
            $this->filterConfiguration->set($filter, $oemConfig);
        }

        return $response;
    }
}


1			<?php
2
3			namespace Kunstmaan\MediaBundle\Helper;
4
5			use Kunstmaan\MediaBundle\Entity\EditableMediaWrapper;
6			use Kunstmaan\UtilitiesBundle\Helper\Slugifier;
7			use Liip\ImagineBundle\Exception\Imagine\Filter\NonExistingFilterException;
8			use Liip\ImagineBundle\Imagine\Filter\FilterConfiguration;
9			use Liip\ImagineBundle\Service\FilterService;
10
11			class ManipulateImageService
12			{
13			/** @var Slugifier */
14			private $slugifier;
15
16			/** @var FilterService */
17			private $filterService;
18
19			/** @var FilterConfiguration */
20			private $filterConfiguration;
21
22			public function __construct(Slugifier $slugifier, FilterService $filterService, FilterConfiguration $filterConfiguration)
23			{
24			$this->slugifier = $slugifier;
25			$this->filterService = $filterService;
26			$this->filterConfiguration = $filterConfiguration;
27			}
28
29			public function getFocusPointClass(EditableMediaWrapper $editableMediaWrapper, string $view = ''): string
30			{
31			if (null === $editableMediaWrapper->getRunTimeConfig()) {
32			return '';
33			}
34
35			$runTimeConfig = json_decode($editableMediaWrapper->getRunTimeConfig(), true);
36
37			if (!is_array($runTimeConfig) \|\| empty($view) \|\| !isset($runTimeConfig[$view]['class'])) {
38			return '';
39			}
40
41			return $runTimeConfig[$view]['class'];
42			}
43
44			public function cropImage(EditableMediaWrapper $editableMediaWrapper, string $view = '', string $filter = 'optim'): string
45			{
46			$media = $editableMediaWrapper->getMedia();
47			$path = $media->getUrl();
48			$path = str_replace('://', '---', $path);
49
50			$runTimeConfigForView = [];
51			if ($editableMediaWrapper->getRunTimeConfig() !== null) {
52			$runTimeConfig = json_decode($editableMediaWrapper->getRunTimeConfig(), true);
53
54			if (
55			is_array($runTimeConfig)
56			&& !empty($view)
57			&& isset($runTimeConfig[$view]['start'], $runTimeConfig[$view]['size'])
58			) {
59			$runTimeConfigForView = [
60			'crop' => [
61			'start' => $runTimeConfig[$view]['start'],
62			'size' => $runTimeConfig[$view]['size'],
63			],
64			];
65			}
66			}
67
68			try {
69			$filterConfig = $this->filterConfiguration->get($filter);
70			} catch (NonExistingFilterException $exception) {
71			$filterConfig = $this->filterConfiguration->get('optim');
72			}
73
74			$oemConfig = null;
75			if (isset($filterConfig['filters'])) {
76			$oemConfig = $filterConfig;
77			unset($filterConfig['filters']['crop']);
78			$runTimeConfigForView = array_merge_recursive($runTimeConfigForView, $filterConfig['filters']);
79			unset($filterConfig['filters']);
80			$this->filterConfiguration->set($filter, $filterConfig);
81			}
82
83			try {
84			$response = $this->filterService->getUrlOfFilteredImageWithRuntimeFilters($path, $filter, $runTimeConfigForView);
85			} catch (\Exception $exception) {
86			$runTimeConfigForView = [];
87
88			$response = $this->filterService->getUrlOfFilteredImageWithRuntimeFilters($path, 'optim', $runTimeConfigForView);
89			}
90
91			if ($oemConfig !== null) {
92			$this->filterConfiguration->set($filter, $oemConfig);
93			}
94
95			return $response;
96			}
97			}
98

Kunstmaan / KunstmaanBundlesCMS

Pull Request — master (#2609)

ManipulateImageService::cropImage() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like