Issues in AbstractAdminListConfiguratorTest.php - All Issues - Inspection of "update webpack + add kunstmaan linters + cleanup g..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 91fdab...75a7b9 )

unknown

created 2018-11-22 13:42 UTC

Configurator/AbstractAdminListConfiguratorTest.php (2 issues)

Labels

Severity

Minor 2

Ruud Denivel 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminListBundle\Tests\AdminList\Configurator;

use DateTime;
use Exception;
use Kunstmaan\AdminBundle\Form\ColorType;
use Kunstmaan\AdminListBundle\AdminList\BulkAction\SimpleBulkAction;
use Kunstmaan\AdminListBundle\AdminList\ListAction\SimpleListAction;
use Kunstmaan\LeadGenerationBundle\Entity\Rule\LocaleBlacklistRule;
use Kunstmaan\LeadGenerationBundle\Form\Rule\LocaleBlackListAdminType;
use PHPUnit_Framework_TestCase;
use stdClass;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Session\Session;
use Kunstmaan\AdminListBundle\Tests\unit\Model\ConcreteConfigurator;

/**
 * Generated by PHPUnit_SkeletonGenerator on 2012-09-13 at 16:18:47.
 */
class AbstractAdminListConfiguratorTest extends PHPUnit_Framework_TestCase
{
    /**
     * @var ConcreteConfigurator
     */
    protected $object;

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {

        $session = $this->createMock(Session::class);
        $session->expects($this->any())->method('has')->willReturn(true);
        $session->expects($this->any())->method('get')->willReturn([
            'page' => 1,
            'orderBy' => 'id',
            'orderDirection' => 'ASC',
        ]);
        $request = new Request();
        $request->setSession($session);
        $request->query->add([
            '_route' => 'some-route',
        ]);
        $config = new ConcreteConfigurator();
        $config->bindRequest($request);
        $config->buildIterator();
        $this->object = $config;
    }

    public function testGetSet()
    {
        $config = $this->object;

        $config->setAdminTypeOptions(['test' => 123]);
        $config->setDeleteTemplate('delete.twig');
        $config->setEditTemplate('edit.twig');
        $config->setViewTemplate('view.twig');
        $config->setAddTemplate('add.twig');
        $config->setListTemplate('list.twig');

        $this->assertEquals('id', $config->getOrderBy());
        $this->assertEquals('ASC', $config->getOrderDirection());
        $this->assertEquals(1, $config->getPage());
        $this->assertEquals(10, $config->getLimit());
        $this->assertCount(1, $config->getAdminTypeOptions());
        $this->assertArrayHasKey('test', $config->getAdminTypeOptions());
        $viewUrl = $config->getViewUrlFor(['id' => 5]);
        $this->assertCount(2, $viewUrl);
        $this->assertArrayHasKey('path', $viewUrl);
        $this->assertArrayHasKey('params', $viewUrl);
        $this->assertArrayHasKey('id', $viewUrl['params']);
        $this->assertEquals('xyz:Xyz', $config->getControllerPath());
        $this->assertEquals(5, $viewUrl['params']['id']);
        $this->assertEquals('xyz_admin_xyz_view', $viewUrl['path']);
        $this->assertEquals('delete.twig', $config->getDeleteTemplate());
        $this->assertEquals('edit.twig', $config->getEditTemplate());
        $this->assertEquals('view.twig', $config->getViewTemplate());
        $this->assertEquals('add.twig', $config->getAddTemplate());
        $this->assertEquals('list.twig', $config->getListTemplate());
        $this->assertInstanceOf(DateTime::class, $config->decorateNewEntity(new DateTime()));
    }

    public function testGetAdminType()
    {
        $config = $this->object;
        $blackList = new LocaleBlacklistRule();

        $this->assertEquals(LocaleBlackListAdminType::class, $config->getAdminType($blackList));

        $this->setUp();
        $config = $this->object;
        $config->setAdminType(new ColorType());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertInstanceOf(ColorType::class, $config->getAdminType($blackList));

        $this->setUp();
        $this->expectException(Exception::class);
        $this->object->getAdminType(new stdClass());
    }

    public function testGetSetHasBulkAction()
    {
        $config = $this->object;
        $this->assertFalse($config->hasBulkActions());
        $config->addBulkAction(new SimpleBulkAction(['/url'], 'label'));
        $this->assertTrue($config->hasBulkActions());
        $this->assertCount(1, $config->getBulkActions());
        $this->assertInstanceOf(SimpleBulkAction::class, $config->getBulkActions()[0]);
    }

    public function testGetSetHasListAction()
    {
        $config = $this->object;
        $this->assertFalse($config->hasListActions());
        $config->addListAction(new SimpleListAction(['/url'], 'label'));
        $this->assertTrue($config->hasListActions());
        $this->assertCount(1, $config->getListActions());
        $this->assertInstanceOf(SimpleListAction::class, $config->getListActions()[0]);
    }

    public function testGetSetHasItemAction()
    {
        $config = $this->object;
        $this->assertFalse($config->hasItemActions());
        $config->addSimpleItemAction('x', 'y', 'z');
        $this->assertTrue($config->hasItemActions());
    }

    public function testSortFields()
    {
        $config = $this->object;
        $this->assertCount(0, $config->getSortFields());
        $config->addField('sort', 'blah', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertCount(1, $config->getSortFields());
    }

    public function testExportFields()
    {
        $config = $this->object;
        $config->buildExportFields();
        $this->assertCount(0, $config->getExportFields());
        $config->addExportField('sort', 'blah', 'blah.twig');
        $this->assertCount(1, $config->getExportFields());
        $config->resetBuilds();
        $this->assertCount(0, $config->getExportFields());
    }
}


1		<?php
2
3		namespace Kunstmaan\AdminListBundle\Tests\AdminList\Configurator;
4
5		use DateTime;
6		use Exception;
7		use Kunstmaan\AdminBundle\Form\ColorType;
8		use Kunstmaan\AdminListBundle\AdminList\BulkAction\SimpleBulkAction;
9		use Kunstmaan\AdminListBundle\AdminList\ListAction\SimpleListAction;
10		use Kunstmaan\LeadGenerationBundle\Entity\Rule\LocaleBlacklistRule;
11		use Kunstmaan\LeadGenerationBundle\Form\Rule\LocaleBlackListAdminType;
12		use PHPUnit_Framework_TestCase;
13		use stdClass;
14		use Symfony\Component\HttpFoundation\Request;
15		use Symfony\Component\HttpFoundation\Session\Session;
16		use Kunstmaan\AdminListBundle\Tests\unit\Model\ConcreteConfigurator;
17
18		/**
19		* Generated by PHPUnit_SkeletonGenerator on 2012-09-13 at 16:18:47.
20		*/
21		class AbstractAdminListConfiguratorTest extends PHPUnit_Framework_TestCase
22		{
23		/**
24		* @var ConcreteConfigurator
25		*/
26		protected $object;
27
28		/**
29		* Sets up the fixture, for example, opens a network connection.
30		* This method is called before a test is executed.
31		*/
32		protected function setUp()
33		{
34
35		$session = $this->createMock(Session::class);
36		$session->expects($this->any())->method('has')->willReturn(true);
37		$session->expects($this->any())->method('get')->willReturn([
38		'page' => 1,
39		'orderBy' => 'id',
40		'orderDirection' => 'ASC',
41		]);
42		$request = new Request();
43		$request->setSession($session);
44		$request->query->add([
45		'_route' => 'some-route',
46		]);
47		$config = new ConcreteConfigurator();
48		$config->bindRequest($request);
49		$config->buildIterator();
50		$this->object = $config;
51		}
52
53		public function testGetSet()
54		{
55		$config = $this->object;
56
57		$config->setAdminTypeOptions(['test' => 123]);
58		$config->setDeleteTemplate('delete.twig');
59		$config->setEditTemplate('edit.twig');
60		$config->setViewTemplate('view.twig');
61		$config->setAddTemplate('add.twig');
62		$config->setListTemplate('list.twig');
63
64		$this->assertEquals('id', $config->getOrderBy());
65		$this->assertEquals('ASC', $config->getOrderDirection());
66		$this->assertEquals(1, $config->getPage());
67		$this->assertEquals(10, $config->getLimit());
68		$this->assertCount(1, $config->getAdminTypeOptions());
69		$this->assertArrayHasKey('test', $config->getAdminTypeOptions());
70		$viewUrl = $config->getViewUrlFor(['id' => 5]);
71		$this->assertCount(2, $viewUrl);
72		$this->assertArrayHasKey('path', $viewUrl);
73		$this->assertArrayHasKey('params', $viewUrl);
74		$this->assertArrayHasKey('id', $viewUrl['params']);
75		$this->assertEquals('xyz:Xyz', $config->getControllerPath());
76		$this->assertEquals(5, $viewUrl['params']['id']);
77		$this->assertEquals('xyz_admin_xyz_view', $viewUrl['path']);
78		$this->assertEquals('delete.twig', $config->getDeleteTemplate());
79		$this->assertEquals('edit.twig', $config->getEditTemplate());
80		$this->assertEquals('view.twig', $config->getViewTemplate());
81		$this->assertEquals('add.twig', $config->getAddTemplate());
82		$this->assertEquals('list.twig', $config->getListTemplate());
83		$this->assertInstanceOf(DateTime::class, $config->decorateNewEntity(new DateTime()));
84		}
85
86		public function testGetAdminType()
87		{
88		$config = $this->object;
89		$blackList = new LocaleBlacklistRule();
90
91		$this->assertEquals(LocaleBlackListAdminType::class, $config->getAdminType($blackList));
92
93		$this->setUp();
94		$config = $this->object;
95		$config->setAdminType(new ColorType());
		0 ignored issues – show Documentation introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Kunstmaan\AdminBundle\Form\ColorType()` is of type `object<Kunstmaan\AdminBundle\Form\ColorType>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
96		$this->assertInstanceOf(ColorType::class, $config->getAdminType($blackList));
97
98		$this->setUp();
99		$this->expectException(Exception::class);
100		$this->object->getAdminType(new stdClass());
101		}
102
103	View Code Duplication	public function testGetSetHasBulkAction()
104		{
105		$config = $this->object;
106		$this->assertFalse($config->hasBulkActions());
107		$config->addBulkAction(new SimpleBulkAction(['/url'], 'label'));
108		$this->assertTrue($config->hasBulkActions());
109		$this->assertCount(1, $config->getBulkActions());
110		$this->assertInstanceOf(SimpleBulkAction::class, $config->getBulkActions()[0]);
111		}
112
113	View Code Duplication	public function testGetSetHasListAction()
114		{
115		$config = $this->object;
116		$this->assertFalse($config->hasListActions());
117		$config->addListAction(new SimpleListAction(['/url'], 'label'));
118		$this->assertTrue($config->hasListActions());
119		$this->assertCount(1, $config->getListActions());
120		$this->assertInstanceOf(SimpleListAction::class, $config->getListActions()[0]);
121		}
122
123		public function testGetSetHasItemAction()
124		{
125		$config = $this->object;
126		$this->assertFalse($config->hasItemActions());
127		$config->addSimpleItemAction('x', 'y', 'z');
128		$this->assertTrue($config->hasItemActions());
129		}
130
131		public function testSortFields()
132		{
133		$config = $this->object;
134		$this->assertCount(0, $config->getSortFields());
135		$config->addField('sort', 'blah', true);
		0 ignored issues – show Documentation introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
136		$this->assertCount(1, $config->getSortFields());
137		}
138
139		public function testExportFields()
140		{
141		$config = $this->object;
142		$config->buildExportFields();
143		$this->assertCount(0, $config->getExportFields());
144		$config->addExportField('sort', 'blah', 'blah.twig');
145		$this->assertCount(1, $config->getExportFields());
146		$config->resetBuilds();
147		$this->assertCount(0, $config->getExportFields());
148		}
149		}
150

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 91fdab...75a7b9 )

Configurator/AbstractAdminListConfiguratorTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like