Issues in DomainConfiguration.php - All Issues - Inspection of "update webpack + add kunstmaan linters + cleanup g..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 91fdab...75a7b9 )

unknown

created 2018-11-22 13:42 UTC

AdminBundle/Helper/DomainConfiguration.php (2 issues)

Labels

Severity

Peter Zentjens 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Helper;

use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\RequestStack;

/**
 * Class DomainConfiguration
 *
 * Default (single domain) configuration handling
 *
 * @package Kunstmaan\AdminBundle\Helper
 */
class DomainConfiguration implements DomainConfigurationInterface
{
    /** @var ContainerInterface */
    protected $container;

    /** @var RequestStack */
    private $requestStack;

    /** @var bool */
    protected $multiLanguage;

    /** @var array */
    protected $requiredLocales;

    /** @var string */
    protected $defaultLocale;

    /**
     * @param ContainerInterface|string $multilanguage

     */
    public function __construct(/*ContainerInterface|RequestStack*/ $requestStack, $multilanguage = null, $defaultLocale = null, $requiredLocales = null)
    {
        if ($requestStack instanceof ContainerInterface) {
            @trigger_error('Container injection and the usage of the container is deprecated in KunstmaanNodeBundle 5.1 and will be removed in KunstmaanNodeBundle 6.0.', E_USER_DEPRECATED);

            $this->container = $requestStack;
            $this->multiLanguage = $this->container->getParameter(
                'multilanguage'
            );
            $this->defaultLocale = $this->container->getParameter(
                'defaultlocale'
            );
            $this->requiredLocales = explode(
                '|',
                $this->container->getParameter('requiredlocales')
            );
            $this->requestStack = $this->container->get('request_stack');

            return;
        }

        $this->requestStack = $requestStack;
        $this->multiLanguage = $multilanguage;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->defaultLocale = $defaultLocale;

        $this->requiredLocales = explode('|', $requiredLocales);
    }

    /**
     * @return string
     */
    public function getHost()
    {
        $request = $this->getMasterRequest();
        $host = is_null($request) ? '' : $request->getHost();

        return $host;
    }

    /**
     * @return array
     */
    public function getHosts()
    {
        return array($this->getHost());
    }

    /**
     * @return string
     */
    public function getDefaultLocale()
    {
        return $this->defaultLocale;
    }

    /**
     * @param string|null $host
     *
     * @return bool
     */
    public function isMultiLanguage($host = null)
    {
        return $this->multiLanguage;
    }

    /**
     * @param string|null $host
     *
     * @return array
     */
    public function getFrontendLocales($host = null)
    {
        return $this->requiredLocales;
    }

    /**
     * @param string|null $host
     *
     * @return array
     */
    public function getBackendLocales($host = null)
    {
        return $this->requiredLocales;
    }

    /**
     * @return bool
     */
    public function isMultiDomainHost()
    {
        return false;
    }

    /**
     * @param string|null $host
     *
     * @return null
     */
    public function getRootNode($host = null)
    {
        return null;
    }

    /**
     * @return array
     */
    public function getExtraData()
    {
        return array();
    }

    /**
     * @return array
     */
    public function getLocalesExtraData()
    {
        return array();
    }

    /**
     * @return null|\Symfony\Component\HttpFoundation\Request
     */
    protected function getMasterRequest()
    {
        return $this->requestStack->getMasterRequest();
    }

    /**
     * @return array
     */
    public function getFullHostConfig()
    {
        return array();
    }

    /**
     * @param string|null $host
     *
     * @return null
     */
    public function getFullHost($host = null)
    {
        return null;
    }

    /**
     * @param int $id
     *
     * @return null
     */
    public function getFullHostById($id)
    {
        return null;
    }

    /**
     * @return null
     */
    public function getHostSwitched()
    {
        return null;
    }

    /**
     * @param string|null $host
     *
     * @return null
     */
    public function getHostBaseUrl($host = null)
    {
        return null;
    }

}


1		<?php
2
3		namespace Kunstmaan\AdminBundle\Helper;
4
5		use Symfony\Component\DependencyInjection\ContainerInterface;
6		use Symfony\Component\HttpFoundation\RequestStack;
7
8		/**
9		* Class DomainConfiguration
10		*
11		* Default (single domain) configuration handling
12		*
13		* @package Kunstmaan\AdminBundle\Helper
14		*/
15		class DomainConfiguration implements DomainConfigurationInterface
16		{
17		/** @var ContainerInterface */
18		protected $container;
19
20		/** @var RequestStack */
21		private $requestStack;
22
23		/** @var bool */
24		protected $multiLanguage;
25
26		/** @var array */
27		protected $requiredLocales;
28
29		/** @var string */
30		protected $defaultLocale;
31
32		/**
33		* @param ContainerInterface\|string $multilanguage
		0 ignored issues – show Documentation introduced 2018-06-04 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$multilanguage` not be `ContainerInterface\|string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
34		*/
35	View Code Duplication	public function __construct(/ContainerInterface\|RequestStack/ $requestStack, $multilanguage = null, $defaultLocale = null, $requiredLocales = null)
36		{
37		if ($requestStack instanceof ContainerInterface) {
38		@trigger_error('Container injection and the usage of the container is deprecated in KunstmaanNodeBundle 5.1 and will be removed in KunstmaanNodeBundle 6.0.', E_USER_DEPRECATED);
39
40		$this->container = $requestStack;
41		$this->multiLanguage = $this->container->getParameter(
42		'multilanguage'
43		);
44		$this->defaultLocale = $this->container->getParameter(
45		'defaultlocale'
46		);
47		$this->requiredLocales = explode(
48		'\|',
49		$this->container->getParameter('requiredlocales')
50		);
51		$this->requestStack = $this->container->get('request_stack');
52
53		return;
54		}
55
56		$this->requestStack = $requestStack;
57		$this->multiLanguage = $multilanguage;
		0 ignored issues – show Documentation Bug introduced 2018-06-04 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$multilanguage` can also be of type `object<Symfony\Component...ion\ContainerInterface>` or `string`. However, the property `$multiLanguage` is declared as type `boolean`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
58		$this->defaultLocale = $defaultLocale;
59
60		$this->requiredLocales = explode('\|', $requiredLocales);
61		}
62
63		/**
64		* @return string
65		*/
66		public function getHost()
67		{
68		$request = $this->getMasterRequest();
69		$host = is_null($request) ? '' : $request->getHost();
70
71		return $host;
72		}
73
74		/**
75		* @return array
76		*/
77		public function getHosts()
78		{
79		return array($this->getHost());
80		}
81
82		/**
83		* @return string
84		*/
85		public function getDefaultLocale()
86		{
87		return $this->defaultLocale;
88		}
89
90		/**
91		* @param string\|null $host
92		*
93		* @return bool
94		*/
95		public function isMultiLanguage($host = null)
96		{
97		return $this->multiLanguage;
98		}
99
100		/**
101		* @param string\|null $host
102		*
103		* @return array
104		*/
105		public function getFrontendLocales($host = null)
106		{
107		return $this->requiredLocales;
108		}
109
110		/**
111		* @param string\|null $host
112		*
113		* @return array
114		*/
115		public function getBackendLocales($host = null)
116		{
117		return $this->requiredLocales;
118		}
119
120		/**
121		* @return bool
122		*/
123		public function isMultiDomainHost()
124		{
125		return false;
126		}
127
128		/**
129		* @param string\|null $host
130		*
131		* @return null
132		*/
133		public function getRootNode($host = null)
134		{
135		return null;
136		}
137
138		/**
139		* @return array
140		*/
141		public function getExtraData()
142		{
143		return array();
144		}
145
146		/**
147		* @return array
148		*/
149		public function getLocalesExtraData()
150		{
151		return array();
152		}
153
154		/**
155		* @return null\|\Symfony\Component\HttpFoundation\Request
156		*/
157		protected function getMasterRequest()
158		{
159		return $this->requestStack->getMasterRequest();
160		}
161
162		/**
163		* @return array
164		*/
165		public function getFullHostConfig()
166		{
167		return array();
168		}
169
170		/**
171		* @param string\|null $host
172		*
173		* @return null
174		*/
175		public function getFullHost($host = null)
176		{
177		return null;
178		}
179
180		/**
181		* @param int $id
182		*
183		* @return null
184		*/
185		public function getFullHostById($id)
186		{
187		return null;
188		}
189
190		/**
191		* @return null
192		*/
193		public function getHostSwitched()
194		{
195		return null;
196		}
197
198		/**
199		* @param string\|null $host
200		*
201		* @return null
202		*/
203		public function getHostBaseUrl($host = null)
204		{
205		return null;
206		}
207
208		}
209

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 91fdab...75a7b9 )

AdminBundle/Helper/DomainConfiguration.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like