GenerateConfigCommand - Code Metrics - Inspection of "[GeneratorBundle] Added config generator + improve..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2414)

by Ruud

created 2019-03-29 13:55 UTC

GenerateConfigCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	8.97 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes

Metric	Value
wmc	8
lcom	2
cbo	4
dl	7
loc	78
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	configure()	0	7	1
A	getWelcomeText()	0	4	1
A	doExecute()	0	8	1
A	doInteract()	0	14	3
A	createGenerator()	7	7	1

How to fix Duplicated Code

<?php

namespace Kunstmaan\GeneratorBundle\Command;

use Kunstmaan\GeneratorBundle\Generator\ConfigGenerator;
use Symfony\Component\Console\Input\InputOption;

/**
 * Generates config files
 */
class GenerateConfigCommand extends KunstmaanGenerateCommand
{
    /** @var bool */
    private $overwriteSecurity;

    /** @var bool */
    private $overwriteLiipImagine;

    /**
     * @param string $rootDir
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(string $projectDir)
    {
        $this->projectDir = $projectDir;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        parent::__construct();
    }

    /**
     * @see Command
     */
    protected function configure()
    {
        $this->setDescription('Generates all needed config files not generated by recipes')
            ->addOption('overwrite-security', '', InputOption::VALUE_REQUIRED, 'Whether the command should generate a copy or just overwrite the already existing config file')
            ->addOption('overwrite-liipimagine', '', InputOption::VALUE_REQUIRED, 'Whether the command should generate a copy or just overwrite the already existing config file')
            ->setName('kuma:generate:config');
    }

    /**
     * {@inheritdoc}
     */
    protected function getWelcomeText()
    {
        return 'Welcome to the Kunstmaan config generator';
    }

    /**
     * {@inheritdoc}
     */
    protected function doExecute()
    {
        $this->assistant->writeSection('Config generation');

        $this->createGenerator()->generate($this->projectDir, $this->overwriteSecurity, $this->overwriteLiipImagine);

        $this->assistant->writeSection('Config successfully created', 'bg=green;fg=black');
    }

    /**
     * {@inheritdoc}
     */
    protected function doInteract()
    {
        $this->assistant->writeLine(array("This helps you to set all default config files needed to run KunstmaanCMS.\n"));

        $this->overwriteSecurity = $this->assistant->getOptionOrDefault('overwrite-security', null);
        $this->overwriteLiipImagine = $this->assistant->getOptionOrDefault('overwrite-liipimagine', null);

        if (null === $this->overwriteSecurity) {
            $this->overwriteSecurity = $this->assistant->askConfirmation('Do you want to overwrite the default security.yaml configuration file? (y/n)', 'y');
        }
        if (null === $this->overwriteLiipImagine) {
            $this->overwriteLiipImagine = $this->assistant->askConfirmation('Do you want to overwrite the default liip_imagine.yaml configuration file? (y/n)', 'y');
        }
    }

    /**
     * @return ConfigGenerator
     */
    protected function createGenerator()

    {
        $filesystem = $this->getContainer()->get('filesystem');
        $registry = $this->getContainer()->get('doctrine');

        return new ConfigGenerator($filesystem, $registry, '/config', $this->assistant, $this->getContainer());
    }
}


1		<?php
2
3		namespace Kunstmaan\GeneratorBundle\Command;
4
5		use Kunstmaan\GeneratorBundle\Generator\ConfigGenerator;
6		use Symfony\Component\Console\Input\InputOption;
7
8		/**
9		* Generates config files
10		*/
11		class GenerateConfigCommand extends KunstmaanGenerateCommand
12		{
13		/** @var bool */
14		private $overwriteSecurity;
15
16		/** @var bool */
17		private $overwriteLiipImagine;
18
19		/**
20		* @param string $rootDir
		0 ignored issues – show Bug introduced 2019-03-22 14:42 UTC by Report Bug Copy Issue Report There is no parameter named `$rootDir`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
21		*/
22		public function __construct(string $projectDir)
23		{
24		$this->projectDir = $projectDir;
		0 ignored issues – show Bug introduced 2019-03-28 16:22 UTC by Report Bug Copy Issue Report The property `projectDir` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25
26		parent::__construct();
27		}
28
29		/**
30		* @see Command
31		*/
32		protected function configure()
33		{
34		$this->setDescription('Generates all needed config files not generated by recipes')
35		->addOption('overwrite-security', '', InputOption::VALUE_REQUIRED, 'Whether the command should generate a copy or just overwrite the already existing config file')
36		->addOption('overwrite-liipimagine', '', InputOption::VALUE_REQUIRED, 'Whether the command should generate a copy or just overwrite the already existing config file')
37		->setName('kuma:generate:config');
38		}
39
40		/**
41		* {@inheritdoc}
42		*/
43		protected function getWelcomeText()
44		{
45		return 'Welcome to the Kunstmaan config generator';
46		}
47
48		/**
49		* {@inheritdoc}
50		*/
51		protected function doExecute()
52		{
53		$this->assistant->writeSection('Config generation');
54
55		$this->createGenerator()->generate($this->projectDir, $this->overwriteSecurity, $this->overwriteLiipImagine);
56
57		$this->assistant->writeSection('Config successfully created', 'bg=green;fg=black');
58		}
59
60		/**
61		* {@inheritdoc}
62		*/
63		protected function doInteract()
64		{
65		$this->assistant->writeLine(array("This helps you to set all default config files needed to run KunstmaanCMS.\n"));
66
67		$this->overwriteSecurity = $this->assistant->getOptionOrDefault('overwrite-security', null);
68		$this->overwriteLiipImagine = $this->assistant->getOptionOrDefault('overwrite-liipimagine', null);
69
70		if (null === $this->overwriteSecurity) {
71		$this->overwriteSecurity = $this->assistant->askConfirmation('Do you want to overwrite the default security.yaml configuration file? (y/n)', 'y');
72		}
73		if (null === $this->overwriteLiipImagine) {
74		$this->overwriteLiipImagine = $this->assistant->askConfirmation('Do you want to overwrite the default liip_imagine.yaml configuration file? (y/n)', 'y');
75		}
76		}
77
78		/**
79		* @return ConfigGenerator
80		*/
81	View Code Duplication	protected function createGenerator()
		0 ignored issues – show Duplication introduced 2019-03-28 16:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83		$filesystem = $this->getContainer()->get('filesystem');
84		$registry = $this->getContainer()->get('doctrine');
85
86		return new ConfigGenerator($filesystem, $registry, '/config', $this->assistant, $this->getContainer());
87		}
88		}
89

Kunstmaan / KunstmaanBundlesCMS

Pull Request — master (#2414)

GenerateConfigCommand A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like