Issues in RedirectAdminListConfigurator.php - Fixed Issues - Inspection of "Merge branch '5.2'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e6c0c9...d841f8 )

by Jeroen

created 2019-04-19 13:47 UTC

AdminList/RedirectAdminListConfigurator.php (4 issues)

Labels

Documentation 4

Severity

Minor 4

Krisztián Ferenczi 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\RedirectBundle\AdminList;

use Doctrine\ORM\EntityManager;
use Kunstmaan\AdminBundle\Helper\DomainConfigurationInterface;
use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM;
use Kunstmaan\RedirectBundle\Form\RedirectAdminType;

class RedirectAdminListConfigurator extends AbstractDoctrineORMAdminListConfigurator
{
    /**
     * @var DomainConfigurationInterface
     */
    private $domainConfiguration;

    /**
     * @param EntityManager                $em                  The entity manager
     * @param AclHelper                    $aclHelper           The acl helper
     * @param DomainConfigurationInterface $domainConfiguration
     */
    public function __construct(EntityManager $em, AclHelper $aclHelper = null, DomainConfigurationInterface $domainConfiguration)
    {
        parent::__construct($em, $aclHelper);

        $this->domainConfiguration = $domainConfiguration;

        $this->setAdminType(RedirectAdminType::class);
        $this->setAdminTypeOptions(['domainConfiguration' => $domainConfiguration]);
    }

    /**
     * Configure the visible columns
     */
    public function buildFields()
    {
        if ($this->domainConfiguration->isMultiDomainHost()) {
            $this->addField('domain', 'redirect.adminlist.header.domain', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        $this->addField('origin', 'redirect.adminlist.header.origin', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->addField('target', 'redirect.adminlist.header.target', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->addField('permanent', 'redirect.adminlist.header.permanent', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->addField('note', 'redirect.adminlist.header.note', true);
    }

    /**
     * Build filters for admin list
     */
    public function buildFilters()
    {
        if ($this->domainConfiguration->isMultiDomainHost()) {
            $hosts = $this->domainConfiguration->getHosts();
            $domains = array_combine($hosts, $hosts);
            $domains = array_merge(array('' => 'redirect.all'), $domains);
            $this->addFilter('domain', new ORM\EnumerationFilterType('domain'), 'redirect.adminlist.filter.domain', $domains);
        }
        $this->addFilter('origin', new ORM\StringFilterType('origin'), 'redirect.adminlist.filter.origin');
        $this->addFilter('target', new ORM\StringFilterType('target'), 'redirect.adminlist.filter.target');
        $this->addFilter('permanent', new ORM\BooleanFilterType('permanent'), 'redirect.adminlist.filter.permanent');
        $this->addFilter('note', new ORM\StringFilterType('note'), 'redirect.adminlist.filter.note');
    }

    /**
     * @param array|object $item       The item
     * @param string       $columnName The column name
     *
     * @return string
     */
    public function getValue($item, $columnName)
    {
        if ($columnName == 'domain' && !$item->getDomain()) {
            return 'All domains';
        }

        return parent::getValue($item, $columnName);
    }

    /**
     * Get bundle name
     *
     * @return string
     */
    public function getBundleName()
    {
        return 'KunstmaanRedirectBundle';
    }

    /**
     * Get entity name
     *
     * @return string
     */
    public function getEntityName()
    {
        return 'Redirect';
    }
}


1		<?php
2
3		namespace Kunstmaan\RedirectBundle\AdminList;
4
5		use Doctrine\ORM\EntityManager;
6		use Kunstmaan\AdminBundle\Helper\DomainConfigurationInterface;
7		use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
8		use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
9		use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM;
10		use Kunstmaan\RedirectBundle\Form\RedirectAdminType;
11
12		class RedirectAdminListConfigurator extends AbstractDoctrineORMAdminListConfigurator
13		{
14		/**
15		* @var DomainConfigurationInterface
16		*/
17		private $domainConfiguration;
18
19		/**
20		* @param EntityManager $em The entity manager
21		* @param AclHelper $aclHelper The acl helper
22		* @param DomainConfigurationInterface $domainConfiguration
23		*/
24	4	public function __construct(EntityManager $em, AclHelper $aclHelper = null, DomainConfigurationInterface $domainConfiguration)
25		{
26	4	parent::__construct($em, $aclHelper);
27
28	4	$this->domainConfiguration = $domainConfiguration;
29
30	4	$this->setAdminType(RedirectAdminType::class);
31	4	$this->setAdminTypeOptions(['domainConfiguration' => $domainConfiguration]);
32	4	}
33
34		/**
35		* Configure the visible columns
36		*/
37	1	public function buildFields()
38		{
39	1	if ($this->domainConfiguration->isMultiDomainHost()) {
40		$this->addField('domain', 'redirect.adminlist.header.domain', true);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41		}
42	1	$this->addField('origin', 'redirect.adminlist.header.origin', true);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43	1	$this->addField('target', 'redirect.adminlist.header.target', true);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44	1	$this->addField('permanent', 'redirect.adminlist.header.permanent', true);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45	1	$this->addField('note', 'redirect.adminlist.header.note', true);
46	1	}
47
48		/**
49		* Build filters for admin list
50		*/
51	1	public function buildFilters()
52		{
53	1	if ($this->domainConfiguration->isMultiDomainHost()) {
54		$hosts = $this->domainConfiguration->getHosts();
55		$domains = array_combine($hosts, $hosts);
56		$domains = array_merge(array('' => 'redirect.all'), $domains);
57		$this->addFilter('domain', new ORM\EnumerationFilterType('domain'), 'redirect.adminlist.filter.domain', $domains);
58		}
59	1	$this->addFilter('origin', new ORM\StringFilterType('origin'), 'redirect.adminlist.filter.origin');
60	1	$this->addFilter('target', new ORM\StringFilterType('target'), 'redirect.adminlist.filter.target');
61	1	$this->addFilter('permanent', new ORM\BooleanFilterType('permanent'), 'redirect.adminlist.filter.permanent');
62	1	$this->addFilter('note', new ORM\StringFilterType('note'), 'redirect.adminlist.filter.note');
63	1	}
64
65		/**
66		* @param array\|object $item The item
67		* @param string $columnName The column name
68		*
69		* @return string
70		*/
71		public function getValue($item, $columnName)
72		{
73		if ($columnName == 'domain' && !$item->getDomain()) {
74		return 'All domains';
75		}
76
77		return parent::getValue($item, $columnName);
78		}
79
80		/**
81		* Get bundle name
82		*
83		* @return string
84		*/
85	1	public function getBundleName()
86		{
87	1	return 'KunstmaanRedirectBundle';
88		}
89
90		/**
91		* Get entity name
92		*
93		* @return string
94		*/
95	1	public function getEntityName()
96		{
97	1	return 'Redirect';
98		}
99		}
100

Kunstmaan / KunstmaanBundlesCMS

Push — master ( e6c0c9...d841f8 )

AdminList/RedirectAdminListConfigurator.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like