Issues in PopupAdminListConfigurator.php - Fixed Issues - Inspection of "Merge branch '5.2'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e6c0c9...d841f8 )

by Jeroen

created 2019-04-19 13:47 UTC

AdminList/PopupAdminListConfigurator.php (5 issues)

Labels

Documentation 5

Severity

Minor 5

Krisztián Ferenczi 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\LeadGenerationBundle\AdminList;

use Doctrine\ORM\EntityManager;
use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM;

class PopupAdminListConfigurator extends AbstractDoctrineORMAdminListConfigurator
{
    /**
     * @param EntityManager $em        The entity manager
     * @param AclHelper     $aclHelper The acl helper
     */
    public function __construct(EntityManager $em, AclHelper $aclHelper = null)
    {
        parent::__construct($em, $aclHelper);

        $this->setListTemplate('KunstmaanLeadGenerationBundle:AdminList:popup-list.html.twig');
        $this->setEditTemplate('KunstmaanLeadGenerationBundle:AdminList:popup-edit.html.twig');
        $this->setAddTemplate('KunstmaanLeadGenerationBundle:AdminList:popup-edit.html.twig');
    }

    /**
     * Configure the visible columns
     */
    public function buildFields()
    {
        $this->addField('id', 'kuma_lead_generation.popup.list.header.id', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->addField('name', 'kuma_lead_generation.popup.list.header.name', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->addField('classname', 'kuma_lead_generation.popup.list.header.type', false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->addField('htmlId', 'kuma_lead_generation.popup.list.header.html_id', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->addField('ruleCount', 'kuma_lead_generation.popup.list.header.rule_count', false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Build filters for admin list
     */
    public function buildFilters()
    {
        $this->addFilter('name', new ORM\StringFilterType('name'), 'kuma_lead_generation.popup.list.filter.name');
        $this->addFilter('htmlId', new ORM\StringFilterType('htmlId'), 'kuma_lead_generation.popup.list.filter.html_id');
    }

    /**
     * Get bundle name
     *
     * @return string
     */
    public function getBundleName()
    {
        return 'KunstmaanLeadGenerationBundle';
    }

    /**
     * Get entity name
     *
     * @return string
     */
    public function getEntityName()
    {
        return 'Popup\AbstractPopup';
    }

    /**
     * @param object|array $item
     *
     * @return bool
     */
    public function canEdit($item)
    {
        return true;
    }

    /**
     * Configure if it's possible to delete the given $item
     *
     * @param object|array $item
     *
     * @return bool
     */
    public function canDelete($item)
    {
        return true;
    }

    /**
     * Configure if it's possible to add new items
     *
     * @return bool
     */
    public function canAdd()
    {
        return true;
    }
}


1		<?php
2
3		namespace Kunstmaan\LeadGenerationBundle\AdminList;
4
5		use Doctrine\ORM\EntityManager;
6		use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
7		use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
8		use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM;
9
10		class PopupAdminListConfigurator extends AbstractDoctrineORMAdminListConfigurator
11		{
12		/**
13		* @param EntityManager $em The entity manager
14		* @param AclHelper $aclHelper The acl helper
15		*/
16	View Code Duplication	public function __construct(EntityManager $em, AclHelper $aclHelper = null)
17		{
18		parent::__construct($em, $aclHelper);
19
20		$this->setListTemplate('KunstmaanLeadGenerationBundle:AdminList:popup-list.html.twig');
21		$this->setEditTemplate('KunstmaanLeadGenerationBundle:AdminList:popup-edit.html.twig');
22		$this->setAddTemplate('KunstmaanLeadGenerationBundle:AdminList:popup-edit.html.twig');
23		}
24
25		/**
26		* Configure the visible columns
27		*/
28		public function buildFields()
29		{
30		$this->addField('id', 'kuma_lead_generation.popup.list.header.id', true);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31		$this->addField('name', 'kuma_lead_generation.popup.list.header.name', true);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32		$this->addField('classname', 'kuma_lead_generation.popup.list.header.type', false);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33		$this->addField('htmlId', 'kuma_lead_generation.popup.list.header.html_id', true);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34		$this->addField('ruleCount', 'kuma_lead_generation.popup.list.header.rule_count', false);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35		}
36
37		/**
38		* Build filters for admin list
39		*/
40		public function buildFilters()
41		{
42		$this->addFilter('name', new ORM\StringFilterType('name'), 'kuma_lead_generation.popup.list.filter.name');
43		$this->addFilter('htmlId', new ORM\StringFilterType('htmlId'), 'kuma_lead_generation.popup.list.filter.html_id');
44		}
45
46		/**
47		* Get bundle name
48		*
49		* @return string
50		*/
51		public function getBundleName()
52		{
53		return 'KunstmaanLeadGenerationBundle';
54		}
55
56		/**
57		* Get entity name
58		*
59		* @return string
60		*/
61		public function getEntityName()
62		{
63		return 'Popup\AbstractPopup';
64		}
65
66		/**
67		* @param object\|array $item
68		*
69		* @return bool
70		*/
71		public function canEdit($item)
72		{
73		return true;
74		}
75
76		/**
77		* Configure if it's possible to delete the given $item
78		*
79		* @param object\|array $item
80		*
81		* @return bool
82		*/
83		public function canDelete($item)
84		{
85		return true;
86		}
87
88		/**
89		* Configure if it's possible to add new items
90		*
91		* @return bool
92		*/
93		public function canAdd()
94		{
95		return true;
96		}
97		}
98

Kunstmaan / KunstmaanBundlesCMS

Push — master ( e6c0c9...d841f8 )

AdminList/PopupAdminListConfigurator.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like