UrlValidatorTest - Code Metrics - Inspection of "[NodeBundle] Replace numeric regex check (#2475)" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a87692...4e64ba )

by Ruud

created 2019-06-11 13:53 UTC

UrlValidatorTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	71
Duplicated Lines	33.8 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	1
dl	24
loc	71
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	testIsEmailAddress()	0	4	1
A	testIsInternalLink()	0	4	1
A	testIsInternalMediaLink()	0	4	1
A	emailAddressProvider()	0	8	1
A	internalLinkProvider()	12	12	1
A	internalMediaLinkProvider()	12	12	1

How to fix Duplicated Code

<?php

namespace Kunstmaan\NodeBundle\Tests\Helper;

use Kunstmaan\NodeBundle\Validation\URLValidator;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;

class UrlValidatorTest extends TestCase
{
    /**
     * @var URLValidator|MockObject
     */
    private $validatorMock;

    protected function setUp()
    {
        $this->validatorMock = $this->getMockForTrait(URLValidator::class);
    }

    /**
     * @dataProvider emailAddressProvider
     */
    public function testIsEmailAddress($email, $result)
    {
        $this->assertSame($result, $this->validatorMock->isEmailAddress($email));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @dataProvider internalLinkProvider
     */
    public function testIsInternalLink($link, $result)
    {
        $this->assertSame($result, $this->validatorMock->isInternalLink($link));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @dataProvider internalMediaLinkProvider
     */
    public function testIsInternalMediaLink($link, $result)
    {
        $this->assertSame($result, $this->validatorMock->isInternalMediaLink($link));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function emailAddressProvider()
    {
        return [
            ['abc', false],
            ['[email protected]', '[email protected]'],
            ['test@local', false],
        ];
    }

    public function internalLinkProvider()

    {
        return [
            ['[NT:123]', false],
            ['[NT123]', true],
            ['[NTABC]', false],
            ['[NT123ABC]', false],
            ['[host_a:NT123]', true],
            ['http://www.google.com', false],
            ['[NT123][M20]', true],
        ];
    }

    public function internalMediaLinkProvider()

    {
        return [
            ['[M:123]', false],
            ['[M123]', true],
            ['[MABC]', false],
            ['[M123ABC]', false],
            ['[host_a:M23]', true],
            ['http://www.google.com', false],
            ['[M123][NT20]', true],
        ];
    }
}


Push — master ( a87692...4e64ba )

UrlValidatorTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Kunstmaan\NodeBundle\Tests\Helper;
4
5		use Kunstmaan\NodeBundle\Validation\URLValidator;
6		use PHPUnit\Framework\MockObject\MockObject;
7		use PHPUnit\Framework\TestCase;
8
9		class UrlValidatorTest extends TestCase
10		{
11		/**
12		* @var URLValidator\|MockObject
13		*/
14		private $validatorMock;
15
16		protected function setUp()
17		{
18		$this->validatorMock = $this->getMockForTrait(URLValidator::class);
19		}
20
21		/**
22		* @dataProvider emailAddressProvider
23		*/
24		public function testIsEmailAddress($email, $result)
25		{
26		$this->assertSame($result, $this->validatorMock->isEmailAddress($email));
		0 ignored issues – show Bug introduced 2019-05-22 09:30 UTC by Report Bug Copy Issue Report The method `isEmailAddress` does only exist in `Kunstmaan\NodeBundle\Validation\URLValidator`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27		}
28
29		/**
30		* @dataProvider internalLinkProvider
31		*/
32		public function testIsInternalLink($link, $result)
33		{
34		$this->assertSame($result, $this->validatorMock->isInternalLink($link));
		0 ignored issues – show Bug introduced 2019-05-22 09:30 UTC by Report Bug Copy Issue Report The method `isInternalLink` does only exist in `Kunstmaan\NodeBundle\Validation\URLValidator`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
35		}
36
37		/**
38		* @dataProvider internalMediaLinkProvider
39		*/
40		public function testIsInternalMediaLink($link, $result)
41		{
42		$this->assertSame($result, $this->validatorMock->isInternalMediaLink($link));
		0 ignored issues – show Bug introduced 2019-05-22 09:30 UTC by Report Bug Copy Issue Report The method `isInternalMediaLink` does only exist in `Kunstmaan\NodeBundle\Validation\URLValidator`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
43		}
44
45		public function emailAddressProvider()
46		{
47		return [
48		['abc', false],
49		['[email protected]', '[email protected]'],
50		['test@local', false],
51		];
52		}
53
54	View Code Duplication	public function internalLinkProvider()
		0 ignored issues – show Duplication introduced 2019-05-22 09:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		return [
57		['[NT:123]', false],
58		['[NT123]', true],
59		['[NTABC]', false],
60		['[NT123ABC]', false],
61		['[host_a:NT123]', true],
62		['http://www.google.com', false],
63		['[NT123][M20]', true],
64		];
65		}
66
67	View Code Duplication	public function internalMediaLinkProvider()
		0 ignored issues – show Duplication introduced 2019-05-22 09:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		return [
70		['[M:123]', false],
71		['[M123]', true],
72		['[MABC]', false],
73		['[M123ABC]', false],
74		['[host_a:M23]', true],
75		['http://www.google.com', false],
76		['[M123][NT20]', true],
77		];
78		}
79		}
80

Kunstmaan / KunstmaanBundlesCMS

Push — master ( a87692...4e64ba )

UrlValidatorTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like