EntityVersionLockService::isEntityLocked() - Code Metrics - Inspection of "[AdminBundle][FosuUserBundle] Deprecate FosUserBun..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2737)

by Jeroen

created 2020-10-30 14:49 UTC

EntityVersionLockService::isEntityLocked() B

↳ Parent: EntityVersionLockService

Complexity

Conditions	6
Paths	4

Size

Total Lines

Duplication

Lines	3
Ratio	10.71 %

Code Coverage

Tests	10
CRAP Score	6.027

Importance

Changes

Metric	Value
dl	3
loc	28
c	0
b	0
f	0
rs	8.8497
ccs	10
cts	11
cp	0.9091
cc	6
nc	4
nop	2
crap	6.027

<?php

namespace Kunstmaan\AdminListBundle\Service;

use Doctrine\Common\Persistence\ObjectManager;
use FOS\UserBundle\Model\User;
use Kunstmaan\AdminBundle\Entity\UserInterface;
use Kunstmaan\AdminListBundle\Entity\LockableEntity;
use Kunstmaan\AdminListBundle\Entity\EntityVersionLock;
use Kunstmaan\AdminListBundle\Entity\LockableEntityInterface;
use Kunstmaan\AdminListBundle\Repository\EntityVersionLockRepository;

class EntityVersionLockService
{
    /**
     * @var ObjectManager
     */
    private $objectManager;

    /**
     * @var int
     */
    private $threshold;

    /**
     * @var bool
     */
    private $lockEnabled;

    public function __construct(ObjectManager $em, $threshold, $lockEnabled)
    {
        $this->setObjectManager($em);
        $this->setThreshold($threshold);
        $this->setLockEnabled($lockEnabled);
    }

    /**
     * @param LockableEntityInterface $entity
     *
     * @return bool
     */
    public function isEntityBelowThreshold(LockableEntityInterface $entity)
    {
        /** @var LockableEntity $lockable */
        $lockable = $this->getLockableEntity($entity, false);

        if ($this->lockEnabled && $lockable->getId() !== null) {
            $now = new \DateTime();
            $thresholdDate = clone $lockable->getUpdated();
            $thresholdDate->add(new \DateInterval('PT'.$this->threshold.'S'));

            return $thresholdDate > $now;
        }

        return false;
    }

    /**
     * @param User                    $user
     * @param LockableEntityInterface $entity
     *
     * @return bool
     */
    public function isEntityLocked(/*\Kunstmaan\AdminBundle\Entity\UserInterface*/ $user, LockableEntityInterface $entity)
    {
        // NEXT_MAJOR: remove type check and enable parameter typehint
        if (!$user instanceof User && !$user instanceof UserInterface) {

            throw new \InvalidArgumentException(sprintf('The "$user" argument must be of type "%s" or implement the "%s" interface', User::class, UserInterface::class));
        }

        /** @var LockableEntity $lockable */
        $lockable = $this->getLockableEntity($entity);

        if ($this->lockEnabled) {
            $this->removeExpiredLocks($lockable);
            $locks = $this->getEntityVersionLocksByLockableEntity($lockable, $user);

            if ($locks === null || !\count($locks)) {
                $this->createEntityVersionLock($user, $lockable);

                $lockable->setUpdated(new \DateTime());
                $this->objectManager->flush();

                return false;
            }

            return true;
        }

        return false;
    }

    /**
     * When editing the entity, create a new entity translation lock.
     *
     * @param User           $user
     * @param LockableEntity $entity
     */
    protected function createEntityVersionLock(/*\Kunstmaan\AdminBundle\Entity\UserInterface*/ $user, LockableEntity $entity)
    {
        // NEXT_MAJOR: remove type check and enable parameter typehint
        if (!$user instanceof User && !$user instanceof UserInterface) {

            throw new \InvalidArgumentException(sprintf('The "$user" argument must be of type "%s" or implement the "%s" interface', User::class, UserInterface::class));
        }

        /** @var EntityVersionLock $lock */
        $lock = $this->objectManager->getRepository(EntityVersionLock::class)->findOneBy([
            'owner' => $user->getUsername(),
            'lockableEntity' => $entity,
        ]);
        if (!$lock) {
            $lock = new EntityVersionLock();
        }
        $lock->setOwner($user->getUsername());
        $lock->setLockableEntity($entity);
        $lock->setCreatedAt(new \DateTime());
        $this->objectManager->persist($lock);
        $this->objectManager->flush();
    }

    /**
     * @param LockableEntityInterface $entity
     * @param User                    $userToExclude

     *
     * @return array
     */
    public function getUsersWithEntityVersionLock(LockableEntityInterface $entity, /*\Kunstmaan\AdminBundle\Entity\UserInterface*/ $userToExclude = null)
    {
        // NEXT_MAJOR: remove type check and enable parameter typehint
        if (!$userToExclude instanceof User && !$userToExclude instanceof UserInterface) {

            throw new \InvalidArgumentException(sprintf('The "$userToExclude" argument must be of type "%s" or implement the "%s" interface', User::class, UserInterface::class));
        }

        /** @var LockableEntity $lockable */
        $lockable = $this->getLockableEntity($entity);

        return  array_reduce(
            $this->getEntityVersionLocksByLockableEntity($lockable, $userToExclude),
            function ($return, EntityVersionLock $item) {
                $return[] = $item->getOwner();

                return $return;
            },
            []
        );
    }

    /**
     * @param LockableEntity $entity
     */
    protected function removeExpiredLocks(LockableEntity $entity)
    {
        $locks = $this->objectManager->getRepository(EntityVersionLock::class)->getExpiredLocks($entity, $this->threshold);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        foreach ($locks as $lock) {
            $this->objectManager->remove($lock);
        }
    }

    /**
     * When editing an entity, check if there is a lock for this entity.
     *
     * @param LockableEntity $entity
     * @param User           $userToExclude

     *
     * @return EntityVersionLock[]

     */
    protected function getEntityVersionLocksByLockableEntity(LockableEntity $entity, /*\Kunstmaan\AdminBundle\Entity\UserInterface*/ $userToExclude = null)
    {
        // NEXT_MAJOR: remove type check and enable parameter typehint
        if (!$userToExclude instanceof User && !$userToExclude instanceof UserInterface) {

            throw new \InvalidArgumentException(sprintf('The "$userToExclude" argument must be of type "%s" or implement the "%s" interface', User::class, UserInterface::class));
        }

        /** @var EntityVersionLockRepository $objectRepository */
        $objectRepository = $this->objectManager->getRepository(EntityVersionLock::class);

        return $objectRepository->getLocksForLockableEntity($entity, $this->threshold, $userToExclude);
    }

    /**
     * Get or create a LockableEntity for an entity with LockableEntityInterface
     *
     * @param LockableEntityInterface $entity
     *
     * @return LockableEntity
     */
    protected function getLockableEntity(LockableEntityInterface $entity, $create = true)
    {
        /** @var LockableEntity $lockable */
        $lockable = $this->objectManager->getRepository(LockableEntity::class)->getOrCreate($entity->getId(), \get_class($entity));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        if ($create === true && $lockable->getId() === null) {
            $this->objectManager->persist($lockable);
            $this->objectManager->flush();
        }

        return $lockable;
    }

    /**
     * @param ObjectManager $objectManager
     */
    public function setObjectManager($objectManager)
    {
        $this->objectManager = $objectManager;
    }

    /**
     * @param int $threshold
     */
    public function setThreshold($threshold)
    {
        $this->threshold = $threshold;
    }

    /**
     * @param bool lockEnabled
     */
    public function setLockEnabled($lockEnabled)
    {
        $this->lockEnabled = $lockEnabled;
    }
}


Pull Request — master (#2737)

EntityVersionLockService::isEntityLocked() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace Kunstmaan\AdminListBundle\Service;
4
5			use Doctrine\Common\Persistence\ObjectManager;
6			use FOS\UserBundle\Model\User;
7			use Kunstmaan\AdminBundle\Entity\UserInterface;
8			use Kunstmaan\AdminListBundle\Entity\LockableEntity;
9			use Kunstmaan\AdminListBundle\Entity\EntityVersionLock;
10			use Kunstmaan\AdminListBundle\Entity\LockableEntityInterface;
11			use Kunstmaan\AdminListBundle\Repository\EntityVersionLockRepository;
12
13			class EntityVersionLockService
14			{
15			/**
16			* @var ObjectManager
17			*/
18			private $objectManager;
19
20			/**
21			* @var int
22			*/
23			private $threshold;
24
25			/**
26			* @var bool
27			*/
28			private $lockEnabled;
29	6
30			public function __construct(ObjectManager $em, $threshold, $lockEnabled)
31	6		{
32	6		$this->setObjectManager($em);
33	6		$this->setThreshold($threshold);
34	6		$this->setLockEnabled($lockEnabled);
35			}
36
37			/**
38			* @param LockableEntityInterface $entity
39			*
40			* @return bool
41	3		*/
42			public function isEntityBelowThreshold(LockableEntityInterface $entity)
43			{
44	3		/** @var LockableEntity $lockable */
45			$lockable = $this->getLockableEntity($entity, false);
46	3
47	2		if ($this->lockEnabled && $lockable->getId() !== null) {
48	2		$now = new \DateTime();
49	2		$thresholdDate = clone $lockable->getUpdated();
50			$thresholdDate->add(new \DateInterval('PT'.$this->threshold.'S'));
51	2
52			return $thresholdDate > $now;
53			}
54	1
55			return false;
56			}
57
58			/**
59			* @param User $user
60			* @param LockableEntityInterface $entity
61			*
62			* @return bool
63	2		*/
64			public function isEntityLocked(/\Kunstmaan\AdminBundle\Entity\UserInterface/ $user, LockableEntityInterface $entity)
65			{
66	2		// NEXT_MAJOR: remove type check and enable parameter typehint
67		View Code Duplication	if (!$user instanceof User && !$user instanceof UserInterface) {
			0 ignored issues – show Duplication introduced 2020-05-08 08:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68	2		throw new \InvalidArgumentException(sprintf('The "$user" argument must be of type "%s" or implement the "%s" interface', User::class, UserInterface::class));
69	2		}
70	2
71			/** @var LockableEntity $lockable */
72	2		$lockable = $this->getLockableEntity($entity);
73	1
74			if ($this->lockEnabled) {
75	1		$this->removeExpiredLocks($lockable);
76	1		$locks = $this->getEntityVersionLocksByLockableEntity($lockable, $user);
77
78	1		if ($locks === null \|\| !\count($locks)) {
79			$this->createEntityVersionLock($user, $lockable);
80
81	1		$lockable->setUpdated(new \DateTime());
82			$this->objectManager->flush();
83
84			return false;
85			}
86
87			return true;
88			}
89
90			return false;
91			}
92
93	1		/**
94			* When editing the entity, create a new entity translation lock.
95			*
96	1		* @param User $user
97	1		* @param LockableEntity $entity
98	1		*/
99			protected function createEntityVersionLock(/\Kunstmaan\AdminBundle\Entity\UserInterface/ $user, LockableEntity $entity)
100	1		{
101			// NEXT_MAJOR: remove type check and enable parameter typehint
102		View Code Duplication	if (!$user instanceof User && !$user instanceof UserInterface) {
			0 ignored issues – show Duplication introduced 2020-05-08 08:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103	1		throw new \InvalidArgumentException(sprintf('The "$user" argument must be of type "%s" or implement the "%s" interface', User::class, UserInterface::class));
104	1		}
105	1
106	1		/** @var EntityVersionLock $lock */
107	1		$lock = $this->objectManager->getRepository(EntityVersionLock::class)->findOneBy([
108	1		'owner' => $user->getUsername(),
109			'lockableEntity' => $entity,
110			]);
111			if (!$lock) {
112			$lock = new EntityVersionLock();
113			}
114			$lock->setOwner($user->getUsername());
115			$lock->setLockableEntity($entity);
116	1		$lock->setCreatedAt(new \DateTime());
117			$this->objectManager->persist($lock);
118			$this->objectManager->flush();
119	1		}
120
121	1		/**
122	1		* @param LockableEntityInterface $entity
123			* @param User $userToExclude
			0 ignored issues – show Documentation introduced 2020-05-08 08:07 UTC by Report Bug Copy Issue Report Should the type for parameter `$userToExclude` not be `User\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
124	1		*
125			* @return array
126	1		*/
127	1		public function getUsersWithEntityVersionLock(LockableEntityInterface $entity, /\Kunstmaan\AdminBundle\Entity\UserInterface/ $userToExclude = null)
128	1		{
129			// NEXT_MAJOR: remove type check and enable parameter typehint
130		View Code Duplication	if (!$userToExclude instanceof User && !$userToExclude instanceof UserInterface) {
			0 ignored issues – show Duplication introduced 2020-05-08 08:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
131			throw new \InvalidArgumentException(sprintf('The "$userToExclude" argument must be of type "%s" or implement the "%s" interface', User::class, UserInterface::class));
132			}
133
134			/** @var LockableEntity $lockable */
135	2		$lockable = $this->getLockableEntity($entity);
136
137	2		return array_reduce(
138	2		$this->getEntityVersionLocksByLockableEntity($lockable, $userToExclude),
139	2		function ($return, EntityVersionLock $item) {
140			$return[] = $item->getOwner();
141	2
142			return $return;
143			},
144			[]
145			);
146			}
147
148			/**
149			* @param LockableEntity $entity
150			*/
151	3		protected function removeExpiredLocks(LockableEntity $entity)
152			{
153			$locks = $this->objectManager->getRepository(EntityVersionLock::class)->getExpiredLocks($entity, $this->threshold);
			0 ignored issues – show Bug introduced 2020-04-13 12:32 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Doctrine\Persistence\ObjectRepository` as the method `getExpiredLocks()` does only exist in the following implementations of said interface: `Kunstmaan\AdminListBundl...tyVersionLockRepository`, `Kunstmaan\NodeBundle\Rep...deVersionLockRepository`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
154	3		foreach ($locks as $lock) {
155			$this->objectManager->remove($lock);
156	3		}
157			}
158
159			/**
160			* When editing an entity, check if there is a lock for this entity.
161			*
162			* @param LockableEntity $entity
163			* @param User $userToExclude
			0 ignored issues – show Documentation introduced 2020-05-08 08:07 UTC by Report Bug Copy Issue Report Should the type for parameter `$userToExclude` not be `User\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
164			*
165			* @return EntityVersionLock[]
			0 ignored issues – show Documentation introduced 2018-09-26 07:17 UTC by Report Bug Copy Issue Report Should the return type not be `\Kunstmaan\AdminListBund...ory\EntityVersionLock[]`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
166	6		*/
167			protected function getEntityVersionLocksByLockableEntity(LockableEntity $entity, /\Kunstmaan\AdminBundle\Entity\UserInterface/ $userToExclude = null)
168			{
169	6		// NEXT_MAJOR: remove type check and enable parameter typehint
170		View Code Duplication	if (!$userToExclude instanceof User && !$userToExclude instanceof UserInterface) {
			0 ignored issues – show Duplication introduced 2020-09-30 15:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
171	6		throw new \InvalidArgumentException(sprintf('The "$userToExclude" argument must be of type "%s" or implement the "%s" interface', User::class, UserInterface::class));
172			}
173
174			/** @var EntityVersionLockRepository $objectRepository */
175			$objectRepository = $this->objectManager->getRepository(EntityVersionLock::class);
176	6
177			return $objectRepository->getLocksForLockableEntity($entity, $this->threshold, $userToExclude);
178			}
179
180			/**
181			* Get or create a LockableEntity for an entity with LockableEntityInterface
182	6		*
183			* @param LockableEntityInterface $entity
184	6		*
185	6		* @return LockableEntity
186			*/
187			protected function getLockableEntity(LockableEntityInterface $entity, $create = true)
188			{
189			/** @var LockableEntity $lockable */
190	6		$lockable = $this->objectManager->getRepository(LockableEntity::class)->getOrCreate($entity->getId(), \get_class($entity));
			0 ignored issues – show Bug introduced 2020-04-13 12:32 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Doctrine\Persistence\ObjectRepository` as the method `getOrCreate()` does only exist in the following implementations of said interface: `Kunstmaan\AdminListBundl...ockableEntityRepository`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
191
192	6		if ($create === true && $lockable->getId() === null) {
193	6		$this->objectManager->persist($lockable);
194			$this->objectManager->flush();
195			}
196
197			return $lockable;
198	6		}
199
200	6		/**
201	6		* @param ObjectManager $objectManager
202			*/
203			public function setObjectManager($objectManager)
204			{
205			$this->objectManager = $objectManager;
206			}
207
208			/**
209			* @param int $threshold
210			*/
211			public function setThreshold($threshold)
212			{
213			$this->threshold = $threshold;
214			}
215
216			/**
217			* @param bool lockEnabled
218			*/
219			public function setLockEnabled($lockEnabled)
220			{
221			$this->lockEnabled = $lockEnabled;
222			}
223			}
224

Kunstmaan / KunstmaanBundlesCMS

Pull Request — master (#2737)

EntityVersionLockService::isEntityLocked() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like