Issues in KunstmaanConfigConfigurationPassCompilerPassTest.php - All Issues - Inspection of "Fixed issue with locale in kuma:user:create comman..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2101)

by Kevin

created 2018-09-06 16:06 UTC

...maanConfigConfigurationPassCompilerPassTest.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\ConfigBundle\Tests\DependencyInjection\Compiler;

use Kunstmaan\ConfigBundle\Entity\ConfigurationInterface;
use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractCompilerPassTestCase;
use Kunstmaan\ConfigBundle\DependencyInjection\Compiler\KunstmaanConfigConfigurationPass;
use ReflectionException;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;

class FakeDoctrine
{
    public function getManagerForClass()
    {
        return true;
    }
}

class FakeDoctrineFalse

{
    /**
     * @throws \ReflectionException
     */
    public function getManagerForClass()
    {
        throw new ReflectionException();
    }
}

class RandomEntity implements ConfigurationInterface

{
    /**
     * @return string
     */
    public function getDefaultAdminType()
    {
        return 'whatever';
    }

    /**
     * @return string
     */
    public function getInternalName()
    {
        return 'whatever';
    }

    /**
     * @return string
     */
    public function getLabel()
    {
        return 'whatever';
    }

    /**
     * @return array
     */
    public function getRoles()
    {
        return [];
    }
}

class RandomNonConfigEntity

{
}

class KunstmaanConfigConfigurationPassCompilerPassTest extends AbstractCompilerPassTestCase

{
    protected function registerCompilerPass(ContainerBuilder $container)
    {
        $container->addCompilerPass(new KunstmaanConfigConfigurationPass());
    }

    public function testContainerKeys()
    {
        $doctrine = new FakeDoctrine();

        $svcId = 'kunstmaan_config';

        $this->container->setParameter($svcId, [
            'entities' => [
                'Test\Kunstmaan\ConfigBundle\DependencyInjection\Compiler\RandomEntity'
            ],
        ]);
        $this->container->setDefinition('doctrine', new Definition($doctrine));

        $svc = new Definition();
        $svc->addTag('doctrine');
        $this->setDefinition($svcId, $svc);

        $this->compile();
    }

    public function testExceptionIsThrownWhenNoEntitiesDefined()
    {
        // No longer fails on compile, just returns an empty array, but proof will show in code coverage
        $svcId = 'kunstmaan_config';

        $this->container->setParameter($svcId, []);
        $this->compile();
    }

    public function testExceptionIsThrownWhenNoEntitiesFoundByDoctrine()
    {
        $doctrine = new FakeDoctrineFalse();

        $svcId = 'kunstmaan_config';

        $this->container->setParameter($svcId, [
            'entities' => [
                'BrokenEntity'
            ],
        ]);
        $this->container->setDefinition('doctrine', new Definition($doctrine));

        $svc = new Definition();
        $svc->addTag('doctrine');
        $this->setDefinition($svcId, $svc);

        $this->compile();
    }

    public function testExceptionIsThrownWhenEntityNotAConfigInterface()
    {
        $doctrine = new FakeDoctrine();

        $svcId = 'kunstmaan_config';

        $this->container->setParameter($svcId, [
            'entities' => [
                'Test\Kunstmaan\ConfigBundle\DependencyInjection\Compiler\RandomNonConfigEntity'
            ],
        ]);
        $this->container->setDefinition('doctrine', new Definition($doctrine));

        $svc = new Definition();
        $svc->addTag('doctrine');
        $this->setDefinition($svcId, $svc);

        $this->compile();
    }
}

1			<?php
2
3			namespace Kunstmaan\ConfigBundle\Tests\DependencyInjection\Compiler;
4
5			use Kunstmaan\ConfigBundle\Entity\ConfigurationInterface;
6			use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractCompilerPassTestCase;
7			use Kunstmaan\ConfigBundle\DependencyInjection\Compiler\KunstmaanConfigConfigurationPass;
8			use ReflectionException;
9			use Symfony\Component\DependencyInjection\ContainerBuilder;
10			use Symfony\Component\DependencyInjection\Definition;
11
12			class FakeDoctrine
13			{
14			public function getManagerForClass()
15			{
16			return true;
17			}
18			}
19
20			class FakeDoctrineFalse
			0 ignored issues – show Coding Style Compatibility introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
21			{
22			/**
23			* @throws \ReflectionException
24			*/
25			public function getManagerForClass()
26			{
27			throw new ReflectionException();
28			}
29			}
30
31			class RandomEntity implements ConfigurationInterface
			0 ignored issues – show Coding Style Compatibility introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
32			{
33			/**
34			* @return string
35			*/
36			public function getDefaultAdminType()
37			{
38			return 'whatever';
39			}
40
41			/**
42			* @return string
43			*/
44			public function getInternalName()
45			{
46			return 'whatever';
47			}
48
49			/**
50			* @return string
51			*/
52			public function getLabel()
53			{
54			return 'whatever';
55			}
56
57			/**
58			* @return array
59			*/
60			public function getRoles()
61			{
62			return [];
63			}
64			}
65
66			class RandomNonConfigEntity
			0 ignored issues – show Coding Style Compatibility introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
67			{
68			}
69
70			class KunstmaanConfigConfigurationPassCompilerPassTest extends AbstractCompilerPassTestCase
			0 ignored issues – show Coding Style Compatibility introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
71			{
72			protected function registerCompilerPass(ContainerBuilder $container)
73			{
74			$container->addCompilerPass(new KunstmaanConfigConfigurationPass());
75			}
76
77			public function testContainerKeys()
78			{
79			$doctrine = new FakeDoctrine();
80
81			$svcId = 'kunstmaan_config';
82
83			$this->container->setParameter($svcId, [
84			'entities' => [
85			'Test\Kunstmaan\ConfigBundle\DependencyInjection\Compiler\RandomEntity'
86			],
87			]);
88			$this->container->setDefinition('doctrine', new Definition($doctrine));
89
90			$svc = new Definition();
91			$svc->addTag('doctrine');
92			$this->setDefinition($svcId, $svc);
93
94			$this->compile();
95			}
96
97			public function testExceptionIsThrownWhenNoEntitiesDefined()
98			{
99			// No longer fails on compile, just returns an empty array, but proof will show in code coverage
100			$svcId = 'kunstmaan_config';
101
102			$this->container->setParameter($svcId, []);
103			$this->compile();
104			}
105
106			public function testExceptionIsThrownWhenNoEntitiesFoundByDoctrine()
107			{
108			$doctrine = new FakeDoctrineFalse();
109
110			$svcId = 'kunstmaan_config';
111
112			$this->container->setParameter($svcId, [
113			'entities' => [
114			'BrokenEntity'
115			],
116			]);
117			$this->container->setDefinition('doctrine', new Definition($doctrine));
118
119			$svc = new Definition();
120			$svc->addTag('doctrine');
121			$this->setDefinition($svcId, $svc);
122
123			$this->compile();
124			}
125
126			public function testExceptionIsThrownWhenEntityNotAConfigInterface()
127			{
128			$doctrine = new FakeDoctrine();
129
130			$svcId = 'kunstmaan_config';
131
132			$this->container->setParameter($svcId, [
133			'entities' => [
134			'Test\Kunstmaan\ConfigBundle\DependencyInjection\Compiler\RandomNonConfigEntity'
135			],
136			]);
137			$this->container->setDefinition('doctrine', new Definition($doctrine));
138
139			$svc = new Definition();
140			$svc->addTag('doctrine');
141			$this->setDefinition($svcId, $svc);
142
143			$this->compile();
144			}
145			}

Kunstmaan / KunstmaanBundlesCMS

Pull Request — master (#2101)

...maanConfigConfigurationPassCompilerPassTest.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like