Completed
Pull Request — master (#1994)
by Sander
18:05
created
src/Kunstmaan/AdminBundle/Toolbar/BundleVersionDataCollector.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Doctrine\Common\Cache\Cache;
6 6
 use Kunstmaan\AdminBundle\Helper\Toolbar\AbstractDataCollector;
7 7
 use Kunstmaan\AdminBundle\Helper\VersionCheck\VersionChecker;
8
-use Monolog\Logger;
9 8
 use Symfony\Component\HttpFoundation\Request;
10 9
 use Symfony\Component\HttpFoundation\Response;
11 10
 
Please login to merge, or discard this patch.
src/Kunstmaan/AdminBundle/Twig/MultiDomainAdminTwigExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
     /**
24 24
      * Get Twig functions defined in this extension.
25 25
      *
26
-     * @return array
26
+     * @return Twig_SimpleFunction[]
27 27
      */
28 28
     public function getFunctions()
29 29
     {
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/AdminList/BulkAction/SimpleBulkAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     private $template;
30 30
 
31 31
     /**
32
-     * @param array    $url      The url path and parameters
32
+     * @param string[]    $url      The url path and parameters
33 33
      * @param string   $label    The label
34 34
      * @param string   $icon     The icon
35 35
      * @param string   $template The template
Please login to merge, or discard this patch.
AdminList/Configurator/AbstractDoctrineORMAdminListConfigurator.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
     /**
60 60
      * Return the url to edit the given $item
61 61
      *
62
-     * @param object $item
62
+     * @param \Kunstmaan\LeadGenerationBundle\Tests\Entity\Popup\Popup $item
63 63
      *
64 64
      * @return array
65 65
      */
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
     /**
78 78
      * Get the delete url for the given $item
79 79
      *
80
-     * @param object $item
80
+     * @param \Kunstmaan\LeadGenerationBundle\Tests\Entity\Popup\Popup $item
81 81
      *
82 82
      * @return array
83 83
      */
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/AdminList/Field.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -103,6 +103,9 @@  discard block
 block discarded – undo
103 103
         return true;
104 104
     }
105 105
 
106
+    /**
107
+     * @param \stdClass $item
108
+     */
106 109
     public function getAliasObj($item)
107 110
     {
108 111
         $relation = $this->alias->getRelation();
@@ -115,6 +118,9 @@  discard block
 block discarded – undo
115 118
         return $item;
116 119
     }
117 120
 
121
+    /**
122
+     * @param string $column
123
+     */
118 124
     public function getColumnName($column)
119 125
     {
120 126
         $abbr = $this->alias->getAbbr().'.';
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/AdminList/FieldAlias.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -9,8 +9,8 @@
 block discarded – undo
9 9
 {
10 10
     /**
11 11
      * FieldAlias constructor.
12
-     * @param $abbr string
13
-     * @param $relation string
12
+     * @param string $abbr string
13
+     * @param string $relation string
14 14
      */
15 15
     public function __construct($abbr, $relation)
16 16
     {
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/AdminList/ItemAction/SimpleItemAction.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param mixed $item
63
+     * @param \stdClass $item
64 64
      *
65 65
      * @return string
66 66
      */
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
     }
71 71
 
72 72
     /**
73
-     * @param mixed $item
73
+     * @param \stdClass $item
74 74
      *
75 75
      * @return string
76 76
      */
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Controller/AdminListController.php 1 patch
Doc Comments   +10 added lines, -5 removed lines patch added patch discarded remove patch
@@ -32,6 +32,7 @@  discard block
 block discarded – undo
32 32
      * {@inheritdoc}
33 33
      *
34 34
      * @deprecated
35
+     * @param string $id
35 36
      */
36 37
     protected function get($id)
37 38
     {
@@ -44,6 +45,7 @@  discard block
 block discarded – undo
44 45
      * {@inheritdoc}
45 46
      *
46 47
      * @deprecated
48
+     * @param string $name
47 49
      */
48 50
     protected function getParameter($name)
49 51
     {
@@ -56,7 +58,7 @@  discard block
 block discarded – undo
56 58
     /**
57 59
      * You can override this method to return the correct entity manager when using multiple databases ...
58 60
      *
59
-     * @return \Doctrine\Common\Persistence\ObjectManager|object
61
+     * @return \Doctrine\Common\Persistence\ObjectManager
60 62
      */
61 63
     protected function getEntityManager()
62 64
     {
@@ -67,7 +69,7 @@  discard block
 block discarded – undo
67 69
      * Shows the list of entities
68 70
      *
69 71
      * @param AbstractAdminListConfigurator $configurator
70
-     * @param null|Request $request
72
+     * @param Request $request
71 73
      *
72 74
      * @return Response
73 75
      */
@@ -119,7 +121,7 @@  discard block
 block discarded – undo
119 121
      *
120 122
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
121 123
      * @param string $type The type to add
122
-     * @param null|Request $request
124
+     * @param Request $request
123 125
      *
124 126
      * @throws AccessDeniedHttpException
125 127
      *
@@ -214,7 +216,7 @@  discard block
 block discarded – undo
214 216
      *
215 217
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
216 218
      * @param string $entityId The id of the entity that will be edited
217
-     * @param null|Request $request
219
+     * @param Request $request
218 220
      *
219 221
      * @throws NotFoundHttpException
220 222
      * @throws AccessDeniedHttpException
@@ -371,7 +373,7 @@  discard block
 block discarded – undo
371 373
      *
372 374
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
373 375
      * @param integer $entityId The id to delete
374
-     * @param null|Request $request
376
+     * @param Request $request
375 377
      *
376 378
      * @throws NotFoundHttpException
377 379
      * @throws AccessDeniedHttpException
@@ -492,6 +494,9 @@  discard block
 block discarded – undo
492 494
         );
493 495
     }
494 496
 
497
+    /**
498
+     * @param \Doctrine\Common\Persistence\ObjectRepository $repo
499
+     */
495 500
     private function getMaxSortableField($repo, $sort)
496 501
     {
497 502
         $maxWeight = $repo->createQueryBuilder('i')
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Tests/AdminList/ConcreteConfigurator.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     }
25 25
 
26 26
     /**
27
-     * @return mixed
27
+     * @return boolean
28 28
      */
29 29
     public function buildFields()
30 30
     {
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     }
79 79
 
80 80
     /**
81
-     * @return Pagerfanta
81
+     * @return string
82 82
      */
83 83
     public function getPagerfanta()
84 84
     {
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
     }
87 87
 
88 88
     /**
89
-     * @return mixed
89
+     * @return ArrayIterator
90 90
      */
91 91
     public function getIterator()
92 92
     {
Please login to merge, or discard this patch.